Merging part 1 of external_deps work from #1433#1629
Merged
slipher merged 3 commits intoDaemonEngine:masterfrom Apr 3, 2025
Merged
Merging part 1 of external_deps work from #1433#1629slipher merged 3 commits intoDaemonEngine:masterfrom
slipher merged 3 commits intoDaemonEngine:masterfrom
Conversation
Member
|
LGTM I guess. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For my convenience as reviewer, I would like to break off digestible pieces of #1433. I will take on the responsibility of rebasing to solve merge conflicts and ensuring that the final state after all patches is the same as the original. Everything in this PR was written by illwieckz and now has my LGTM.
Tested using
--download-onlythat all 20 packages can be downloaded (for at least one target). Also tested the new--require-theirs.I have taken the liberty of removing a trailing slash from NASM_BASEURL.