Skip to content

Fix compile error with latest Appleclang#1643

Merged
slipher merged 1 commit intoDaemonEngine:masterfrom
slipher:macerr
May 1, 2025
Merged

Fix compile error with latest Appleclang#1643
slipher merged 1 commit intoDaemonEngine:masterfrom
slipher:macerr

Conversation

@slipher
Copy link
Copy Markdown
Member

@slipher slipher commented Apr 11, 2025

It complained about char_traits being requested somehow. Anyway allowing arbitrarily large sizes is bad in network code, so use a fixed-size buffer instead of the basic_string.

It complained about char_traits<unsigned char> being requested
somehow. Anyway allowing arbitrarily large sizes is bad in network
code, so use a fixed-size buffer instead of the basic_string<byte>.
Copy link
Copy Markdown
Member

@illwieckz illwieckz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@slipher slipher merged commit 4be85f3 into DaemonEngine:master May 1, 2025
9 checks passed
@slipher slipher deleted the macerr branch May 1, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants