Merged
Conversation
Member
|
The commit |
08bc877 to
3c9f26c
Compare
Contributor
Author
Fixed. |
Member
Member
|
illwieckz has said the station15 sun uses something called a "skybox portal". (You can see 2 copies of it if noclipping.) I have no idea where this implemented in the code. There is a flag called RF_SKYBOXPORTAL but it's never set anywhere, so apparently unrelated. |
Contributor
Author
3c9f26c to
e95ff27
Compare
slipher
reviewed
Apr 20, 2025
This seems to not have any noticeable impact on performance, while allowing merging a bit more vertices, since having more precision in them doesn't have any visible effect (~0.04 texels for a 4k texture).
e95ff27 to
ae37480
Compare
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #1651
I opted for making the hash not use uv's instead, as it didn't seem to have much of any effect on the loading time, but resulted in merging a few more vertices.
Also fixed sky brushes being added as surfaces to the material system.