Skip to content

Fix geometry optimiser#1652

Merged
VReaperV merged 4 commits intoDaemonEngine:masterfrom
VReaperV:fix-geometry-optimiser
Apr 20, 2025
Merged

Fix geometry optimiser#1652
VReaperV merged 4 commits intoDaemonEngine:masterfrom
VReaperV:fix-geometry-optimiser

Conversation

@VReaperV
Copy link
Copy Markdown
Contributor

Fixes #1651

I opted for making the hash not use uv's instead, as it didn't seem to have much of any effect on the loading time, but resulted in merging a few more vertices.

Also fixed sky brushes being added as surfaces to the material system.

@slipher
Copy link
Copy Markdown
Member

slipher commented Apr 18, 2025

The commit Don't hash the uv's in geometry optimiser does the opposite of its description. It adds them back to the hash, while the previous commit removes them.

@VReaperV VReaperV force-pushed the fix-geometry-optimiser branch from 08bc877 to 3c9f26c Compare April 18, 2025 19:42
@VReaperV
Copy link
Copy Markdown
Contributor Author

The commit Don't hash the uv's in geometry optimiser does the opposite of its description. It adds them back to the hash, while the previous commit removes them.

Fixed.

@slipher
Copy link
Copy Markdown
Member

slipher commented Apr 18, 2025

The station15 sun disappears when material system is enabled.

unvanquished-station15-autosprite1-sun

(There should be a sun)

@slipher
Copy link
Copy Markdown
Member

slipher commented Apr 18, 2025

illwieckz has said the station15 sun uses something called a "skybox portal". (You can see 2 copies of it if noclipping.) I have no idea where this implemented in the code. There is a flag called RF_SKYBOXPORTAL but it's never set anywhere, so apparently unrelated.

@VReaperV
Copy link
Copy Markdown
Contributor Author

The station15 sun disappears when material system is enabled.

unvanquished-station15-autosprite1-sun

(There should be a sun)

Fixed.

@VReaperV VReaperV force-pushed the fix-geometry-optimiser branch from 3c9f26c to e95ff27 Compare April 20, 2025 08:12
This seems to not have any noticeable impact on performance, while allowing merging a bit more vertices, since having more precision in them doesn't have any visible effect (~0.04 texels for a 4k texture).
@VReaperV VReaperV force-pushed the fix-geometry-optimiser branch from e95ff27 to ae37480 Compare April 20, 2025 09:31
@slipher
Copy link
Copy Markdown
Member

slipher commented Apr 20, 2025

LGTM

@VReaperV VReaperV merged commit 875f89b into DaemonEngine:master Apr 20, 2025
9 checks passed
@VReaperV VReaperV deleted the fix-geometry-optimiser branch April 20, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues with MergeDuplicateVertices hashing/equality

2 participants