Validate BSP vertex input#1653
Merged
VReaperV merged 2 commits intoDaemonEngine:masterfrom Apr 26, 2025
Merged
Conversation
enneract
reviewed
Apr 19, 2025
VReaperV
force-pushed
the
fix-bsp-input
branch
2 times, most recently
from
d3ce144 to
b11c9cf
Compare
q3map2 produces garbage lightmap values on some surfaces, so do this to make sure we don't get `nan` or `inf`.
slipher
reviewed
Apr 26, 2025
Member
slipher
left a comment
slipher
left a comment
There was a problem hiding this comment.
LGTM
Out of curiosity how do the NaNs break things so badly? I wouldn't have though just failing to obey the hash/equality contract could cause that.
Contributor
Author
It caused some out of bounds writes. The code assumed that there would, at most, be as many unique vertices as there are vertices in the .bsp, so I kept the hunk allocation that was already there for vertices/indices. With failing equality check though, it generated more vertices than there were oriinally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #1652 because it has some other fixes in this area, I didn't test this pr without those.
Apparently, q3map2 sometimes produces garbage values for lightmap uvs in vertices, like nan or just garbage like -1e38 which later turns into inf in patch meshes. Most of these don't use the lightmapping shader, however from my testing some do.
This fixes a crash in
MergeDuplicateVertices(), which was happening because of these garbages values, since they always compare as false.