NUKE RDF_SKYBOXPORTAL usages#1666
Merged
VReaperV merged 1 commit intoDaemonEngine:masterfrom May 21, 2025
Merged
Conversation
This is half of a feature from Wolf:ET, but we don't have the sgame/cgame counterpart, and none of the maps made for Unvanquished/Tremulous appear to use it.
VReaperV
force-pushed
the
nuke-rdf-skyportal-usage
branch
from
fcffda8 to
d1e461b
Compare
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is half of a feature from Wolf:ET, but we don't have the sgame/cgame counterpart, and none of the maps made for Unvanquished/Tremulous appear to use it. This was done in Wolf:ET by using a
misc_skyportalentity on the map, parsing it in sgame and sending the result through configstrings. Daemon/Unvanquished never actually setsRDF_SKYBOXPORTAL.We have maps that use background-in-a-box (
freeway,covidetc.), but they use a different mechanism and keep working correctly with this change.