NUKE forward lighting and shadow mapping#1670
Merged
slipher merged 6 commits intoDaemonEngine:masterfrom May 22, 2025
Merged
Conversation
Contributor
|
Good riddance to that shit. |
VReaperV
reviewed
May 21, 2025
Member
Author
|
Note to self: also delete |
VReaperV
reviewed
May 21, 2025
VReaperV
added
A-Renderer
T-NUKE-Request
refLightType_t and refLight_t are not used in IPC so they should not be in tr_types.h.
Some forward lighting junk.
The shadow code no longer produced any effect for a player shadow with 2 <= cg_shadows <= 6, regardless of r_realtimeLightingRenderer. The code was mostly designed for forward lighting anyway, which is being removed.
It still kinda worked but we don't want to maintain it. Fixes DaemonEngine#747.
slipher
commented
May 22, 2025
Member
Author
slipher
left a comment
slipher
left a comment
There was a problem hiding this comment.
Removed already-done TODOs and prevented any easily-avoidable merge conflicts with 0.56. But regardless I'll have to remember to go merge this into for-0.56 as soon as it's merged into master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #747.
Shadow mapping no longer works at all. Forward lighting dynamic lights still more or less work but we don't want to maintain it.