Material and u_Lights buffer clean-up#1671
Merged
VReaperV merged 6 commits intoDaemonEngine:masterfrom May 30, 2025
Merged
Conversation
VReaperV
added
T-Improvement
slipher
reviewed
May 29, 2025
Member
slipher
left a comment
slipher
left a comment
There was a problem hiding this comment.
Worked in my tests. Just style nits
VReaperV
force-pushed
the
material-buffer-cleanup
branch
from
83869cb to
db523da
Compare
Get rid of the requirement to not use binding point 0 for UBOs explicitly.
Less useless API calls, though for lightMapping shader on entities, which uses the core renderer at all times, this is till not the case.
VReaperV
force-pushed
the
material-buffer-cleanup
branch
from
db523da to
7588b47
Compare
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-arrange the buffer IDs so they make more sense when debugging, get rid of the requirement to not use bind 0 in
BufferBindby using explicit binding for theu_LightsUBO, and also make that work in the core renderer.Also removed the calls to bind/unbind buffers every frame (and even more often), reducing the amount of API calls.