rm deprecated endpoint & dto + fix tests

Author: Daggerpov

src/main/java/com/danielagapov/spawn/activity/internal/repositories/IActivityRepository.java

@@ -44,6 +44,6 @@ List<Activity> getPastActivitiesWhereUserInvited(
         @Param("now") OffsetDateTime now);
 
     // finds the most recently updated activity created by a user
-    @Query("SELECT a FROM Activity a WHERE a.creator.id = :creatorId ORDER BY a.lastUpdated DESC LIMIT 1")
-    Optional<Activity> findTopByCreatorIdOrderByLastUpdatedDesc(@Param("creatorId") UUID creatorId);
+    @Query("SELECT a FROM Activity a WHERE a.creator.id = :creatorId ORDER BY a.lastUpdated DESC")
+    Optional<Activity> findTopByCreatorIdOrderByLastUpdatedDesc(@Param("creatorId") UUID creatorId, org.springframework.data.domain.Limit limit);
 }

src/main/java/com/danielagapov/spawn/activity/internal/repositories/IActivityUserRepository.java

@@ -8,12 +8,14 @@
 import org.springframework.data.jpa.repository.JpaRepository;
 import org.springframework.data.jpa.repository.Query;
 import org.springframework.data.repository.query.Param;
+import org.springframework.stereotype.Repository;
 
 import java.time.OffsetDateTime;
 import java.util.List;
 import java.util.Optional;
 import java.util.UUID;
 
+@Repository
 public interface IActivityUserRepository extends JpaRepository<ActivityUser, ActivityUsersId> {
     List<ActivityUser> findByActivity_Id(UUID activityId);
 
@@ -30,7 +32,7 @@ public interface IActivityUserRepository extends JpaRepository<ActivityUser, Act
     @Query("SELECT au.activity.id FROM ActivityUser au WHERE au.user.id = :userId AND au.status = :status AND au.activity.endTime <= :now")
     List<UUID> findPastActivityIdsForUser(@Param("userId") UUID userId, @Param("status") ParticipationStatus status, @Param("now") OffsetDateTime now, Limit limit);
 
-    @Query("SELECT DISTINCT new com.danielagapov.spawn.activity.api.dto.UserIdActivityTimeDTO(au.user.id, MAX(au.activity.startTime)) FROM ActivityUser au WHERE au.activity.id IN :activityIds AND au.status = :status AND au.user.id != :userId GROUP BY au.user.id ORDER BY MAX(au.activity.startTime) DESC")
+    @Query("SELECT DISTINCT new com.danielagapov.spawn.activity.api.dto.UserIdActivityTimeDTO(au.user.id, MAX(au.activity.startTime)) FROM ActivityUser au WHERE au.activity.id IN :activityIds AND au.status = :status AND au.user.id <> :userId GROUP BY au.user.id ORDER BY MAX(au.activity.startTime) DESC")
     List<UserIdActivityTimeDTO> findOtherUserIdsByActivityIds(List<UUID> activityIds, UUID userId, ParticipationStatus status);
 
     Optional<ActivityUser> findByActivity_IdAndUser_Id(UUID activityId, UUID userId);
@@ -56,6 +58,6 @@ public interface IActivityUserRepository extends JpaRepository<ActivityUser, Act
     @Query("SELECT au FROM ActivityUser au WHERE au.activity.id IN :activityIds")
     List<ActivityUser> findAllByActivityIds(@Param("activityIds") List<UUID> activityIds);
 
-    @Query("SELECT au FROM ActivityUser au JOIN au.activity a WHERE au.user.id = :userId AND au.status = :status ORDER BY a.lastUpdated DESC LIMIT 1")
-    Optional<ActivityUser> findTopByUserIdAndStatusOrderByActivityLastUpdatedDesc(@Param("userId") UUID userId, @Param("status") ParticipationStatus status);
+    @Query("SELECT au FROM ActivityUser au JOIN au.activity a WHERE au.user.id = :userId AND au.status = :status ORDER BY a.lastUpdated DESC")
+    Optional<ActivityUser> findTopByUserIdAndStatusOrderByActivityLastUpdatedDesc(@Param("userId") UUID userId, @Param("status") ParticipationStatus status, org.springframework.data.domain.Limit limit);
 }

src/main/java/com/danielagapov/spawn/activity/internal/services/ActivityService.java

@@ -1168,7 +1168,7 @@ public List<FullFeedActivityDTO> convertActivitiesToFullFeedSelfOwnedActivities(
     @Override
     public Instant getLatestCreatedActivityTimestamp(UUID userId) {
         try {
-            return repository.findTopByCreatorIdOrderByLastUpdatedDesc(userId)
+            return repository.findTopByCreatorIdOrderByLastUpdatedDesc(userId, org.springframework.data.domain.Limit.of(1))
                     .map(Activity::getLastUpdated)
                     .orElse(null);
         } catch (DataAccessException e) {
@@ -1180,7 +1180,7 @@ public Instant getLatestCreatedActivityTimestamp(UUID userId) {
     @Override
     public Instant getLatestInvitedActivityTimestamp(UUID userId) {
         try {
-            return activityUserRepository.findTopByUserIdAndStatusOrderByActivityLastUpdatedDesc(userId, ParticipationStatus.invited)
+            return activityUserRepository.findTopByUserIdAndStatusOrderByActivityLastUpdatedDesc(userId, ParticipationStatus.invited, org.springframework.data.domain.Limit.of(1))
                     .map(ActivityUser -> ActivityUser.getActivity().getLastUpdated())
                     .orElse(null);
         } catch (DataAccessException e) {
@@ -1192,7 +1192,7 @@ public Instant getLatestInvitedActivityTimestamp(UUID userId) {
     @Override
     public Instant getLatestUpdatedActivityTimestamp(UUID userId) {
         try {
-            return activityUserRepository.findTopByUserIdAndStatusOrderByActivityLastUpdatedDesc(userId, ParticipationStatus.participating)
+            return activityUserRepository.findTopByUserIdAndStatusOrderByActivityLastUpdatedDesc(userId, ParticipationStatus.participating, org.springframework.data.domain.Limit.of(1))
                     .map(ActivityUser -> ActivityUser.getActivity().getLastUpdated())
                     .orElse(null);
         } catch (DataAccessException e) {

src/main/java/com/danielagapov/spawn/analytics/internal/repositories/IFeedbackSubmissionRepository.java

@@ -2,8 +2,10 @@
 
 import com.danielagapov.spawn.analytics.internal.domain.FeedbackSubmission;
 import org.springframework.data.jpa.repository.JpaRepository;
+import org.springframework.stereotype.Repository;
 
 import java.util.UUID;
 
+@Repository
 public interface IFeedbackSubmissionRepository extends JpaRepository<FeedbackSubmission, UUID> {
 }

src/main/java/com/danielagapov/spawn/analytics/internal/repositories/IReportedContentRepository.java

@@ -4,10 +4,12 @@
 import com.danielagapov.spawn.shared.util.ReportType;
 import com.danielagapov.spawn.analytics.internal.domain.ReportedContent;
 import org.springframework.data.jpa.repository.JpaRepository;
+import org.springframework.stereotype.Repository;
 
 import java.util.List;
 import java.util.UUID;
 
+@Repository
 public interface IReportedContentRepository extends JpaRepository<ReportedContent, UUID> {
     List<ReportedContent> getAllByContentTypeAndReportType(EntityType contentType, ReportType reportType);
 

src/main/java/com/danielagapov/spawn/auth/internal/repositories/IEmailVerificationRepository.java

@@ -2,9 +2,11 @@
 
 import com.danielagapov.spawn.auth.internal.domain.EmailVerification;
 import org.springframework.data.jpa.repository.JpaRepository;
+import org.springframework.stereotype.Repository;
 
 import java.util.UUID;
 
+@Repository
 public interface IEmailVerificationRepository extends JpaRepository<EmailVerification, UUID> {
 
     EmailVerification findByEmail(String email);

src/main/java/com/danielagapov/spawn/user/api/UserController.java

@@ -290,32 +290,6 @@ public ResponseEntity<List<RecentlySpawnedUserDTO>> getRecentlySpawnedWithUsers(
         }
     }
 
-    // full path: /api/v1/users/{userId}/is-friend/{potentialFriendId}
-    // @deprecated Use GET /api/v1/users/{id}?requestingUserId={requestingUserId} instead.
-    // The user endpoint now returns relationshipStatus and pendingFriendRequestId fields
-    // when requestingUserId is provided, eliminating the need for this separate endpoint.
-    @Deprecated(since = "1.0", forRemoval = true)
-    @GetMapping("{userId}/is-friend/{potentialFriendId}")
-    public ResponseEntity<Boolean> isUserFriendOfUser(
-            @PathVariable UUID userId,
-            @PathVariable UUID potentialFriendId) {
-        if (userId == null || potentialFriendId == null) {
-            logger.error("Invalid parameters: userId or potentialFriendId is null");
-            return new ResponseEntity<>(HttpStatus.BAD_REQUEST);
-        }
-        
-        try {
-            boolean isFriend = userService.isUserFriendOfUser(userId, potentialFriendId);
-            return new ResponseEntity<>(isFriend, HttpStatus.OK);
-        } catch (BaseNotFoundException e) {
-            logger.error("User not found for friend check: " + e.getMessage());
-            return new ResponseEntity<>(HttpStatus.NOT_FOUND);
-        } catch (Exception e) {
-            logger.error("Error checking if user " + LoggingUtils.formatUserIdInfo(userId) + " is friend of user " + LoggingUtils.formatUserIdInfo(potentialFriendId) + ": " + e.getMessage());
-            return new ResponseEntity<>(HttpStatus.INTERNAL_SERVER_ERROR);
-        }
-    }
-
     // full path: /api/v1/users/{userId}/profile-info
     @GetMapping("{userId}/profile-info")
     public ResponseEntity<UserProfileInfoDTO> getUserProfileInfo(@PathVariable UUID userId) {

src/main/java/com/danielagapov/spawn/user/api/dto/BaseUserDTO.java

@@ -37,6 +37,15 @@ public BaseUserDTO(UUID id, String name, String email, String username, String b
         this.pendingFriendRequestId = null;
     }
 
+    public BaseUserDTO(UUID id, String name, String email, String username, String bio, String profilePicture, Boolean hasCompletedOnboarding, String provider) {
+        super(id, name, email, username, bio);
+        this.profilePicture = profilePicture;
+        this.hasCompletedOnboarding = hasCompletedOnboarding != null ? hasCompletedOnboarding : false;
+        this.provider = provider;
+        this.relationshipStatus = null;
+        this.pendingFriendRequestId = null;
+    }
+
     @JsonCreator
     public BaseUserDTO(
             @JsonProperty("id") UUID id, 
@@ -56,22 +65,4 @@ public BaseUserDTO(
         this.relationshipStatus = relationshipStatus;
         this.pendingFriendRequestId = pendingFriendRequestId;
     }
-
-    // Backward-compatible constructor (without relationship fields)
-    public BaseUserDTO(
-            UUID id, 
-            String name, 
-            String email, 
-            String username, 
-            String bio, 
-            String profilePicture, 
-            Boolean hasCompletedOnboarding,
-            String provider) {
-        super(id, name, email, username, bio);
-        this.profilePicture = profilePicture;
-        this.hasCompletedOnboarding = hasCompletedOnboarding != null ? hasCompletedOnboarding : false;
-        this.provider = provider;
-        this.relationshipStatus = null;
-        this.pendingFriendRequestId = null;
-    }
 }

src/test/java/com/danielagapov/spawn/ServiceTests/UserServiceTests.java

@@ -89,6 +89,7 @@ void setUp() {
             logger,
             userSearchQueryService,
             friendshipQueryService,
+            friendRequestService,
             cacheManager,
             eventPublisher,
             userIdExternalIdMapRepository