Conversation
- Add @ApplicationScoped to IChatQueryService - Add @ApplicationScoped to IUserQueryService - Add @ApplicationScoped to IUserSearchQueryService - Update service classes to use ApplicationScoped interfaces - Improves Spring Modulith module boundary definitions
- Move ChatMessage.java to activity.internal.domain - Move ChatMessageLikes.java to activity.internal.domain - Move ChatMessageLikesId.java to activity.internal.domain - Move IChatMessageRepository to activity.internal.repositories - Move IChatMessageLikesRepository to activity.internal.repositories Chat messages are intrinsically tied to activities, so they belong in the activity module. This improves module cohesion and follows Spring Modulith best practices for shared data ownership.
- Merge all InternalActivityService methods into ActivityService - Expand IActivityService public API with activity CRUD operations - Delete IInternalActivityService and InternalActivityService classes - Simplifies architecture by removing unnecessary layer - All activity operations now accessible through single service This consolidation eliminates redundant service layers and provides a cleaner API surface for other modules to interact with activities.
- Update ChatMessageService to import from activity.internal.domain - Update ChatMessageMapper with new entity package path - Update ChatMessageLikesMapper with new entity package path - Use IActivityService API instead of direct repository access Follows the entity move to activity module and maintains proper module boundaries by using the public API where appropriate.
- Update ActivityControllerTests to use consolidated ActivityService - Update CacheServiceTests with ApplicationScoped interfaces - Update ChatMessageServiceTests for entity package changes - Update documentation to reflect Phase 3 completion - Update README files with latest refactoring status All tests updated to work with the refactored module structure.
…ments Leaner activity creation response (MinimalFriendDTO)
…ments Api changes for mobile improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closer to microservices (modular monolith) + Misc. client (mobile) impacting changes for performance, bug fixes, etc.
Instead of outside services like
UserService,UserSearchService,UserStatsService,ChatMessageServiceand from events likeActivityUpdateNotificationEvent,NewCommentNotificationEventaccessingActivityUserRepositoryandActivityRepositorydirectly, this will abstract that.Mobile-Facing Changes:
MinimalFriendDTOto reduce memory in some cases where extra details not needed