Skip to content

Improve management of instrumental files#143

Draft
Neraste wants to merge 6 commits into
developfrom
feature/improve-instrumental-files
Draft

Improve management of instrumental files#143
Neraste wants to merge 6 commits into
developfrom
feature/improve-instrumental-files

Conversation

@Neraste

@Neraste Neraste commented Jul 8, 2026

Copy link
Copy Markdown
Member

Use the instrumental_file and instrumental_track fields instead of re-discovering the instrumental file or track.

Side effect:

  • The manage_instrumental method belongs now to the MediaPlayer abstract class, and is hence common to both VLC and Mpv media players;
  • Dropped the dependency to filetypes.

Related to:

@Neraste Neraste self-assigned this Jul 8, 2026
@Neraste Neraste added enhancement New feature or request refactor Make things more beautiful inside, but same outside labels Jul 8, 2026
@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.04%. Comparing base (3c72719) to head (2f280c8).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #143      +/-   ##
===========================================
- Coverage    98.04%   98.04%   -0.01%     
===========================================
  Files           16       15       -1     
  Lines         1381     1379       -2     
===========================================
- Hits          1354     1352       -2     
  Misses          27       27              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request refactor Make things more beautiful inside, but same outside

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant