fix(playground): server-side memory cleanup on session expiry + startup purge (DAK-6975)#231
Merged
Merged
Conversation
…up purge (DAK-6975)
BUG 1: sweep() only removed sessions from the in-memory Map — engine memories
persisted forever in RocksDB. Now tracks namespaces per session and calls
DELETE /v1/namespaces/{ns} on expiry (both sweep timer and resolve-time expiry).
BUG 6: Historical playground-demo-* namespaces accumulated from all past sessions.
Added startup purge that lists all namespaces and deletes playground-demo-* ones.
4 new tests: onExpire callback, resolve-time cleanup, trackNamespace dedup, no-op
when no namespaces tracked. All 64 tests pass.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sweep()now triggers engine namespace deletion on session expiry. AddedonExpirecallback toSessionStore, namespace tracking per session viatrackNamespace(), and cleanup on both sweep-timer and resolve-time expiry paths.playground-demo-*ones, cleaning up historical data accumulation.Changes
sessions.jsonExpirecallback,trackNamespace(), cleanup in bothsweep()andresolve()server.jsindex.jsonExpireto DELETE engine namespaces + startup purge routineproxy.test.jsTest plan
node --test proxy.test.js)🤖 Generated with Claude Code