fix(monitoring): correct PromQL syntax and align metric names#246
Merged
Conversation
…rver
- Fix group() → group_left() in resource alert binary operations
- Remove {job="dakera"} filter from container_spec_memory_limit_bytes
(cAdvisor metrics have their own job label)
- Swap dakera_cluster_nodes_total → dakera_replica_count (the metric
the server actually emits)
- Add future-ready comments on alerts referencing not-yet-emitted metrics
- Document cAdvisor dependency in header tuning notes
Follow-up to PR#245 by @extremecoder-rgb.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
group()→group_left()in resource alert binary operations (invalid PromQL syntax){job="dakera"}filter fromcontainer_spec_memory_limit_bytes— cAdvisor metrics use their own job label, notdakeradakera_cluster_nodes_total→dakera_replica_count— the metric the Dakera server actually emitsdakera_decay_cycle_duration_seconds,dakera_l2_cache_*)Follow-up to #245 by @extremecoder-rgb.
Test plan
docker compose config --quietvalidates YAMLpromtool check rules monitoring/alerting-rules.ymlpasses (if promtool available)🤖 Generated with Claude Code