Skip to content

Commit a337426

Browse files
committed
fix reports on frontendmentor
1 parent a843df7 commit a337426

6 files changed

Lines changed: 119 additions & 56 deletions

File tree

.gitignore

Lines changed: 35 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,40 @@
1-
# Avoid accidental upload of the Sketch and Figma design files
2-
#####################################################
3-
## Please do not remove lines 5 and 6 - thanks! 🙂 ##
4-
#####################################################
1+
# Design files (please do not remove 🙂)
52
*.sketch
63
*.fig
7-
8-
# Avoid accidental XD upload if you convert the design file
9-
###############################################
10-
## Please do not remove line 12 - thanks! 🙂 ##
11-
###############################################
124
*.xd
135

14-
# Avoid your project being littered with annoying .DS_Store files!
6+
# Dependencies
7+
/node_modules
8+
/.pnp
9+
.pnp.js
10+
yarn.debug.log*
11+
yarn.error.log*
12+
npm-debug.log*
13+
14+
# Environment and secrets
15+
.env
16+
.env.local
17+
.env.development.local
18+
.env.test.local
19+
.env.production.local
20+
21+
# Testing
22+
/coverage
23+
24+
# Production
25+
/build
26+
/dist
27+
/.next
28+
/out
29+
30+
# IDEs and editors
31+
/.idea
32+
/.vscode
33+
*.swp
34+
*.swo
35+
36+
# Misc
37+
*.log
38+
*.pem
1539
.DS_Store
16-
.prettierignore
40+
Thumbs.db

assets/styles/base/_variables.scss

Lines changed: 37 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -4,25 +4,44 @@
44

55
/* || Global Variables
66
*************************/
7-
/* || Colors
8-
*************************/
9-
$white: #ffffff;
10-
$light-gray: #d6e2f0;
11-
$grayish-blue: #7b879d;
12-
$dark-blue: #1f3251;
7+
:root {
8+
/* || Colors
9+
*************************/
10+
--white: #ffffff;
11+
--light-gray: #d6e2f0;
12+
--grayish-blue: #7b879d;
13+
--dark-blue: #1f3251;
1314

14-
/* || Fonts
15-
*************************/
16-
$outfit: "Outfit", sans-serif;
15+
/* || Fonts
16+
*************************/
17+
--outfit: "Outfit", sans-serif;
1718

18-
/* || Spacing
19-
*************************/
20-
$space-xs: 0.5rem;
21-
$space-sm: 1rem;
22-
$space-md: 1.5rem;
23-
$space-lg: 2.5rem;
19+
/* || Spacing
20+
*************************/
21+
--space-xs: 0.5rem;
22+
--space-sm: 1rem;
23+
--space-md: 1.5rem;
24+
--space-lg: 2.5rem;
25+
26+
/* || Font sizes
27+
*************************/
28+
--fs-sm: 0.9375rem;
29+
--fs-md: 1.375rem;
30+
}
2431

25-
/* || Font sizes
32+
/* || SCSS Aliases
2633
*************************/
27-
$fs-sm: 0.9375rem;
28-
$fs-md: 1.375rem;
34+
$white: var(--white);
35+
$light-gray: var(--light-gray);
36+
$grayish-blue: var(--grayish-blue);
37+
$dark-blue: var(--dark-blue);
38+
39+
$outfit: var(--outfit);
40+
41+
$space-xs: var(--space-xs);
42+
$space-sm: var(--space-sm);
43+
$space-md: var(--space-md);
44+
$space-lg: var(--space-lg);
45+
46+
$fs-sm: var(--fs-sm);
47+
$fs-md: var(--fs-md);

assets/styles/components/_card.scss

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
*************************/
33
.card {
44
padding: $space-sm $space-sm $space-lg;
5-
max-width: 320px;
6-
border-radius: 20px;
5+
max-width: 20rem;
6+
border-radius: 1.25rem;
77

88
background-color: $white;
99
box-shadow: 0px 25px 25px rgba(0, 0, 0, 0.0476518);
@@ -29,13 +29,15 @@
2929
*************************/
3030
&__title {
3131
font-size: $fs-md;
32+
font-weight: 700;
33+
line-height: 1.75rem;
3234
color: $dark-blue;
3335
}
3436

3537
/* || Description
3638
*************************/
3739
&__description {
38-
margin-top: $space-sm;
40+
margin-block-start: $space-sm;
3941

4042
font-size: $fs-sm;
4143
font-weight: 400;

assets/styles/layout/_body.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ body {
88
/* || Main Element
99
*************************/
1010
main {
11-
height: 100vh;
11+
min-height: 100vh;
1212

1313
display: flex;
1414
justify-content: center;
1515
align-items: center;
16-
}
16+
}

assets/styles/styles.css

Lines changed: 39 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,29 @@
77
@import url("https://fonts.googleapis.com/css2?family=Outfit:wght@100..900&display=swap");
88
/* || Global Variables
99
*************************/
10-
/* || Colors
11-
*************************/
12-
/* || Fonts
13-
*************************/
14-
/* || Spacing
15-
*************************/
16-
/* || Font sizes
10+
:root {
11+
/* || Colors
12+
*************************/
13+
--white: #ffffff;
14+
--light-gray: #d6e2f0;
15+
--grayish-blue: #7b879d;
16+
--dark-blue: #1f3251;
17+
/* || Fonts
18+
*************************/
19+
--outfit: "Outfit", sans-serif;
20+
/* || Spacing
21+
*************************/
22+
--space-xs: 0.5rem;
23+
--space-sm: 1rem;
24+
--space-md: 1.5rem;
25+
--space-lg: 2.5rem;
26+
/* || Font sizes
27+
*************************/
28+
--fs-sm: 0.9375rem;
29+
--fs-md: 1.375rem;
30+
}
31+
32+
/* || SCSS Aliases
1733
*************************/
1834
/* || Reset
1935
*************************/
@@ -28,14 +44,14 @@
2844
/* || Body Element
2945
*************************/
3046
body {
31-
background-color: #d6e2f0;
32-
font-family: "Outfit", sans-serif;
47+
background-color: var(--light-gray);
48+
font-family: var(--outfit);
3349
}
3450

3551
/* || Main Element
3652
*************************/
3753
main {
38-
height: 100vh;
54+
min-height: 100vh;
3955
display: flex;
4056
justify-content: center;
4157
align-items: center;
@@ -46,10 +62,10 @@ main {
4662
/* || Card Component
4763
*************************/
4864
.card {
49-
padding: 1rem 1rem 2.5rem;
50-
max-width: 320px;
51-
border-radius: 20px;
52-
background-color: #ffffff;
65+
padding: var(--space-sm) var(--space-sm) var(--space-lg);
66+
max-width: 20rem;
67+
border-radius: 1.25rem;
68+
background-color: var(--white);
5369
box-shadow: 0px 25px 25px rgba(0, 0, 0, 0.0476518);
5470
/* || Image
5571
*************************/
@@ -67,19 +83,21 @@ main {
6783
display: block;
6884
}
6985
.card__content {
70-
margin-top: 1.5rem;
71-
padding: 0 1rem;
86+
margin-top: var(--space-md);
87+
padding: 0 var(--space-sm);
7288
text-align: center;
7389
}
7490
.card__title {
75-
font-size: 1.375rem;
76-
color: #1f3251;
91+
font-size: var(--fs-md);
92+
font-weight: 700;
93+
line-height: 1.75rem;
94+
color: var(--dark-blue);
7795
}
7896
.card__description {
79-
margin-top: 1rem;
80-
font-size: 0.9375rem;
97+
margin-block-start: var(--space-sm);
98+
font-size: var(--fs-sm);
8199
font-weight: 400;
82100
letter-spacing: 0.1875px;
83101
line-height: 1.1875rem;
84-
color: #7b879d;
102+
color: var(--grayish-blue);
85103
}

index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<!DOCTYPE html>
2-
<html lang="en">
2+
<html lang="en" dir="ltr">
33
<head>
44
<meta charset="UTF-8">
55
<meta name="viewport" content="width=device-width, initial-scale=1.0">

0 commit comments

Comments
 (0)