Ptr#359
Open
adavak wants to merge 11 commits into
Open
Conversation
… fix status indicator prompts
…e key for separator dropdown - GUI.lua: wrap Left/Right/Up/Down display strings in L[] (4 dropdowns) - TagsDatabase.lua: wrap 'Space' separator label in L[] - enUS.lua: add L['Space'] = 'Space' - zhCN.lua: add L['Space'] = '空格'
- Extract GetColourOrDefault() helper to safely unpack colour tables - Add nil safeguards for HealthBarDB.Background (the crash trigger) - Add nil safeguards for HealthBarDB.Foreground (same pattern risk) - Add or 1 fallback for ForegroundOpacity and or 0.25 for BackgroundOpacity Fixes: attempt to index field 'Background' (a nil value) when switching profiles with incomplete saved variables
Aura.duration and aura.expirationTime can be secret values in Retail/Classic WoW. Direct comparison throws: attempt to compare local 'duration' (a secret value) Wrap the check with UUF:IsSecretValue() before comparing.
…alue taint AuraUtil.DefaultAuraCompare calls UnitIsUnit internally, which throws when aura data contains secret values during addon-tainted table.sort execution. Fall back to UUF's own sort (isPlayerAura, auraInstanceID).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
locale function add.
copy profile problem fix.