fix: Table chart dimension fallback in normalize_dimensions#1367
Draft
sentry[bot] wants to merge 1 commit into
Draft
fix: Table chart dimension fallback in normalize_dimensions#1367sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the
ValueError: At least one dimension is required for table charts(DALGO-BACKEND-27X) occurring when requesting data previews for table charts via the public API.Problem:
Table charts were failing if dimensions were specified using the legacy
dimension_colandextra_dimensionfields, while thedimensionslist in the payload was empty. Thenormalize_dimensionsfunction, specifically forchart_type == "table", was only checkingpayload.dimensionsand not falling back to the legacy fields, leading to an empty list of dimensions being returned.Root Cause:
The
normalize_dimensionsfunction had a missing fallback mechanism for table charts. While the non-table chart branch correctly utilizeddimension_colandextra_dimensionwhenpayload.dimensionswas not provided, the table chart branch did not, despite its docstring indicating backward compatibility handling.Solution:
Implemented a fallback in
normalize_dimensionsfor table charts. Ifpayload.dimensionsis empty or contains only blank strings, the function now populates the dimensions list usingpayload.dimension_colandpayload.extra_dimension, ensuring that charts configured with these legacy fields function correctly.Fixes DALGO-BACKEND-27X