fix: Add dimension fallback for table charts#1368
Draft
sentry[bot] wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue DALGO-BACKEND-25E, a
ValueError: At least one dimension is required for table charts.Root Cause:
The
normalize_dimensionsfunction inddpui/core/charts/charts_service.pyforchart_type="table"only checked thepayload.dimensionslist. It did not include a fallback topayload.dimension_colorpayload.extra_dimensionwhenpayload.dimensionswas empty orNone. This meant that table charts created using older API fields (which populatedimension_colinstead of thedimensionsarray) would result in an empty dimension list, triggering theValueErrorat line 387.Changes Made:
Modified the
normalize_dimensionsfunction to include the fallback logic forpayload.dimension_colandpayload.extra_dimensionwithin thechart_type="table"branch. Now, ifpayload.dimensionsis empty, the function will correctly check and use the values frompayload.dimension_colandpayload.extra_dimensionif they are present.This change restores backward compatibility for table charts using legacy dimension fields.
Fixes DALGO-BACKEND-25E