Skip to content

Commit c533935

Browse files
committed
Add tests
1 parent d730b55 commit c533935

File tree

1 file changed

+28
-0
lines changed

1 file changed

+28
-0
lines changed

server/src/test/java/org/apache/cloudstack/backup/BackupManagerTest.java

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@
9191
import org.apache.cloudstack.framework.config.impl.ConfigDepotImpl;
9292
import org.apache.cloudstack.storage.datastore.db.PrimaryDataStoreDao;
9393
import org.apache.cloudstack.storage.datastore.db.StoragePoolVO;
94+
import org.apache.cloudstack.framework.jobs.AsyncJobManager;
9495
import org.apache.cloudstack.framework.jobs.impl.AsyncJobVO;
9596
import org.junit.After;
9697
import org.junit.Assert;
@@ -241,6 +242,9 @@ public class BackupManagerTest {
241242
@Mock
242243
private GuestOSDao _guestOSDao;
243244

245+
@Mock
246+
AsyncJobManager asyncJobManager;
247+
244248
private Gson gson;
245249

246250
private String[] hostPossibleValues = {"127.0.0.1", "hostname"};
@@ -1489,6 +1493,7 @@ public void testDeleteBackupVmNotFound() {
14891493
when(backup.getAccountId()).thenReturn(accountId);
14901494
when(backup.getBackupOfferingId()).thenReturn(backupOfferingId);
14911495
when(backup.getSize()).thenReturn(100L);
1496+
when(backup.getUuid()).thenReturn("backup-uuid");
14921497

14931498
overrideBackupFrameworkConfigValue();
14941499

@@ -1523,6 +1528,29 @@ public void testDeleteBackupVmNotFound() {
15231528
}
15241529
}
15251530

1531+
@Test(expected = CloudRuntimeException.class)
1532+
public void testDeleteBackupBlockedByPendingJobs() {
1533+
Long backupId = 1L;
1534+
Long vmId = 2L;
1535+
1536+
BackupVO backup = mock(BackupVO.class);
1537+
when(backup.getVmId()).thenReturn(vmId);
1538+
when(backup.getUuid()).thenReturn("backup-uuid");
1539+
when(backupDao.findByIdIncludingRemoved(backupId)).thenReturn(backup);
1540+
1541+
VMInstanceVO vm = mock(VMInstanceVO.class);
1542+
when(vmInstanceDao.findByIdIncludingRemoved(vmId)).thenReturn(vm);
1543+
1544+
overrideBackupFrameworkConfigValue();
1545+
1546+
when(asyncJobManager.countPendingJobs("backup-uuid",
1547+
"org.apache.cloudstack.api.command.user.vm.CreateVMFromBackupCmd",
1548+
"org.apache.cloudstack.api.command.admin.vm.CreateVMFromBackupCmdByAdmin",
1549+
"org.apache.cloudstack.api.command.user.backup.RestoreBackupCmd")).thenReturn(1L);
1550+
1551+
backupManager.deleteBackup(backupId, false);
1552+
}
1553+
15261554
@Test
15271555
public void testNewBackupResponse() {
15281556
Long vmId = 1L;

0 commit comments

Comments
 (0)