Fix spinning loader when expired is the only contract tab#145
Merged
Conversation
When a device or VM has only expired contracts, the Expired tab is auto-selected as the default active tab. However, its content was loaded via hx-trigger="click once", which never fires because the tab was selected programmatically, not clicked. Changed the trigger to use "load" when expired is the only tab so content loads immediately.
DanSheps
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #144
The expired contracts tab uses
hx-trigger="click once"to lazy-load its content. When expired is the only tab, it gets auto-selected as the default -- but the click event never fires since the tab was activated programmatically. The spinner stays forever.Changed the trigger to
loadwhen expired is the only tab so the content loads immediately on render. When other tabs exist, it still lazy-loads on click as before.Affects both device and VM contract templates.