-
-
Notifications
You must be signed in to change notification settings - Fork 20
Closes: #157 - Modernize Lifecycle Plugin #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DanSheps
wants to merge
9
commits into
main
Choose a base branch
from
close-157
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ede881d
Closes: #157 - Modernize Lifecycle Plugin to take advantage of new Ne…
DanSheps 850dfae
Add quickadd to relevant forms
DanSheps 84d3b59
Fix Circular Import
DanSheps 4b47917
Update linting configuration to ignore additional rules
DanSheps 9d09c92
Fix test error
DanSheps d13a2b0
Update netbox_lifecycle/template_content.py
DanSheps 75dc83e
Apply suggestions from code review
DanSheps 77775f0
Fix missing contract tabs
DanSheps 7ffda13
Adjust `filter_status` filter to exclude future contracts
DanSheps File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| from .contract import ContractStatusChoices | ||
|
|
||
| __all__ = ('ContractStatusChoices',) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| from django.utils.translation import gettext as _ | ||
| from utilities.choices import ChoiceSet | ||
|
|
||
| from netbox_lifecycle import constants | ||
|
|
||
|
|
||
| class ContractStatusChoices(ChoiceSet): | ||
| """ | ||
| Support contract status choices. | ||
| """ | ||
|
|
||
| ACTIVE = constants.CONTRACT_STATUS_ACTIVE | ||
| EXPIRED = constants.CONTRACT_STATUS_EXPIRED | ||
| FUTURE = constants.CONTRACT_STATUS_FUTURE | ||
| UNSPECIFIED = constants.CONTRACT_STATUS_UNSPECIFIED | ||
|
|
||
| CHOICES = ( | ||
| (ACTIVE, _('Active')), | ||
| (FUTURE, _('Future')), | ||
| (UNSPECIFIED, _('Unspecified')), | ||
| (EXPIRED, _('Expired')), | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.