Skip to content

Commit 068b2f1

Browse files
committed
Review follow-up nits: secret-value guard, OOR fold trigger, changelog wording
- Dispel SafeRectSize: replace the dead canaccessvalue guard (not a callable global — canAccessValue is only a doc return-field name) with issecretvalue, the real global already localised here. GetHeight/GetWidth can return a secret number without throwing; that is not a usable measure. - MigrateOORTextAlpha: fold oorNameTextAlpha on PRESENCE, not the _oorTextAlphaV1 flag. A v4 export imported over an already-migrated profile reintroduced the key; the flag-gated fold skipped it while the strip still deleted it, silently resetting the imported OOR alpha. - Changelog: trim the resource-bar entry's anchoring internals to plain user language (kept the forbidden-object error quote for searchability).
1 parent bdc0d50 commit 068b2f1

3 files changed

Lines changed: 16 additions & 4 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ DandersFrames has been rebuilt for WoW 12.1 (Midnight), which fundamentally chan
4343
* (Aura Designer) The Frame Strata dropdowns, the global Default Frame Level, and "Draw above frame border" are now marked as not yet available on 12.1 — they previously looked live but weren't applied (indicator z-order is engine-managed for now; the per-indicator Frame Level slider does work). Planned to return with a z-order pass.
4444
* (Interface) Removed the Resurrection icon's "Pending Text" box and the "My Buff Indicators" export category — neither had done anything (the text was never rendered; the category exported no settings).
4545
* (Auras) Fixed an error ("Attempt to access forbidden object") from the dispel overlay when zoning out of an instance mid-run — the overlay's layout pass could measure a protected aura-button rect during the transition; it now measures safely and falls back to defaults for that one pass.
46-
* (Bars) Fixed a gap between a "Match Health Bar Width" resource bar and the frame border (most visible at border sizes 1-3 with a non-zero Frame Padding). The bar now sits flush against the innermost boundary — the border band or the health bar inset, whichever is inner — and its ends anchor to the same frame corners the border does so the two can't round apart at any UI scale.
46+
* (Bars) Fixed a gap on either side of a "Match Health Bar Width" resource bar at frame border sizes 1-3 (most visible with a non-zero Frame Padding). The bar now sits flush inside the border, and stays aligned with it at any UI scale.
4747
* (Frames) Fixed grouped raid frames staying invisible after converting a raid to a party and back until a /reload — the frames were alive underneath, but their group anchors were never restored on re-entering the raid.
4848
* (Frames) Clicks on party and raid frames no longer redirect to a member's vehicle or pet slot while the game flags them as being in a vehicle (sitting on housing furniture counts) — a legacy behaviour Blizzard's own frames dropped, which could target the wrong unit or open a pet menu.
4949
* (Auras) **The Aura Blacklist has been retired**, replaced by the new filter system. Previously blacklisted buffs will show again — hide them via the Filter Designer instead. Individual debuffs can't be hidden on this version of the game.

Core.lua

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2883,8 +2883,16 @@ function DF:MigrateOORTextAlpha()
28832883
for _, modeKey in ipairs({ "party", "raid" }) do
28842884
local m = profile[modeKey]
28852885
if type(m) == "table" then
2886-
if not profile._oorTextAlphaV1
2887-
and m.oorNameTextAlpha ~= nil and m.oorNameTextAlpha ~= 1 then
2886+
-- Fold the retired per-element name-alpha into the unified
2887+
-- oorTextAlpha whenever it is PRESENT (a non-default value),
2888+
-- not gated on the _oorTextAlphaV1 flag: a v4 export imported
2889+
-- over an already-migrated profile reintroduces
2890+
-- oorNameTextAlpha, and a flag-gated fold would skip it while
2891+
-- the strip below still deletes it — silently resetting the
2892+
-- imported OOR alpha. oorNameTextAlpha only ever exists on
2893+
-- un-folded data (this pass strips it), so presence is the
2894+
-- correct trigger and can't clobber a deliberate oorTextAlpha.
2895+
if m.oorNameTextAlpha ~= nil and m.oorNameTextAlpha ~= 1 then
28882896
m.oorTextAlpha = m.oorNameTextAlpha
28892897
end
28902898
-- The per-element keys are retired (every reader now uses

Features/Dispel.lua

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,11 @@ local function SafeRectSize(region)
340340
local okH, h = pcall(region.GetHeight, region)
341341
local okW, w = pcall(region.GetWidth, region)
342342
if not okH or not okW then return nil, nil end
343-
if canaccessvalue and (not canaccessvalue(h) or not canaccessvalue(w)) then
343+
-- GetHeight/GetWidth can return a SECRET number without throwing (restricted
344+
-- content); a secret dimension is not a usable measure. issecretvalue is the
345+
-- real global for this (canaccessvalue is not a callable global — it's only a
346+
-- documented return-field name).
347+
if issecretvalue(h) or issecretvalue(w) then
344348
return nil, nil
345349
end
346350
return h, w

0 commit comments

Comments
 (0)