Bars: write class/custom health colour to the texture vertex directly

ApplyHealthColors used two different channels per mode: PERCENT paints
the status bar texture's vertex colour directly (gradient curve), while
CLASS/CUSTOM went through StatusBar:SetStatusBarColor. The StatusBar
caches its colour, so after a PERCENT render stained the texture,
switching to CLASS could call SetStatusBarColor with values equal to
the cached colour and no-op - leaving the last gradient colour (green
at full health) visible on every frame until reload. Reports: "class
coloured healthbars stuck green", profile data verified healthy
(healthColorMode=CLASS, correct classColors) via decoded export.

Write the same rgb through tex:SetVertexColor as well, matching the
channel UpdateHealthBarAppearance (ElementAppearance) already uses for
every mode, so the two colour appliers can no longer disagree and the
visible state is guaranteed regardless of the StatusBar's cache.
Dead-fade is unaffected: it rides alpha (fadeDeadHealthBar), and the
alpha guard is preserved.

Author: Krathe82

CHANGELOG.md

@@ -1,5 +1,11 @@
 # DandersFrames Changelog
 
+## [4.7.3]
+
+### Bug Fixes
+
+* (Bars) Fixed class-coloured health bars staying stuck on the gradient colour (usually green) after using or switching away from the Percent colour mode — the class/custom colour is now written directly to the bar texture, so it can no longer be masked by a leftover gradient tint. (by Krathe)
+
 ## [4.7.2]
 
 ### Bug Fixes

Frames/Colors.lua

@@ -287,15 +287,31 @@ function DF:ApplyHealthColors(frame)
             end
         end
         frame.healthBar:SetStatusBarColor(r, g, b)
-        -- Apply alpha separately so range/dead fade can control it
-        if not deadFadeActive then
-            local tex = frame.healthBar:GetStatusBarTexture()
-            if tex then tex:SetAlpha(classColorAlpha) end
+        local tex = frame.healthBar:GetStatusBarTexture()
+        if tex then
+            -- ALSO write the colour to the texture's vertex directly (the same
+            -- channel PERCENT mode and ElementAppearance use). Without this,
+            -- switching from Percent to Class can leave the last gradient
+            -- colour visible: PERCENT painted the texture directly, so the
+            -- StatusBar's own cached colour may already equal the class colour
+            -- and SetStatusBarColor above no-ops, leaving the gradient stain
+            -- (typically green at full health) until /reload. Writing the same
+            -- rgb through the vertex guarantees the visible state either way,
+            -- and matches UpdateHealthBarAppearance's channel so the two
+            -- appliers can't fight.
+            tex:SetVertexColor(r, g, b)
+            -- Apply alpha separately so range/dead fade can control it
+            if not deadFadeActive then
+                tex:SetAlpha(classColorAlpha)
+            end
         end
     else
         -- Custom color mode - use RGBA
         local c = db.healthColor
         frame.healthBar:SetStatusBarColor(c.r, c.g, c.b, c.a or 1)
+        -- Same direct vertex write as the CLASS branch above (gradient-stain fix).
+        local tex = frame.healthBar:GetStatusBarTexture()
+        if tex then tex:SetVertexColor(c.r, c.g, c.b) end
     end
 
     -- Skip background color if dead fade with custom color is active