Click casting: add Always Cast fallback option (bug #991)

Bindings whose macro was all conditional clauses did nothing when no
clause matched — a global bind with the mouseover fallback could never
show a ground-targeted spell's aiming circle while hovering nothing.
New per-binding Advanced option appends a terminal unconditional clause
(combat/mounted gating preserved) to both the frame and global macros,
and enabling it also activates the key globally. Self-cast keeps
precedence when both are enabled.

Author: mergetest

CHANGELOG.md

@@ -8,6 +8,10 @@
 * (Click Casting) Fixed keyboard and mouse-wheel click-cast binds being silently dropped mid-hover during combat — the safety check that removes hover binds could misread the cursor as off the frame while the frame's position was briefly unreadable, wiping the binds until the frame was re-hovered. Binds are now only removed when the cursor is provably off the frame. (by Krathe)
 * (Click Casting) Fixed binds on keys from international keyboard layouts (such as æ, ø or å) not casting on the frame under the cursor.
 
+### New Features
+
+* (Click Casting) New "Always Cast" option in a binding's Advanced settings. When enabled, the key still casts with the spell's normal targeting if no other rule matches — so ground-targeted spells (like aimable Shaman totems) show their aiming circle when pressed while hovering nothing.
+
 ## [4.7.3]
 
 ### Bug Fixes

ClickCasting/Bindings.lua

@@ -847,7 +847,9 @@ function CC:BuildHovercastSetupScript()
             -- These fallbacks only work when NOT hovering a frame, so we need
             -- the key binding to be active globally, not just when hovering
             local fallback = binding.fallback or {}
-            local hasFallbackThatNeedsGlobal = fallback.mouseover or fallback.target or fallback.selfCast
+            -- alwaysCast needs the key active everywhere too — its whole point
+            -- is casting while hovering nothing (bug #991)
+            local hasFallbackThatNeedsGlobal = fallback.mouseover or fallback.target or fallback.selfCast or fallback.alwaysCast
 
             -- Check for useGlobalBind flag (for items/macros that need to work everywhere)
             local hasGlobalBindFlag = binding.useGlobalBind == true
@@ -2031,7 +2033,18 @@ function CC:BuildMacroTextForBinding(binding, forGlobalBinding)
         if hasSelf then
             table.insert(parts, "[@player" .. combatStr .. mountedStr .. "] " .. spellName)
         end
-        
+
+        -- Always Cast: terminal unconditional clause — when no clause above
+        -- matches (nothing hovered / ineligible unit), cast with WoW's default
+        -- targeting so ground-targeted spells show their aiming circle
+        -- (bug #991). With Self enabled the [@player] clause above always
+        -- resolves first, so Self takes precedence. Combat/mounted gating
+        -- still applies.
+        if fallback.alwaysCast then
+            local conds = (combatStr .. mountedStr):sub(2)   -- strip leading comma; "" when ungated
+            table.insert(parts, (conds ~= "" and ("[" .. conds .. "] ") or "") .. spellName)
+        end
+
         -- If no fallbacks enabled, just cast normally (will use WoW's default targeting)
         if #parts == 0 then
             table.insert(parts, spellName)
@@ -2349,7 +2362,20 @@ function CC:BuildCombinedMacroForBindings(bindings, forGlobalBinding)
             table.insert(parts, "[@player" .. combatStr .. "] " .. friendlySpell)
         end
     end
-    
+
+    -- Always Cast (bug #991): terminal unconditional clause, mirroring the
+    -- single-binding builder. First contributing binding with the flag wins;
+    -- the self-cast clause above resolves first when enabled.
+    for _, b in ipairs({friendlyBinding, hostileBinding, anyBinding}) do
+        if b and b.fallback and b.fallback.alwaysCast and b.spellName then
+            local spell = GetLocalizedSpellName(b.spellId) or b.spellName
+            local combatCond = GetCombatCondition(b)
+            local combatStr = combatCond == "combat" and ",combat" or (combatCond == "nocombat" and ",nocombat" or "")
+            table.insert(parts, (combatStr ~= "" and ("[" .. combatStr:sub(2) .. "] ") or "") .. spell)
+            break
+        end
+    end
+
     if #parts == 0 then return nil end
 
     -- Check if any contributing binding has stopSpellTarget enabled

ClickCasting/Constants.lua

@@ -303,6 +303,7 @@ local DEFAULT_BINDING = {
         target = false,
         selfCast = false,
         stopSpellTarget = false,
+        alwaysCast = false,
     },
     -- Load conditions
     loadSpec = nil, -- nil = all specs, or table of spec IDs
@@ -453,6 +454,10 @@ local FALLBACK_INFO = {
         name = "Self",
         desc = "Cast on yourself as a last resort if no other valid target is found.",
     },
+    alwaysCast = {
+        name = "Always Cast",
+        desc = "If no rule above matches (hovering nothing, or an ineligible unit), cast anyway using the spell's normal targeting. Lets ground-targeted spells show their aiming circle when pressed in the open. If Self is also enabled, Self applies first.",
+    },
     stopSpellTarget = {
         name = "Cancel Targeting",
         desc = "Adds /stopspelltarget to the macro which cancels the blue targeting hand after casting. Disable this for spells like Rescue that require a targeting phase to complete.",

ClickCasting/UI/BindingEditor.lua

@@ -656,7 +656,7 @@ function CC:CreateEditBindingPanel()
     -- ============================================================
 
     local COLLAPSED_HEIGHT = 502
-    local EXPANDED_HEIGHT = 685
+    local EXPANDED_HEIGHT = 707
 
     -- Advanced header/toggle button
     local advancedToggle = CreateFrame("Button", nil, panel, "BackdropTemplate")
@@ -689,7 +689,7 @@ function CC:CreateEditBindingPanel()
     -- Advanced content container (hidden by default)
     local advancedContent = CreateFrame("Frame", nil, panel)
     advancedContent:SetPoint("TOPLEFT", advancedToggle, "BOTTOMLEFT", 0, -8)
-    advancedContent:SetSize(296, 140)
+    advancedContent:SetSize(296, 162)
     advancedContent:Hide()
     panel.advancedContent = advancedContent
 
@@ -737,16 +737,25 @@ function CC:CreateEditBindingPanel()
     end)
     panel.selfCB = selfCB
 
+    -- Always Cast checkbox (terminal unconditional fallback — bug #991)
+    local alwaysCastCB = CreateCheckbox(advancedContent, FALLBACK_INFO.alwaysCast.name, FALLBACK_INFO.alwaysCast.desc)
+    alwaysCastCB:SetPoint("TOPLEFT", 18, -104)
+    alwaysCastCB:SetScript("OnClick", function(self)
+        panel.pendingBinding.fallback = panel.pendingBinding.fallback or {}
+        panel.pendingBinding.fallback.alwaysCast = self:GetChecked()
+    end)
+    panel.alwaysCastCB = alwaysCastCB
+
     -- Macro Options section header
     local macroOptionsLabel = advancedContent:CreateFontString(nil, "OVERLAY", "DFFontNormal")
-    macroOptionsLabel:SetPoint("TOPLEFT", 0, -108)
+    macroOptionsLabel:SetPoint("TOPLEFT", 0, -130)
     macroOptionsLabel:SetText(L["Macro Options:"])
     macroOptionsLabel:SetTextColor(C_TEXT_DIM.r, C_TEXT_DIM.g, C_TEXT_DIM.b)
     panel.macroOptionsLabel = macroOptionsLabel
 
     -- Cancel Targeting checkbox (stopSpellTarget)
     local stopSpellTargetCB = CreateCheckbox(advancedContent, FALLBACK_INFO.stopSpellTarget.name, FALLBACK_INFO.stopSpellTarget.desc)
-    stopSpellTargetCB:SetPoint("TOPLEFT", 18, -128)
+    stopSpellTargetCB:SetPoint("TOPLEFT", 18, -150)
     stopSpellTargetCB:SetScript("OnClick", function(self)
         panel.pendingBinding.fallback = panel.pendingBinding.fallback or {}
         panel.pendingBinding.fallback.stopSpellTarget = self:GetChecked()
@@ -755,15 +764,15 @@ function CC:CreateEditBindingPanel()
 
     -- Target on cast checkbox (per-binding override of the global setting)
     local targetOnCastCB = CreateCheckbox(advancedContent, L["Target on cast"], L["Also make this unit your target when you click-cast on it. Overrides the global 'Target unit when click-casting' setting."])
-    targetOnCastCB:SetPoint("TOPLEFT", 18, -150)
+    targetOnCastCB:SetPoint("TOPLEFT", 18, -172)
     targetOnCastCB:SetScript("OnClick", function(self)
         panel.pendingBinding.targetOnCast = self:GetChecked()
     end)
     panel.targetOnCastCB = targetOnCastCB
 
     -- Priority slider (inside advanced content)
     local priorityLabel = advancedContent:CreateFontString(nil, "OVERLAY", "DFFontNormal")
-    priorityLabel:SetPoint("TOPLEFT", 0, -158)
+    priorityLabel:SetPoint("TOPLEFT", 0, -180)
     priorityLabel:SetText(L["Priority:"])
     priorityLabel:SetTextColor(C_TEXT_DIM.r, C_TEXT_DIM.g, C_TEXT_DIM.b)
     panel.priorityLabel = priorityLabel
@@ -796,7 +805,7 @@ function CC:CreateEditBindingPanel()
         end,
         CC.ACCENT                   -- accentColor (ClickCasting green)
     )
-    prioritySlider:SetPoint("TOPLEFT", 68, -155)
+    prioritySlider:SetPoint("TOPLEFT", 68, -177)
 
     -- Direction note (standard GUI label style). The slider's container is 50px
     -- tall (its bottom sits near the Delete/Cancel/Save row), so the note is placed
@@ -1182,7 +1191,7 @@ function CC:ShowEditBindingPanel(spellData, existingBinding, existingIndex)
     -- Check if this binding has advanced options set (should auto-expand)
     local fallback = panel.pendingBinding.fallback or { mouseover = false, target = false, selfCast = false }
     local hasAdvancedOptions = fallback.mouseover or fallback.target or fallback.selfCast or fallback.stopSpellTarget
-        or panel.pendingBinding.targetOnCast ~= nil
+        or fallback.alwaysCast or panel.pendingBinding.targetOnCast ~= nil
     local currentPriority = panel.pendingBinding.priority or 5
     if currentPriority ~= 5 then
         hasAdvancedOptions = true
@@ -1203,6 +1212,7 @@ function CC:ShowEditBindingPanel(spellData, existingBinding, existingIndex)
         if panel.mouseoverCB then panel.mouseoverCB:Hide() end
         if panel.targetFallbackCB then panel.targetFallbackCB:Hide() end
         if panel.selfCB then panel.selfCB:Hide() end
+        if panel.alwaysCastCB then panel.alwaysCastCB:Hide() end
         if panel.macroOptionsLabel then panel.macroOptionsLabel:Hide() end
         if panel.stopSpellTargetCB then panel.stopSpellTargetCB:Hide() end
         if panel.targetOnCastCB then panel.targetOnCastCB:Hide() end
@@ -1259,6 +1269,7 @@ function CC:ShowEditBindingPanel(spellData, existingBinding, existingIndex)
         if panel.mouseoverCB then panel.mouseoverCB:Show() end
         if panel.targetFallbackCB then panel.targetFallbackCB:Show() end
         if panel.selfCB then panel.selfCB:Show() end
+        if panel.alwaysCastCB then panel.alwaysCastCB:Show() end
         if panel.macroOptionsLabel then panel.macroOptionsLabel:Show() end
         if panel.stopSpellTargetCB then panel.stopSpellTargetCB:Show() end
         if panel.targetOnCastCB then panel.targetOnCastCB:Show() end
@@ -1275,14 +1286,14 @@ function CC:ShowEditBindingPanel(spellData, existingBinding, existingIndex)
         end
 
         -- Reset priority slider position for spells (shifted down for the
-        -- Target on cast row added to Macro Options)
+        -- Target on cast + Always Cast rows added to the advanced section)
         if panel.priorityLabel then
             panel.priorityLabel:ClearAllPoints()
-            panel.priorityLabel:SetPoint("TOPLEFT", panel.advancedContent, "TOPLEFT", 0, -182)
+            panel.priorityLabel:SetPoint("TOPLEFT", panel.advancedContent, "TOPLEFT", 0, -204)
         end
         if panel.prioritySlider then
             panel.prioritySlider:ClearAllPoints()
-            panel.prioritySlider:SetPoint("TOPLEFT", panel.advancedContent, "TOPLEFT", 68, -179)
+            panel.prioritySlider:SetPoint("TOPLEFT", panel.advancedContent, "TOPLEFT", 68, -201)
         end
 
         -- Auto-expand if binding has advanced options
@@ -1360,7 +1371,7 @@ function CC:ShowEditBindingPanel(spellData, existingBinding, existingIndex)
 
     -- Adjust panel height based on macro/item vs spell, and Advanced expanded state
     local SPELL_COLLAPSED_HEIGHT = 502
-    local SPELL_EXPANDED_HEIGHT = 685
+    local SPELL_EXPANDED_HEIGHT = 707
     local MACRO_COLLAPSED_HEIGHT = 475  -- With Global Keybind section above Active
     local MACRO_EXPANDED_HEIGHT = 540   -- With Advanced expanded (just priority slider)
     local SPECIAL_COLLAPSED_HEIGHT = 450 -- Target/menu: target type + combat, no Advanced section
@@ -1391,6 +1402,7 @@ function CC:ShowEditBindingPanel(spellData, existingBinding, existingIndex)
         panel.mouseoverCB:SetChecked(fallback.mouseover == true)
         panel.targetFallbackCB:SetChecked(fallback.target == true)
         panel.selfCB:SetChecked(fallback.selfCast == true)
+        panel.alwaysCastCB:SetChecked(fallback.alwaysCast == true)
         panel.stopSpellTargetCB:SetChecked(fallback.stopSpellTarget == true)
         -- Show the effective state (global default unless this binding overrides it).
         -- Clicking writes an explicit override; leaving it untouched keeps inheriting.