Stop a dispel slot-style failure spamming errors and gutting FullFrameRefresh

ApplyOverlayLayout throws "calling 'ClearAllPoints' on bad self (forbidden
object)" on the 12.1 slot path, because the overlay's border StatusBars are
unbound descendants of Blizzard's secret aura button. The root cause needs a
live probe to pin down; this change contains the damage it does meanwhile.

Two things made one failure permanent and loud:

* CacheLayoutState is the LAST statement of ApplyOverlayLayout, so a throw
  skips it, LayoutStateChanged keeps returning true, and the fast path never
  engages. The throw also unwinds past the version/generation latches in
  DriveDispelOverlayFactory, so every drive re-entered the same failing pass
  -- 68 identical errors from a single key.
* UpdateDispelOverlay runs from FullFrameRefresh ahead of highlights, status
  icons, resource bar layout, absorbs and heal prediction. Throwing there
  abandoned all five on that frame, silently.

Per-button styling is now pcall'd (split out as StyleOneSlot), `styled` means
"we ran the pass" rather than "it worked" so the latch still lands, and the
first failure logs one DebugWarn instead of a flood. FullFrameRefresh guards
the dispel call so one broken element can't take the other five down.

The overlay artwork itself is still broken -- unchanged by this.

Author: mergetest

CHANGELOG.md

@@ -199,6 +199,8 @@ DandersFrames has been rebuilt for WoW 12.1 (Midnight), which fundamentally chan
 * (Click Casting) Fixed hover keybinds dying for the rest of the session on some frames after visiting player housing. (by Krathe)
 * (Click Casting) Fixed cast-on-down silently switching itself off on Blizzard's own raid and party frames after every roster change. (by Krathe)
 * (Pet Frames) Fixed pet frames never appearing in arena (2v2, 3v3 and Solo Shuffle). Arena counts as a raid to the game, so pet frames were being looked for on the raid frames — which arena does not use. They now build alongside the arena frames, and follow your Party pet settings. (by Krathe)
+* (Dispel) Fixed repeating error popups when a dispellable debuff appeared on a frame. The same error was also stopping highlights, status icons, the resource bar, absorbs and heal prediction from updating on that frame. The overlay's own artwork is still being worked on.
+* (Integrations) "Use DF Color Picker" and "Use DF Color Picker for All Addons" are now single settings shared by Party and Raid, applying to your whole account. Ticking them on the Raid tab previously did nothing at all. Your existing choice carries over. They no longer travel with profile imports and exports.
 
 ### Improvements
 

DandersFrames/Features/Dispel.lua

@@ -1134,6 +1134,7 @@ local GAME_ICON_ATLAS = {
     Bleed   = "RaidFrame-Icon-DebuffBleed",
 }
 local warnedTintBind = false
+local warnedSlotStyle = false
 
 -- Slot plan from settings. Returns nil when the native classification route is
 -- required but missing (API drift) and no degrade applies.
@@ -1631,6 +1632,40 @@ local function StyleGameEdgeSlot(btn, frame, db, edge)
     ApplySlotPulse(btn.dfDispelEdgeHolder and btn.dfDispelEdgeHolder[edge], db.dispelAnimate)
 end
 
+-- All the styling for ONE slot button. Split out of StyleDispelSlots so the whole
+-- per-button pass can be pcall'd as a unit -- see the caller for why.
+local function StyleOneSlot(btn, frame, db, info)
+    -- IN-PLACE PALETTE RE-BIND (68914): Blizzard securecopy's the colour map at
+    -- bind time, so a Colours-page edit needs the carrier RE-BOUND. That used to
+    -- force a full container rebuild (the palette generation rode the plan
+    -- signature) — a visible teardown/rebuild flicker on every colour tweak.
+    -- AddDispelTypeTexture accepts a re-bind from this tainted pass now (the
+    -- access-constrained rule is gone; /al accessbind + the 68914 validator,
+    -- which only rejects EXPLICITLY forbidden / protected / non-descendant
+    -- objects — our carrier is a descendant that merely INHERITS aspects), so
+    -- re-bind the carrier we already have and skip the rebuild entirely.
+    -- Icon slots bind nothing, so they never go stale. Re-binds the WHOLE
+    -- carrier list for this button in one clear-then-append pass.
+    if btn._dfDispelCarriers and btn._dfDispelCurveGen ~= DF.dispelCurveGen then
+        BindDispelCarriers(btn, btn._dfDispelCarriers, db, info.key)
+    end
+    if info.iconType then
+        StyleGameTypeIconSlot(btn, frame, db, info.iconType)
+    else
+        -- ONE button, every role it owns (see dispelSlotPlan's `roles`).
+        -- StyleGameMainSlot runs UNCONDITIONALLY: besides dressing the gradient
+        -- carrier it owns the shared geometry pass (ApplyOverlayLayout), hides
+        -- the legacy regions, and applies the darken/pulse — all of which the
+        -- pre-consolidation main slot did in every style, EDGE included.
+        StyleGameMainSlot(btn, frame, db)
+        local r = info.roles
+        if r and r.edges then
+            for _, edge in ipairs(r.edges) do StyleGameEdgeSlot(btn, frame, db, edge) end
+        end
+        if r and r.border then StyleGameBorderSlot(btn, frame, db) end
+    end
+end
+
 -- Style every live slot button per the plan. Returns false while no buttons exist
 -- (combat-deferred build / fake backend) so the caller doesn't latch the version.
 local function StyleDispelSlots(frame, db, h, slots)
@@ -1641,44 +1676,44 @@ local function StyleDispelSlots(frame, db, h, slots)
         local info = slots[i]
         local btn = buttons[info.key]
         if btn then
+            -- `styled` means "a button existed and we ran the pass", NOT "the pass
+            -- succeeded". It has to stay true even when the pass throws, or the
+            -- caller never latches the version/generation and re-enters this same
+            -- failing pass on EVERY drive -- i.e. per UNIT_AURA, per frame, forever
+            -- (bug #1011: 68 identical errors from one key). A real change bumps
+            -- ver/gen and retries; a deterministic failure now costs one error, not
+            -- a permanent loop.
             styled = true
-            -- IN-PLACE PALETTE RE-BIND (68914): Blizzard securecopy's the colour map at
-            -- bind time, so a Colours-page edit needs the carrier RE-BOUND. That used to
-            -- force a full container rebuild (the palette generation rode the plan
-            -- signature) — a visible teardown/rebuild flicker on every colour tweak.
-            -- AddDispelTypeTexture accepts a re-bind from this tainted pass now (the
-            -- access-constrained rule is gone; /al accessbind + the 68914 validator,
-            -- which only rejects EXPLICITLY forbidden / protected / non-descendant
-            -- objects — our carrier is a descendant that merely INHERITS aspects), so
-            -- re-bind the carrier we already have and skip the rebuild entirely.
-            -- Icon slots bind nothing, so they never go stale. Re-binds the WHOLE
-            -- carrier list for this button in one clear-then-append pass.
-            if btn._dfDispelCarriers and btn._dfDispelCurveGen ~= DF.dispelCurveGen then
-                BindDispelCarriers(btn, btn._dfDispelCarriers, db, info.key)
-            end
-            if info.iconType then
-                StyleGameTypeIconSlot(btn, frame, db, info.iconType)
-            else
-                -- ONE button, every role it owns (see dispelSlotPlan's `roles`).
-                -- StyleGameMainSlot runs UNCONDITIONALLY: besides dressing the gradient
-                -- carrier it owns the shared geometry pass (ApplyOverlayLayout), hides
-                -- the legacy regions, and applies the darken/pulse — all of which the
-                -- pre-consolidation main slot did in every style, EDGE included.
-                StyleGameMainSlot(btn, frame, db)
-                local r = info.roles
-                if r and r.edges then
-                    for _, edge in ipairs(r.edges) do StyleGameEdgeSlot(btn, frame, db, edge) end
+            -- pcall'd per BUTTON so one bad slot can't skip the others, and -- more
+            -- importantly -- can't propagate out through DriveDispelOverlayFactory
+            -- into FullFrameRefresh, which would abandon every element that runs
+            -- after the dispel overlay (highlights, status icons, resource bar,
+            -- absorbs, heal prediction). Allocation is fine here: this path is gated
+            -- on a version/generation change, so it runs on rebuilds, not per aura.
+            local ok, err = pcall(StyleOneSlot, btn, frame, db, info)
+            if not ok then
+                btn._dfDispelStyleErr = tostring(err)
+                if not warnedSlotStyle then
+                    warnedSlotStyle = true
+                    if DF.DebugWarn then
+                        DF:DebugWarn("DISPEL", "slot style %s failed: %s",
+                            tostring(info.key), tostring(err))
+                    end
                 end
-                if r and r.border then StyleGameBorderSlot(btn, frame, db) end
+            else
+                btn._dfDispelStyleErr = nil
             end
         end
     end
     -- Seed any health-tracking gradient bars now (both colour modes): the health
     -- hook only fires on health CHANGES, and the layout pass just neutralized the
     -- fill to full — without a seed a tracking bar renders full until the first
     -- health tick. Early-outs when nothing tracks.
+    -- pcall'd for the same reason as the per-button pass: this reaches into the
+    -- slot widgets' StatusBars, so it shares their exposure and must not be able
+    -- to abort the caller.
     if styled and DF.UpdateDispelGradientHealth then
-        DF:UpdateDispelGradientHealth(frame)
+        pcall(DF.UpdateDispelGradientHealth, DF, frame)
     end
     return styled
 end

DandersFrames/Frames/Headers.lua

@@ -3753,8 +3753,14 @@ function DF:FullFrameRefresh(frame)
     if DF.UpdateMissingBuffIcon then DF:UpdateMissingBuffIcon(frame) end
 
     -- Overlays
-    if DF.UpdateDispelOverlay then DF:UpdateDispelOverlay(frame) end
-    
+    -- pcall'd: the dispel overlay is the only element here that reaches into the
+    -- native aura container's slot buttons, so it is the one most exposed to a
+    -- forbidden-object / taint throw. Unguarded, such a throw aborts the REST of
+    -- this function -- highlights, status icons, resource bar, absorbs and heal
+    -- prediction all silently stop updating on that frame (bug #1011). One broken
+    -- element must not take the other five down with it.
+    if DF.UpdateDispelOverlay then pcall(DF.UpdateDispelOverlay, DF, frame) end
+
     -- Highlights (selection, aggro, etc.)
     if DF.UpdateHighlights then DF:UpdateHighlights(frame) end