Post-merge review fixups

- Core.lua: drop centerStatusIconFrameLevel from the absolute-frame-level
  migration table; the feature is deleted on this branch.
- Config.lua: the AD indicatorFrameLevel comment described a render that adds 40
  to the stored value. It uses it absolute (resolveDefs, `or 40`), which is why
  the seed was corrected to 40 in c273761.
- Frames/Init.lua: two comments named DF:GetAllRaidFrames, removed in #219.
- CHANGELOG: main's entries merged under the 5.0.0 heading landed after Known
  Issues; moved them above it so Known Issues stays last. Added the
  Copy/Sync/Reset entry and trimmed the internal-cleanup entry to house style.

Author: mergetest

CHANGELOG.md

@@ -175,16 +175,8 @@ DandersFrames has been rebuilt for WoW 12.1 (Midnight), which fundamentally chan
 * (Profiles) **Fixed a brand-new profile being run through the one-time upgrade steps meant for old ones**, which have nothing to upgrade and the wrong shape to upgrade from. Fixed one of those steps deleting Aura Designer configurations outright while re-scoping them per spec.
 * (Auras) Fixed a dispel pulse continuing on two of its three groups after it should have stopped, a failed aura-border attachment giving up instead of retrying, and a stale cache of frame attributes surviving a rebuild.
 * (Frames) **Fixed dead and offline units not updating their status text or their missing-buff badge.** A unit that died kept whatever its frame was showing a moment earlier — no "Dead" or "Offline" status, and a missing-buff badge still asking you to buff someone who could no longer receive it. Both corrected only when something else forced a full refresh, often when you died as well, which is what made it look like your own state mattered. Neither check was wrong; neither was being re-run. Most visible in follower dungeons, where companions go down often.
-* (Internal) **Code cleanup, round two** — 33 unreferenced functions, 39 orphaned locale strings, six permanently-disabled blocks and seven calls to methods that no longer exist. The dead list was re-derived rather than taken from the audit that found it: the audit ran before its own fixes landed, so following it as written would have deleted code those fixes had just brought back to life. No behaviour change.
-
-### Known Issues (12.1 alpha)
-
-* The 12.1 aura displays are rebuilt on Blizzard's new container system and are under active testing — please report any case where buff, debuff, defensive or missing-buff displays stop updating, **especially in combat**.
-* A debuff that counts as both a Priority debuff and a Boss/Role debuff can show one icon per matching filter when both are enabled — the only duplicate case the new filter system can't remove. "Show All Debuffs" avoids it.
-* Dispel Overlay: a unit with dispellable debuffs of two different types can show both type icons overlapped (rare).
-* Aura Designer text colouring is drawn as a cover over the text: it ignores the out-of-range text fade, and group parts with their own inline colours keep them.
-* Dragging certain aura sliders can briefly stutter.
-* Settings-window borders re-derive their thickness from DandersFrames' own **UI Scale** slider (top of the settings window). Changing WoW's global UI Scale instead won't re-derive them for pages already on screen — reopen the window, or nudge the addon's own slider, if a border looks off after doing that.
+* (Profiles) Fixed Copy, Sync and Reset Page quietly leaving some settings behind on seven pages, with nothing to say they'd been skipped. Fading was the reported case.
+* (Internal) Code cleanup: removed unreferenced functions, orphaned locale strings and permanently-disabled blocks. No behaviour change.
 
 ### Bug Fixes
 
@@ -202,6 +194,15 @@ DandersFrames has been rebuilt for WoW 12.1 (Midnight), which fundamentally chan
 * (Click Casting) **Removed:** the hidden per-binding "load only for these specs" field, which no settings screen could ever set and which could filter your binding list using unresolved spec data at login — per-spec click casting is unchanged via loadout-assigned profiles. (by Krathe)
 
 
+### Known Issues (12.1 alpha)
+
+* The 12.1 aura displays are rebuilt on Blizzard's new container system and are under active testing — please report any case where buff, debuff, defensive or missing-buff displays stop updating, **especially in combat**.
+* A debuff that counts as both a Priority debuff and a Boss/Role debuff can show one icon per matching filter when both are enabled — the only duplicate case the new filter system can't remove. "Show All Debuffs" avoids it.
+* Dispel Overlay: a unit with dispellable debuffs of two different types can show both type icons overlapped (rare).
+* Aura Designer text colouring is drawn as a cover over the text: it ignores the out-of-range text fade, and group parts with their own inline colours keep them.
+* Dragging certain aura sliders can briefly stutter.
+* Settings-window borders re-derive their thickness from DandersFrames' own **UI Scale** slider (top of the settings window). Changing WoW's global UI Scale instead won't re-derive them for pages already on screen — reopen the window, or nudge the addon's own slider, if a border looks off after doing that.
+
 ## [4.8.0]
 
 ### Bug Fixes

Config.lua

@@ -2404,13 +2404,15 @@ DF.PartyDefaults = {
             durationColor = {r = 1, g = 1, b = 1, a = 1},
             stackColor = {r = 1, g = 1, b = 1, a = 1},
             hideIcon = false,
-            -- Global AD indicator z-order defaults. BOTH are no-ops at their shipped value,
-            -- deliberately: the render adds frameLevelOffset 40 + this, so 0 keeps an
-            -- indicator that has never had a level set exactly where it renders today (+40,
-            -- below the defensive row at +51). Was 30 — which the editor displayed as the
-            -- default while the render ignored it entirely, so wiring it up would have moved
-            -- every untouched indicator to +70 and above the defensive row. Baseline changed
-            -- rather than migrated: saved profiles keep whatever they hold.
+            -- Global AD indicator z-order defaults. The stored number is an ABSOLUTE
+            -- offset from the unit frame — the render uses it as-is (resolveDefs in
+            -- AuraDesigner\Factory.lua, `or 40`), it does not add a base to it. 40 is
+            -- therefore a no-op at its shipped value: an indicator that has never had a
+            -- level set renders exactly where it does today, below the defensive row.
+            -- Was 30 — which the editor displayed as the default while the render ignored
+            -- it entirely. Baseline changed rather than migrated: saved profiles keep
+            -- whatever they hold. Keep this in step with the render fallback and with the
+            -- backfill seed in Core.lua; all three must agree.
             indicatorFrameLevel = 40,
             indicatorFrameStrata = "INHERIT",
         },

Core.lua

@@ -2798,7 +2798,7 @@ end
 -- guarded and idempotent.
 local ABS_LEVEL_SENTINEL_DEFAULT = {
     roleIconFrameLevel = 30, leaderIconFrameLevel = 30, raidTargetIconFrameLevel = 30,
-    readyCheckIconFrameLevel = 30, centerStatusIconFrameLevel = 30, resurrectionIconFrameLevel = 30,
+    readyCheckIconFrameLevel = 30, resurrectionIconFrameLevel = 30,
     phasedIconFrameLevel = 30, afkIconFrameLevel = 30, vehicleIconFrameLevel = 30,
     raidRoleIconFrameLevel = 30, summonIconFrameLevel = 30, bgCarrierIconFrameLevel = 30,
     combatIconFrameLevel = 30, missingBuffIconFrameLevel = 35, defensiveIconFrameLevel = 65,

Frames/Init.lua

@@ -118,7 +118,7 @@ function DF:InitializeRaidFrames()
     DF.raidContainer:Hide()  -- Hidden by default, shown when in raid
 
     -- Raid frames are children of SecureGroupHeaderTemplate headers
-    -- Access via DF:GetRaidFrame(index) or DF:GetAllRaidFrames()
+    -- Access via DF:GetRaidFrame(index) or DF:IterateRaidFrames(callback)
 
     -- Create raid mover frame
     DF:CreateRaidMoverFrame()
@@ -1162,7 +1162,7 @@ end
 -- after Clique's metatable is in place.
 --
 -- Iterates ALL header children directly (not via unit-based lookups like
--- IteratePartyFrames/GetAllRaidFrames) because at commit time some frames
+-- IteratePartyFrames/IterateRaidFrames) because at commit time some frames
 -- may not have units assigned yet (e.g., party frames when solo-queuing
 -- for a dungeon — the header pre-creates children but units aren't set
 -- until group members actually appear).