Bars: apply the missing-texture fallback on every update path

The green class-colour reports are missing textures: broken profiles
referenced bar textures belonging to other addons (third-party media
paths carried in by imported profiles). A statusbar texture that fails
to load renders solid green, so class colours appeared broken while
the colour settings were verifiably correct (confirmed by decoding a
reporter's export + SavedVariables: the broken profile/mode
combinations were exactly the ones whose healthTexture pointed at
third-party media, per-profile AND per-mode).

PR #123's SafeSetStatusBarTexture fallback only ran at frame CREATION;
ApplyFrameLayout re-applied db textures raw on every settings pass and
immediately clobbered the stock fallback. Route every user-configurable
bar texture through the safe setter: health/absorb/heal-absorb in
ApplyFrameLayout, the test-mode health + missing-health previews, and
the targeted-list bar. Internal constant textures (gradient LUTs, the
Blizzard shield overlay) are untouched.

Author: Krathe82

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 ### Bug Fixes
 
+* (Bars) **Fixed health bars rendering solid green when a profile references a bar texture you don't have** — imported profiles often point at another addon's texture files; if that addon isn't installed (or its files changed), the bar showed WoW's green missing-texture state and class colours appeared broken. All bar textures now fall back to the stock texture with a one-time warning, on every update path (the fallback previously only applied when a frame was first created and was immediately overwritten). (by Krathe)
 * (Bars) Fixed class-coloured health bars staying stuck on the gradient colour (usually green) after using or switching away from the Percent colour mode — the class/custom colour is now written directly to the bar texture, so it can no longer be masked by a leftover gradient tint. (by Krathe)
 
 ## [4.7.2]

Features/TargetedSpells.lua

@@ -4338,7 +4338,7 @@ local function TargetedList_ApplyBarAppearance(bar, db)
     -- which clobbers the progress fill set by ApplyBarContent.
     local texturePath = db.targetedListTexture or "Interface\\TargetingFrame\\UI-StatusBar"
     if bar._lastTexturePath ~= texturePath then
-        bar.progress:SetStatusBarTexture(texturePath)
+        DF:SafeSetStatusBarTexture(bar.progress, texturePath)
         bar._lastTexturePath = texturePath
     end
 

Frames/Update.lua

@@ -81,7 +81,11 @@ function DF:ApplyFrameLayout(frame)
     if healthBar then
         -- Texture
         local healthTex = db.healthTexture or "Interface\\TargetingFrame\\UI-StatusBar"
-        healthBar:SetStatusBarTexture(healthTex)
+        -- Safe setter: falls back to the stock texture when the configured path
+        -- is missing (imported profiles referencing another addon's media render
+        -- solid green otherwise). Frame CREATION already used the safe setter,
+        -- but this per-update raw call immediately clobbered its fallback.
+        DF:SafeSetStatusBarTexture(healthBar, healthTex)
 
         -- Orientation
         local orientation = db.healthOrientation or "HORIZONTAL"
@@ -141,7 +145,7 @@ function DF:ApplyFrameLayout(frame)
         local absorbTex = db.absorbBarTexture or "Interface\\Buttons\\WHITE8x8"
         local absorbColor = db.absorbBarColor or {r = 0, g = 0.835, b = 1, a = 0.7}
 
-        absorbBar:SetStatusBarTexture(absorbTex)
+        DF:SafeSetStatusBarTexture(absorbBar, absorbTex)
         absorbBar:SetStatusBarColor(absorbColor.r, absorbColor.g, absorbColor.b, absorbColor.a)
 
         if absorbMode == "FLOATING" then
@@ -179,7 +183,7 @@ function DF:ApplyFrameLayout(frame)
         local healAbsorbTex = db.healAbsorbBarTexture or "Interface\\Buttons\\WHITE8x8"
         local healAbsorbColor = db.healAbsorbBarColor or {r = 0.4, g = 0.1, b = 0.1, a = 0.7}
 
-        healAbsorbBar:SetStatusBarTexture(healAbsorbTex)
+        DF:SafeSetStatusBarTexture(healAbsorbBar, healAbsorbTex)
         healAbsorbBar:SetStatusBarColor(healAbsorbColor.r, healAbsorbColor.g, healAbsorbColor.b, healAbsorbColor.a)
 
         if healAbsorbMode == "FLOATING" then

TestMode/TestMode.lua

@@ -471,7 +471,7 @@ function DF:UpdateTestFrameHealthOnly(frame, index)
             if not texture or texture == "" then
                 texture = db.healthTexture or "Interface\\TargetingFrame\\UI-StatusBar"
             end
-            frame.missingHealthBar:SetStatusBarTexture(texture)
+            DF:SafeSetStatusBarTexture(frame.missingHealthBar, texture)
 
             frame.missingHealthBar:Show()
         else
@@ -667,7 +667,7 @@ function DF:UpdateTestFrame(frame, index, applyLayout)
             if not texture or texture == "" then
                 texture = db.healthTexture or "Interface\\TargetingFrame\\UI-StatusBar"
             end
-            frame.missingHealthBar:SetStatusBarTexture(texture)
+            DF:SafeSetStatusBarTexture(frame.missingHealthBar, texture)
 
             frame.missingHealthBar:Show()
         else
@@ -2606,7 +2606,7 @@ function DF:ApplyTestFrameLayout(frame)
     if frame.healthBar then
         -- Texture
         local healthTex = db.healthTexture or "Interface\\TargetingFrame\\UI-StatusBar"
-        frame.healthBar:SetStatusBarTexture(healthTex)
+        DF:SafeSetStatusBarTexture(frame.healthBar, healthTex)
 
         -- Orientation
         local orientation = db.healthOrientation or "HORIZONTAL"
@@ -2634,7 +2634,7 @@ function DF:ApplyTestFrameLayout(frame)
             if not missingTex or missingTex == "" then
                 missingTex = healthTex
             end
-            frame.missingHealthBar:SetStatusBarTexture(missingTex)
+            DF:SafeSetStatusBarTexture(frame.missingHealthBar, missingTex)
 
             if orientation == "HORIZONTAL" then
                 frame.missingHealthBar:SetOrientation("HORIZONTAL")