Fix resource bar border missing, heal absorb bar too small

Resource bar border (BUG #12):
- FullFrameRefresh and OnAttributeChanged called non-existent
  DF:PositionResourceBar(), renamed to DF:ApplyResourceBarLayout()

Heal absorb bar (BUG #5):
- Add calc:SetHealAbsorbMode(1) so GetHealAbsorbs() returns the full
  absorb amount instead of subtracting incoming heals (mode 0 default)

Performance:
- Replace pcall wrappers with nil checks in all three calculator
  usages (2x damage absorb, 1x heal absorb) — pcall is expensive
  and these run per-frame every update

Author: DanderBot

CHANGELOG.md

@@ -11,6 +11,9 @@
 * Fix pet frames vanishing after reload — pet frame updates were skipped in header mode, so they were never shown after login or `/rl`
 * Fix pet frame font crash on non-English clients
 * Reduce redundant pet frame updates during startup (throttled from 6 calls to 1-2)
+* Fix resource bar border not showing after login/reload — was calling non-existent function
+* Fix heal absorb bar showing smaller than actual absorb amount — calculator was subtracting incoming heals from absorb value
+* Replace pcall wrappers with nil checks in absorb/heal calculator hot paths for better performance
 
 ### New Features
 * Debug Console — persistent debug logging system with in-game viewer (`/df debug` to toggle, `/df console` to view). Logs persist across reloads with category filtering, severity levels, and clipboard export

Frames/Bars.lua

@@ -467,19 +467,21 @@ function DF:UpdateAbsorb(frame, testIndex)
 
             -- Set clamp mode from settings (default to 1 = Missing Health)
             local clampMode = db.absorbBarAttachedClampMode or 1
-            pcall(function() calc:SetDamageAbsorbClampMode(clampMode) end)
-            
+            if calc.SetDamageAbsorbClampMode then calc:SetDamageAbsorbClampMode(clampMode) end
+
             -- Populate the calculator
             UnitGetDetailedHealPrediction(unit, nil, calc)
-            
+
             -- Get clamped absorbs and clamped bool
-            local getSuccess, result1, result2 = pcall(function() return calc:GetDamageAbsorbs() end)
-            if getSuccess and result1 then
-                attachedAbsorbs = result1
-                isClamped = result2  -- This is a secret bool in M+
+            if calc.GetDamageAbsorbs then
+                local result1, result2 = calc:GetDamageAbsorbs()
+                if result1 then
+                    attachedAbsorbs = result1
+                    isClamped = result2  -- This is a secret bool in M+
+                end
             end
         end
-        
+
         -- Create/update overshield glow at max health position
         if db.absorbBarShowOvershield then
             -- Create glow texture if needed (directly on health bar)
@@ -700,19 +702,21 @@ function DF:UpdateAbsorb(frame, testIndex)
 
             -- Set clamp mode from settings (default to 1 = Missing Health)
             local clampMode = db.absorbBarAttachedClampMode or 1
-            pcall(function() calc:SetDamageAbsorbClampMode(clampMode) end)
-            
+            if calc.SetDamageAbsorbClampMode then calc:SetDamageAbsorbClampMode(clampMode) end
+
             -- Populate the calculator
             UnitGetDetailedHealPrediction(unit, nil, calc)
-            
+
             -- Get clamped absorbs and clamped bool
-            local getSuccess, result1, result2 = pcall(function() return calc:GetDamageAbsorbs() end)
-            if getSuccess and result1 then
-                attachedAbsorbs = result1
-                isClamped = result2  -- This is a secret bool in M+
+            if calc.GetDamageAbsorbs then
+                local result1, result2 = calc:GetDamageAbsorbs()
+                if result1 then
+                    attachedAbsorbs = result1
+                    isClamped = result2  -- This is a secret bool in M+
+                end
             end
         end
-        
+
         local healthOrient = db.healthOrientation or "HORIZONTAL"
         local inset = 0
         if db.showFrameBorder ~= false then
@@ -1091,15 +1095,21 @@ function DF:UpdateHealAbsorb(frame, testIndex)
             local calc = frame.healAbsorbCalculator
 
             -- Set clamp mode: 0 = CurrentHealth (don't go past 0 health)
-            pcall(function() calc:SetHealAbsorbClampMode(0) end)
+            if calc.SetHealAbsorbClampMode then calc:SetHealAbsorbClampMode(0) end
+            -- Set heal absorb mode: 1 = Total (return raw absorb values without
+            -- subtracting incoming heals). Default mode 0 reduces heal absorbs by
+            -- incoming heal amount, causing the bar to show less than actual absorb.
+            if calc.SetHealAbsorbMode then calc:SetHealAbsorbMode(1) end
 
             -- Populate the calculator
             UnitGetDetailedHealPrediction(unit, nil, calc)
 
             -- Get clamped heal absorbs
-            local getSuccess, result1 = pcall(function() return calc:GetHealAbsorbs() end)
-            if getSuccess and result1 then
-                attachedHealAbsorb = result1
+            if calc.GetHealAbsorbs then
+                local result = calc:GetHealAbsorbs()
+                if result then
+                    attachedHealAbsorb = result
+                end
             end
         end
 

Frames/Headers.lua

@@ -805,8 +805,8 @@ function DF:InitializeHeaderChild(frame)
                     DF:UpdateHighlights(self)
                 end
                 -- Resource bar
-                if DF.PositionResourceBar then
-                    DF:PositionResourceBar(self)
+                if DF.ApplyResourceBarLayout then
+                    DF:ApplyResourceBarLayout(self)
                 end
                 if DF.UpdateResourceBar then
                     DF:UpdateResourceBar(self)
@@ -4023,9 +4023,9 @@ function DF:FullFrameRefresh(frame)
     if DF.UpdateAllStatusIcons then DF:UpdateAllStatusIcons(frame) end
 
     -- Bars
-    -- NOTE: PositionResourceBar must be called first to show/hide the bar based on settings
+    -- NOTE: ApplyResourceBarLayout must be called first to show/hide the bar based on settings
     -- UpdateResourceBar only updates values for already-visible bars
-    if DF.PositionResourceBar then DF:PositionResourceBar(frame) end
+    if DF.ApplyResourceBarLayout then DF:ApplyResourceBarLayout(frame) end
     if DF.UpdateResourceBar then DF:UpdateResourceBar(frame) end
     if DF.UpdateAbsorb then DF:UpdateAbsorb(frame) end
     if DF.UpdateHealAbsorb then DF:UpdateHealAbsorb(frame) end