Skip to content

Commit a5d4791

Browse files
committed
Missing Buff: skip uncastable cross-faction targets
Don't flag a missing raid buff on a cross-faction group member when the buff can't actually be cast on them (e.g. in the open world). UnitCanAssist gates the icon so it only appears where the buff is castable — such as inside instances — mirroring the cross-faction handling in Range.lua.
1 parent 7c322ab commit a5d4791

2 files changed

Lines changed: 14 additions & 1 deletion

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
* (Test Mode) The separate **Status / Ready** and **Role / Leader** preview toggles are now a single **Icons** toggle, matching the live status-icon grouping. (by Krathe)
2929
* (Auto Layouts) The **override tooltip and `/df overrides` now read clearly** — each changed setting shows as a breadcrumb path with its value, only values that differ from global are listed, Text Designer elements show their names, and the override counts agree across the badge, status line and chat. (by Krathe)
3030
* (Aura Designer) Expiring health-bar highlights now **pulse in unison** across all frames — and tint and replace modes share one pulse engine — instead of each frame pulsing on its own timing. (by Krathe)
31+
* (Missing Buff) The missing-buff icon no longer flags a **cross-faction group member in the open world** as needing a buff you can't actually cast on them — it only appears where the buff is castable (e.g. inside instances). (by Krathe)
3132

3233
### Bug Fixes
3334

Frames/Icons.lua

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -809,7 +809,19 @@ function DF:UpdateMissingBuffIcon(frame, forceUpdate)
809809
missingBuffCache[frame] = nil
810810
return
811811
end
812-
812+
813+
-- Hide when we can't actually cast a beneficial spell on them — e.g. a
814+
-- cross-faction group member in the open world, where a "buff missing"
815+
-- icon is just noise because the buff is uncastable. UnitCanAssist flips
816+
-- to true inside instances where buffing them IS possible, so the icon
817+
-- only shows when it's actionable (mirrors Range.lua's cross-faction
818+
-- handling; the reaction funcs return clean, non-secret booleans).
819+
if not UnitCanAssist("player", unit) then
820+
frame.missingBuffFrame:Hide()
821+
missingBuffCache[frame] = nil
822+
return
823+
end
824+
813825
-- Check for missing buffs
814826
local missingSpellID = nil
815827
local missingIcon = nil

0 commit comments

Comments
 (0)