Fix secret-value taint spam in SafeSetFont + click-cast takeover of non-unit buttons

SafeSetFont's font-family re-render read GetText() and compared it with
~= "" — a value comparison on what is a SECRET string for native cooldown
countdown text (and health text) in instanced PvP. The pcall hid the error
but every blocked compare logged a taint incident, hundreds per minute
(bugs #987/#988). Truthiness is the sanctioned test and GetText() returns
nil for empty text, so the comparison was redundant.

ClickCastFrames handling gets an eligibility gate: only Button/Frame
entries carrying a unit attribute are registered, so non-unit secure
buttons (ToyPicker's toy button) no longer have their click attributes
rewritten. Also fixes the RegisterAllFrames sweep precedence bug
(enabled and A or B) that re-registered explicitly disabled entries.

Author: mergetest

CHANGELOG.md

@@ -7,6 +7,8 @@
 * (Click Casting) **Fixed keyboard and extra-mouse-button hover binds dying addon-wide mid-combat until a /reload** — hover binds are now owned by one permanent frame instead of the unit frame under the cursor, removing the cleanup step that could hit a dead frame reference and silently break every later hover. The 4.7.2 after-the-fact self-repair stays as a safety net, but the cause is gone. (by Krathe)
 * (Click Casting) Fixed keyboard and mouse-wheel click-cast binds being silently dropped mid-hover during combat — the safety check that removes hover binds could misread the cursor as off the frame while the frame's position was briefly unreadable, wiping the binds until the frame was re-hovered. Binds are now only removed when the cursor is provably off the frame. (by Krathe)
 * (Click Casting) Fixed binds on keys from international keyboard layouts (such as æ, ø or å) not casting on the frame under the cursor.
+* (Auras) Fixed a stream of blocked-action taint warnings in PvP instances (triggered while styling aura duration text) that could spill over and break Blizzard's chat or other addons until a /reload.
+* (Click Casting) Frames that other addons register for click-casting are now only taken over if they are real unit frames — non-unit buttons (such as toy or action buttons) are left alone, and frames an addon explicitly unregisters stay unregistered.
 
 ### New Features
 

ClickCasting/Frames.lua

@@ -732,6 +732,25 @@ end
 -- CLICKCASTFRAMES GLOBAL TABLE
 -- ============================================================
 
+-- A ClickCastFrames entry is only click-castable if it is an actual unit
+-- frame: a Button/Frame carrying a "unit" attribute. Registration rewrites the
+-- frame's click attributes to DF's macro/target actions, which BREAKS any
+-- non-unit secure button that lands in the global table — a toy/action button
+-- has no unit and can't receive unit-targeted casts anyway (bug #988,
+-- ToyPicker's button had its type1 replaced). Frames whose unit is assigned
+-- late (secure header children) are picked up by the next RegisterAllFrames
+-- sweep once the attribute exists.
+local function clickCastFrameEligible(frame)
+    if type(frame) ~= "table" or not frame.GetObjectType or not frame.GetAttribute then
+        return false
+    end
+    local objType = frame:GetObjectType()
+    if objType ~= "Button" and objType ~= "Frame" then return false end
+    local unit = frame:GetAttribute("unit")
+    if issecretvalue(unit) then return false end
+    return unit ~= nil
+end
+
 function CC:SetupClickCastFramesGlobal()
     -- If our click casting is disabled, DON'T set up our metatable
     -- This allows Clique/Clicked to set up their own metatable and work normally
@@ -765,7 +784,7 @@ function CC:SetupClickCastFramesGlobal()
             if CC.db and CC.db.enabled then
                 if enabled == nil or enabled == false then
                     CC:UnregisterFrame(frame)
-                else
+                elseif clickCastFrameEligible(frame) then
                     CC:RegisterFrame(frame)
                 end
             end
@@ -853,7 +872,7 @@ function CC:ScanForThirdPartyFrames()
     -- Also scan ClickCastFrames in case something was added via rawset
     if ClickCastFrames then
         for frame, enabled in pairs(ClickCastFrames) do
-            if enabled and type(frame) == "table" and not self.registeredFrames[frame] then
+            if enabled and not self.registeredFrames[frame] and clickCastFrameEligible(frame) then
                 self:RegisterFrame(frame)
                 registered = registered + 1
             end
@@ -2059,10 +2078,14 @@ function CC:RegisterAllFrames()
         end
     end
 
-    -- Also check ClickCastFrames global (for third-party addon support)
+    -- Also check ClickCastFrames global (for third-party addon support).
+    -- NOTE: the old condition here was `enabled and A or B` — precedence made
+    -- it (enabled and Button) or Frame, so entries an addon explicitly
+    -- DISABLED (ClickCastFrames[f] = false, the documented unregister method)
+    -- were re-registered on every sweep if their object type was "Frame".
     if ClickCastFrames then
         for frame, enabled in pairs(ClickCastFrames) do
-            if enabled and frame:GetObjectType() == "Button" or frame:GetObjectType() == "Frame" then
+            if enabled and clickCastFrameEligible(frame) then
                 self:RegisterFrame(frame)
             end
         end

Config.lua

@@ -766,11 +766,16 @@ function DF:SafeSetFont(fontString, fontNameOrPath, fontSize, outline)
             -- Force WoW to re-render the text with new font properties
             -- This is needed because switching between font families with different outline flags
             -- may not immediately update the rendered text without a text refresh
-            -- Note: Some fontStrings have "secret" text that cannot be read or compared,
-            -- so we wrap this in pcall to handle those cases safely
+            -- Note: the text may be a SECRET string (native cooldown countdown
+            -- text, health text, ...). Truthiness on a secret is allowed, but a
+            -- value comparison (~= "") is BLOCKED — and even inside pcall each
+            -- blocked compare logs a DandersFrames taint incident (hundreds per
+            -- minute in PvP instances; bugs #987/#988). GetText() returns nil,
+            -- never "", for empty text, so truthiness is also the complete
+            -- check. SetText accepts secret strings, so the round trip is safe.
             pcall(function()
                 local text = fontString:GetText()
-                if text and text ~= "" then
+                if text then
                     fontString:SetText("")
                     fontString:SetText(text)
                 end