Text Designer: remove dead Frame Level/Strata controls, fix class-color override-to-off, first-pass anchor fallback, disabled anchor targets, name length 0=off, and Max HP Reduction scaling

Author: DanderBot

CHANGELOG.md

@@ -43,6 +43,7 @@
 * (Nicknames) **Northern Sky Raid Tools compatibility** — when NSRT is also set to put nicknames on DandersFrames frames, a one-time prompt lets you choose which addon decides the names shown on your frames (changeable later under **General → Nicknames → Name precedence**), so the two no longer silently fight. (by Maelareth)
 * (Aura Designer) Alert sounds now play on the **Master** channel by default, so they stay audible even with Sound Effects or Music muted. A new **Channel** dropdown next to the Sound Alerts toggle lets you pick a different channel, and the per-alert volume slider now works on whichever channel is selected. (by Krathe)
 * Ready for **patch 12.0.7** — the addon-compartment tooltip and the frame mover's Ready Check action keep working when the new patch ships, with no change on the current version. (by Krathe)
+* (Text Designer) Removed the per-element **Frame Level** and **Frame Strata** controls — they had no real effect. Text layering above bars and below icons is handled automatically.
 
 ### Bug Fixes
 
@@ -72,6 +73,10 @@
 * (Text Designer) Text element edits now update **test-mode frames** live, not just real units. (by Krathe)
 * (Designers) The Aura/Text Designer **preview now rebuilds to the frame size of the auto layout being edited**, instead of staying stuck at a previous layout's dimensions. (by Krathe)
 * (Designers) Text Designer edits (and Aura Designer changes) no longer **stop updating on test-mode frames after switching between auto layouts** — applying a layout's overrides kept the designer's table/preview bindings valid instead of orphaning them. (by Krathe)
+* (Text Designer) **Use Class Color** can now be turned off on a single element when your global text default has it on.
+* (Text Designer) Text anchored to another element no longer **jumps position right after a reload**, and re-anchors to the frame while the element it's anchored to is disabled.
+* (Text Designer) The name **Max Length** slider can now be set to **0 to turn truncation off**, matching the old name text setting it replaced.
+* (Text Designer) Fixed the **Max HP Reduction** text showing the wrong percentage for small reductions.
 * (Frames) Missing textures now fall back to a bundled default instead of rendering black. If a profile you import references a custom or shared-media texture you don't have installed (or the addon that provided it was removed), the affected health bar, background or other bar now uses DandersFrames' default texture and shows a one-time notice — rather than a black/blank bar. (Requires WoW 12.0.7; on earlier versions there is no change.) (by Krathe)
 * (Aura Designer) The expiring **"Pulsate"** option now works for the replace-mode health-bar highlight (it previously stayed solid in replace mode). (by Krathe)
 * (Text Designer) Fix blank text on profiles that weren't active at login — switching to an older profile now converts its built-in text correctly.

Locales/enUS.lua

@@ -919,7 +919,6 @@ L["Incoming Heal"] = true
 L["Incoming Heal From Me Only"] = true
 L["Indicators"] = true
 L["Info (All)"] = true
-L["Inherit"] = true
 L["Insanity"] = true
 L["Inset"] = true
 L["Inside (Bottom)"] = true
@@ -960,7 +959,6 @@ L["Left of Party"] = true
 L["Left of Raid"] = true
 L["Left to Right"] = true
 L["Let Masque Control Aura Borders"] = true
-L["Length"] = true
 L["Line"] = true
 L["Loading..."] = true
 L["Lock"] = true

TextDesigner/Options.lua

@@ -330,7 +330,7 @@ local function BuildContentSection(GUI, parent, elem, tdDB, state, page, card, y
         local function lenCB()
             if DF.TextDesigner.Preview then DF.TextDesigner.Preview:RefreshAll() end
         end
-        local lenSlider = GUI:CreateSlider(parent, L["Length"], 1, 30, 1, elem, "nameLength", lenCB, lenCB)
+        local lenSlider = GUI:CreateSlider(parent, L["Max Length (0=off)"], 0, 30, 1, elem, "nameLength", lenCB, lenCB)
         lenSlider:SetPoint("TOPLEFT", parent, "TOPLEFT", 14, y)
         y = y - FIELD_ROW_HEIGHT
 
@@ -877,8 +877,6 @@ local function BuildPositionSection(GUI, parent, elem, tdDB, card, yStart)
     elem.anchor = elem.anchor or "CENTER"
     elem.offsetX = elem.offsetX or 0
     elem.offsetY = elem.offsetY or 0
-    elem.frameLevel = elem.frameLevel or 25
-    elem.frameStrata = elem.frameStrata or "INHERIT"
     elem.anchorTo = elem.anchorTo or "FRAME"
 
     -- Shared callback: every position-related widget needs to refresh the
@@ -912,26 +910,6 @@ local function BuildPositionSection(GUI, parent, elem, tdDB, card, yStart)
     ySlider:SetPoint("TOPLEFT", parent, "TOPLEFT", 14, y)
     y = y - FIELD_ROW_HEIGHT
 
-    local function lvlCB()
-        if DF.TextDesigner.Preview then DF.TextDesigner.Preview:RefreshAll() end
-    end
-    local lvlSlider = GUI:CreateSlider(parent, L["Frame Level"], 1, 200, 1, elem, "frameLevel", lvlCB, lvlCB)
-    lvlSlider:SetPoint("TOPLEFT", parent, "TOPLEFT", 14, y)
-    y = y - FIELD_ROW_HEIGHT
-
-    local strataOpts = {
-        INHERIT = L["Inherit"],
-        LOW = "LOW",
-        MEDIUM = "MEDIUM",
-        HIGH = "HIGH",
-        DIALOG = "DIALOG",
-    }
-    local strataDrop = GUI:CreateDropdown(parent, L["Frame Strata"], strataOpts, elem, "frameStrata", function()
-        if DF.TextDesigner.Preview then DF.TextDesigner.Preview:RefreshAll() end
-    end)
-    strataDrop:SetPoint("TOPLEFT", parent, "TOPLEFT", 14, y)
-    y = y - FIELD_ROW_HEIGHT
-
     -- Anchor To: target element (or the unit frame). Options are computed
     -- dynamically and exclude self + transitive descendants to prevent cycles.
     local anchorTargets = BuildAnchorTargets(tdDB, elem)

TextDesigner/Render.lua

@@ -14,6 +14,12 @@ DF.TextDesigner.Render = Render
 local function getResolver() return DF.TextDesigner.Resolver end
 local function getMS() return DF.TextDesigner.MidnightSafe end
 
+local wipe = wipe
+
+-- Enabled-element id set, rebuilt by UpdateFrame. Module-local and reused
+-- (wipe, not {}) because UpdateFrame runs in the unit-event hot path.
+local enabledScratch = {}
+
 -- ============================================================
 -- HINT CATEGORIES — which content types refresh on which hints
 -- ============================================================
@@ -60,12 +66,21 @@ local CONTENT_HINTS = {
 local function resolveAppearance(elem, globalDefaults)
     globalDefaults = globalDefaults or {}
     local overrides = elem.overrides or {}
+    -- useClassColor is the one boolean field, so the `(override and value) or
+    -- global` pattern the others use would swallow an override of FALSE (it
+    -- falls through to the global default). Branch on the override flag instead.
+    local useClassColor
+    if overrides.useClassColor then
+        useClassColor = elem.useClassColor or false
+    else
+        useClassColor = globalDefaults.useClassColor or false
+    end
     return {
         font          = (overrides.font          and elem.font)          or globalDefaults.font          or "DF Roboto SemiBold",
         fontSize      = (overrides.fontSize      and elem.fontSize)      or globalDefaults.fontSize      or 10,
         color         = (overrides.color         and elem.color)         or globalDefaults.color         or {r=1, g=1, b=1, a=1},
         outline       = (overrides.outline       and elem.outline)       or globalDefaults.outline       or "SHADOW;NONE",
-        useClassColor = (overrides.useClassColor and elem.useClassColor) or globalDefaults.useClassColor or false,
+        useClassColor = useClassColor,
     }
 end
 
@@ -91,11 +106,14 @@ end
 
 -- Returns the frame to anchor to. anchorTo == "FRAME" → parent frame.
 -- anchorTo == <element id string> → that element's FontString on the same frame.
-local function resolveAnchorTarget(elem, frame, fontStringsById)
+-- A disabled target counts as absent: its FontString is hidden with stale
+-- geometry, so dependents re-anchor to the frame instead of hanging off it.
+local function resolveAnchorTarget(elem, frame, fontStringsById, enabledById)
     local target = elem.anchorTo or "FRAME"
     if target == "FRAME" then return frame end
     local targetId = tonumber(target)
-    if targetId and fontStringsById and fontStringsById[targetId] then
+    if targetId and fontStringsById and fontStringsById[targetId]
+        and (not enabledById or enabledById[targetId]) then
         return fontStringsById[targetId]
     end
     return frame  -- fallback
@@ -152,19 +170,14 @@ local function applyAppearance(fs, frame, elem, globalDefaults)
         fs._useClassColor = false
         fs:SetTextColor(app.color.r, app.color.g, app.color.b, app.color.a or 1)
     end
-    -- Frame strata / level
-    if elem.frameStrata and elem.frameStrata ~= "INHERIT" then
-        fs:SetDrawLayer("OVERLAY", 7)  -- WoW FontStrings honor draw layer
-    end
 end
 
 -- Applies position to the FontString (separate from appearance so we can
 -- update position when anchorTo's target moves).
-local function applyPosition(fs, frame, elem, fontStringsById)
+local function applyPosition(fs, frame, elem, fontStringsById, enabledById)
     fs:ClearAllPoints()
-    local target = resolveAnchorTarget(elem, frame, fontStringsById)
-    fs:SetPoint(elem.anchor or "CENTER", target,
-        (elem.anchorTo and elem.anchorTo ~= "FRAME") and (elem.anchor or "CENTER") or (elem.anchor or "CENTER"),
+    local target = resolveAnchorTarget(elem, frame, fontStringsById, enabledById)
+    fs:SetPoint(elem.anchor or "CENTER", target, elem.anchor or "CENTER",
         elem.offsetX or 0, elem.offsetY or 0)
 end
 
@@ -174,7 +187,7 @@ end
 
 -- Renders a single elem on a frame. Called per-element from UpdateFrame.
 -- source is a DataSource (Live or Mock).
-local function updateOne(frame, elem, source, globalDefaults)
+local function updateOne(frame, elem, source, globalDefaults, enabledById)
     DF:Debug("TD", "updateOne: id=%s type=%s enabled=%s",
         tostring(elem.id), tostring(elem.contentType), tostring(elem.enabled))
     if not elem.enabled then
@@ -184,7 +197,7 @@ local function updateOne(frame, elem, source, globalDefaults)
     end
     local fs = acquireFontString(frame, elem)
     applyAppearance(fs, frame, elem, globalDefaults)
-    applyPosition(fs, frame, elem, frame._tdFontStrings)
+    applyPosition(fs, frame, elem, frame._tdFontStrings, enabledById)
     -- Apply class color if requested
     if fs._useClassColor then
         local token = source:GetClassToken()
@@ -228,10 +241,22 @@ function Render:UpdateFrame(frame, tdDB, source, hint, isPreview)
     end
     hint = hint or "all"
     local globalDefaults = tdDB.globalDefaults
+    -- Pre-create the FontString for every enabled element before any element is
+    -- positioned, so one anchored to a later-listed element finds its target on
+    -- the very first pass (it previously fell back to frame-anchoring for one
+    -- update, making anchored layouts jump just after a reload). The same sweep
+    -- records which ids are enabled for resolveAnchorTarget's disabled check.
+    wipe(enabledScratch)
+    for _, elem in ipairs(tdDB.elements or {}) do
+        if elem.enabled then
+            enabledScratch[elem.id] = true
+            acquireFontString(frame, elem)
+        end
+    end
     for _, elem in ipairs(tdDB.elements or {}) do
         local elemHint = CONTENT_HINTS[elem.contentType]
         if hint == "all" or elemHint == "all" or elemHint == hint then
-            updateOne(frame, elem, source, globalDefaults)
+            updateOne(frame, elem, source, globalDefaults, enabledScratch)
         end
     end
 

TextDesigner/Resolver.lua

@@ -206,13 +206,17 @@ end
 
 RESOLVERS.hp_max_reduction = function(elem, source)
     if deadHidden(elem, source) then return "" end
-    local pct = source:GetHPMaxReductionPct() or 0
+    local pct = source:GetHPMaxReductionPct()
+    if pct == nil then return "" end
+    -- Can be secret in combat (ReducedMaxHealth.lua guards the same API call);
+    -- comparison and arithmetic on a secret throw, so hide like the bar does.
+    if getMS().IsSecret(pct) then return "" end
     if pct == 0 then return "" end
-    -- API returns 0..1 in some patches and 0..100 in others.
-    -- Defensive: if value is <= 1, multiply by 100 for display.
-    local v = pct
-    if pct <= 1 then v = pct * 100 end
-    return string.format(elem.hidePercent and "-%.0f" or "-%.0f%%", v)
+    -- GetUnitTotalModifiedMaxHealthPercent returns a 0..1 fraction — the
+    -- Reduced Max Health bar feeds it straight into SetValue on a 0..1 bar.
+    -- Scale unconditionally; the old `pct <= 1` heuristic displayed small
+    -- reductions as wildly wrong percentages.
+    return string.format(elem.hidePercent and "-%.0f" or "-%.0f%%", pct * 100)
 end
 
 -- ───── Power ─────