Anim: enable animated borders on defensive + missing-buff icons

The DF-owned border animations (Pulsate/Wipe/Ripple/Segment Reveal/
Marching Dash/Sides/Corners) run off our own secretRect border textures
via the shared driver, so they work on the 12.1 container icons exactly
as they do on the Aura Designer's placed indicators. Un-frosts what the
port marked as a limitation, scoped to the two low-icon-count elements.

- Defensive row: sets adBorderAnim so the container's SAFE_OVERLAY_ANIM
  filter keeps the animation (and still strips the LCG glow types).
- Missing-buff badge: applies its border directly (no container filter),
  so it guards to the exposed SAFE_BORDER_ANIM set itself; its border is
  now torn down in _teardownContainer's StopAnimation pass, so continuous
  animation is safe (the old forced-off invariant is lifted).
- GUI: un-frosts the animation dropdown on both pages and hides the
  LCG-only types (Pixel/Autocast/Button/Proc) via animExcludeTypes.
  Buff/debuff rows stay off (many-icon perf). Config keys + exports
  already existed from the pre-12.1 feature.

Author: Krathe82

CHANGELOG.md

@@ -11,6 +11,7 @@ DandersFrames has been rebuilt for WoW 12.1 (Midnight), which fundamentally chan
 * (Tooltips) **The aura tooltip Enable toggles now apply immediately on the 12.1 aura rows** — turning Buff / Debuff / Defensive Icon tooltips on or off used to do nothing until the next unrelated settings change. The remaining tooltip options can't apply to aura icons on 12.1 and are marked in place: the game draws its aura tooltip at a fixed spot beside the icon with no addon hook (Anchor / Offset), and the icon's mouse state is protected during combat so hover can't be dropped per-combat (Disable in Combat). All of these keep working for Frame and Binding tooltips, which aren't aura-driven.
 * (Aura Designer) **The designer's own preview canvas renders through the real 12.1 engine** — the indicators you drag around on the editor's mock frame are styled by the exact same code that styles them live (size, borders, border animations, duration/stack text, bar fill), so what you see in the editor is what ships to the frames. Out-of-range fading also works on Aura Designer indicators again (the whole indicator dims with your configured alpha).
 * (Aura Designer) **Test mode previews the Aura Designer through the real 12.1 engine** — each placed indicator renders in its actual container wearing its own configured spell's icon, name and tooltip identity, with live-true position, borders, animations and fonts; frame effects (health-bar colour, background, frame border) apply exactly as they do live. The old hand-painted preview is gone, and preview sounds are no longer registered with the game while test mode is open.
+* (Auras) **Animated borders are back for Defensive and Missing-Buff icons.** The border animations (Pulsate, Wipe, Ripple, Segment Reveal, Marching Dash, Sides/Corners) were marked as a 12.1 limitation during the rework, but the Aura Designer's own approach — DF-drawn border textures animated by an external driver, rather than Blizzard's aura-button glow — works on the container icons too. The particle-glow styles (Pixel/Autocast/Button/Proc) still can't run on the new aura buttons and are hidden from these dropdowns. Under the hood the animation driver is now shared (one timer for all animated borders instead of one each), so it's lighter across the board.
 * (Auras) **Out-of-range and dead-unit fading works on the 12.1 aura displays again** — buff/debuff rows, defensive icons and the missing-buff strip now dim as one when the unit is out of range (with your configured out-of-range alphas), live and in test mode. This was a known gap since the rework.
 * (Aura Designer) The spell picker shows one unified grid — the separate "Inferred Tracking" section (and its cast-tracking caveats) is gone. On 12.1 every tracked aura works the same way, driven by the game's native spell-ID matching, so the whitelisted/inferred distinction no longer exists.
 * (Interface) The deprecated My Buff Indicators feature (hidden from the UI and force-disabled since 4.0.12) has been fully removed. Its successors — the missing-buff display and the Aura Designer — cover its use cases on the new aura engine.

Features/Auras.lua

@@ -862,6 +862,7 @@ function DF:BuildDefensiveRowConfig(db, unit)
     return {
         unit     = unit,
         mode     = "row",
+        adBorderAnim = true,   -- opt into DF-owned border animations (see buildPlacedConfig)
         filter   = factoryFilter or BuildDirectDefensiveFilters(),
         max      = db.defensiveBarMax or 4,
         enabled  = true,
@@ -1060,11 +1061,15 @@ local function styleMissingBadge(h, db, frame, info)
     local spec = DF.Border:BuildSpec(db, "missingBuffIcon", { unit = frame.unit, frame = frame, iconMode = true })
     spec.enabled = showBorder
     spec.size = borderSize
-    -- The badge border is secretRect, so an animation driver would be hosted on UIParent
-    -- (see ensureDriver in Border.lua) and this badge is NOT covered by a container
-    -- teardown loop. Keep animation OFF here — never let the badge animate, or its driver
-    -- would tick forever with no teardown.
-    spec.animation = nil
+    -- Animate only via the DF-owned (taint-safe) types — the LCG glows SetParent
+    -- their pooled frames onto the secretRect badge, which is forbidden on the native
+    -- button subtree. Continuous animation is safe now: the shared anim driver hosts on
+    -- UIParent and the badge's border is torn down in _teardownContainer's StopAnimation
+    -- pass (the GUI already hides the LCG types; this guards stale/imported profiles).
+    local safeAnim = DF.AuraContainer and DF.AuraContainer.SAFE_BORDER_ANIM
+    if spec.animation and not (safeAnim and safeAnim[spec.animation.type]) then
+        spec.animation = nil
+    end
     DF.Border:Apply(badge.dfBorder, spec)
 
     local artInset = showBorder and borderSize or 0

Frames/AuraContainer.lua

@@ -92,6 +92,9 @@ local SAFE_OVERLAY_ANIM = {
     CORNERS_ONLY   = true,
     SIDES_ONLY     = true,
 }
+-- Exposed so non-container consumers that apply a secretRect border directly
+-- (the missing-buff badge) can restrict to the same taint-safe DF-owned set.
+AuraContainer.SAFE_BORDER_ANIM = SAFE_OVERLAY_ANIM
 
 -- ============================================================
 -- CAPABILITY DETECTION  (the version gate + PTR-4 feature gates)
@@ -1866,6 +1869,7 @@ function Handle:_teardownContainer()
     -- MISSING mode: with no container the push geometry is gone — park the badge
     -- hidden on the window (never claim "missing" without a live container).
     if self.badge then
+        if DF.Border and self.badge.dfBorder then DF.Border:StopAnimation(self.badge.dfBorder) end
         self.badge:Hide()
         self.badge:ClearAllPoints()
         self.badge:SetPoint("TOPLEFT", self.frame, "TOPLEFT", 0, 0)

Options/Options.lua

@@ -6292,18 +6292,16 @@ function DF:SetupGUIPages(GUI, CreateCategory, CreateSubTab, BuildPage)
             include      = { alpha = true, inset = true, offset = true, blendMode = true,
                              gradient = true, shadow = true, animate = true,
                              classColor = true, roleColor = true },
+            -- Only the DF-owned (secretRect-driven) animations work on 12.1 buttons;
+            -- the LCG glows SetParent onto the native button (forbidden). Hide them.
+            animExcludeTypes = { PULSATE = true, CHASE = true, FLASH = true, PROC = true },
             fullUpdate   = function() refreshMissing() end,
             lightUpdate  = function() DF:LightweightUpdateMissingBuff() end,
             lightColors  = function() DF:LightweightUpdateMissingBuffBorderColor() end,
             refreshStates = function() self:RefreshStates() end,
             hideWhen     = function(d) return not d.missingBuffIconEnabled end,
             sizeMin = 0, sizeMax = 6, sizeStep = 1,  -- 0 = animation-only (no solid edge)
         })
-        -- 12.1: the badge's position derives from the container's secret geometry and
-        -- the factory strips spec.animation on render (same treatment as the aura
-        -- rows). Frost to match; candidate for the post-port cleanup sweep.
-        GUI:BlockControl12_1(mbBorderW.animationType, "limitation",
-            { id = "missingbuffs:borderanimation", page = L["Missing Buffs"], when = function(d) return DF:FactoryOwnsMissingBuff(d) end })
         borderGroup.disableChildrenOn = HideMissingBuffOptions
         Add(borderGroup, nil, 1)
 
@@ -6411,18 +6409,15 @@ function DF:SetupGUIPages(GUI, CreateCategory, CreateSubTab, BuildPage)
                              gradient = true, shadow = true, alpha = true,
                              classColor = true, roleColor = true,
                              animate = true },
+            -- DF-owned animations only (see the missing-buff note); LCG glows are
+            -- forbidden on native aura buttons.
+            animExcludeTypes = { PULSATE = true, CHASE = true, FLASH = true, PROC = true },
             fullUpdate   = function() if DF.UpdateAllDefensiveBars then DF:UpdateAllDefensiveBars() end end,
             lightUpdate  = function() DF:LightweightUpdateDefensiveIcons() end,
             lightColors  = function() DF:LightweightUpdateDefensiveIconColors() end,
             refreshStates = function() self:RefreshStates() end,
             hideWhen     = function(d) return not d.defensiveIconEnabled end,
         })
-        -- Animations can't run on the 12.1 container buttons (LCG's pooled glow
-        -- frames re-SetParent onto the host — forbidden on native AuraButtons), and
-        -- the factory strips spec.animation on render. Frost to match; candidate
-        -- for deletion in the post-port cleanup sweep.
-        GUI:BlockControl12_1(defBorderW.animationType, "limitation",
-            { id = "defensives:borderanimation", page = L["Defensives"], when = function(d) return DF:FactoryOwnsDefensiveRow(d) end })
         borderGroup.disableChildrenOn = HideDefensiveIconOptions
         Add(borderGroup, nil, 2)