Merge PR #218: click casting — consolidate the internals and close the hover-bind gap

Author: mergetest

CHANGELOG.md

@@ -2,6 +2,21 @@
 
 ## [Unreleased]
 
+### Bug Fixes
+
+* (Click Casting) **Fixed hover keybinds never working on frames that appear after you open the settings window** — opening the Click Casting options replaced the internal frame that owns hover bindings with a piece of the settings panel, so every frame created from then on (arena and boss frames, nameplates, frames for people joining your group) silently never got its keyboard bindings, and the automatic repair could not fix it either. A reload was the only way back. (by Krathe)
+* (Click Casting) Fixed keyboard binds going dead on every frame for a whole fight when combat interrupted a binding refresh — typically zoning into a raid and a pull starting seconds later. (by Krathe)
+* (Click Casting) Fixed hover keybinds dying for the rest of the session on some frames after visiting player housing. (by Krathe)
+* (Click Casting) Fixed cast-on-down silently switching itself off on Blizzard's own raid and party frames after every roster change. (by Krathe)
+
+### Improvements
+
+* (Click Casting) Work that has to wait for combat to end — profile switches, frame registration, binding refreshes and keyboard-bind rebuilds — now runs from a single queue that always drains, instead of ten separate flags; a keyboard-bind refresh asked for during combat was previously dropped entirely. (by Krathe)
+* (Click Casting) Binding-settle timers are now deduplicated so repeated events reuse one pending pass, a background rescan that re-armed itself forever now stops once its work is done, and two setup steps that gave up when combat outlasted their single retry now retry until combat ends. (by Krathe)
+* (Click Casting) Applying and clearing bindings now tracks exactly which click attributes were written on each frame instead of a ~500-write blanket sweep, which also fixes the previous profile's action lingering on an unmodified mouse button until reload. (by Krathe)
+* (Click Casting) **Removed:** the hidden per-binding "load only for these specs" field, which no settings screen could ever set and which could filter your binding list using unresolved spec data at login — per-spec click casting is unchanged via loadout-assigned profiles. (by Krathe)
+
+
 ## [4.8.0]
 
 ### Bug Fixes

ClickCasting/Bindings.lua

@@ -306,7 +306,8 @@ local DEFAULT_BINDING = {
         alwaysCast = false,
     },
     -- Load conditions
-    loadSpec = nil, -- nil = all specs, or table of spec IDs
+    -- (loadSpec, the per-binding spec gate, was retired: no UI ever wrote it
+    --  and per-spec click casting is done via loadout-assigned profiles)
     loadCombat = nil, -- nil = always, "combat" = in combat only, "nocombat" = out of combat only
 }
 CC.DEFAULT_BINDING = DEFAULT_BINDING
@@ -523,4 +524,25 @@ local BLIZZARD_ARENA_FRAMES = {
 }
 CC.BLIZZARD_ARENA_FRAMES = BLIZZARD_ARENA_FRAMES
 
+-- Modifier prefixes whose type1/type2 attributes get blanked to "" to suppress
+-- Blizzard's own click-casting on a frame we have taken over
+-- (ClearBlizzardClickCastFromFrame), and back to nil when the frame is handed
+-- back (RestoreBlizzardDefaults). Shared so the two sides cannot drift: they
+-- must name EXACTLY the same attributes, or the suppression outlives the
+-- takeover and modified clicks on that frame stay dead until a reload.
+--
+-- Note the ordering. For the multi-modifier entries this is NOT WoW's canonical
+-- attribute order (canonical is alt-ctrl-shift-meta -- see MODIFIER_COMBOS in
+-- Bindings.lua), so SecureActionButtonTemplate almost certainly never looks
+-- those names up and they are inert. They are still written today, so the
+-- restore side has to name them to be sure it undoes everything. Deliberately
+-- not "corrected" here: making them canonical would START suppressing
+-- multi-modifier Blizzard click-casting that is not suppressed today, which is
+-- a behaviour change and not this change's business.
+local BLIZZARD_SUPPRESSED_MODIFIERS = {
+    "shift-", "ctrl-", "alt-",
+    "shift-ctrl-", "shift-alt-", "ctrl-alt-", "shift-ctrl-alt-",
+}
+CC.BLIZZARD_SUPPRESSED_MODIFIERS = BLIZZARD_SUPPRESSED_MODIFIERS
+
 -- ============================================================