Address PR #206 review nits

- TOC: remove the 4 orphaned comment lines left under AuraDesigner/Config
  after the LinkedAuras entry was deleted.
- Factory.lua: fix two stale comments that still described the removed
  legacy read-path engine / P5-pending test mode.
- TestMode: the per-frame AD test block called the deleted
  Engine:UpdateTestFrame (silent no-op). Route it through Factory
  Sync/ClearFrame — the same path as the bulk UpdateAllTestAuraDesigner,
  so per-frame and bulk previews can't drift.
- Migration: the *UseFactory dev toggles were profile-ROOT keys, but the
  strip only swept the per-mode tables. Add a root-level strip.
- Locale: alphabetise the new Comet / Blink keys.

Author: Krathe82

AuraDesigner/Factory.lua

@@ -17,8 +17,8 @@ local addonName, DF = ...
 -- a native SetDurationBar-driven StatusBar for the bar, one 1-slot container per configured
 -- indicator, many coexisting). Placed duration text supports colour-by-time via the #205 discrete
 -- BUCKET formatter (C-side |c escapes — no Lua time read). framealpha / nametext / healthtext are
--- 12.1 casualties (see NOTES at the file foot). Sound + showWhenMissing are P4.5. The legacy
--- engine stays fully intact behind DF:UseFactoryForAD.
+-- 12.1 casualties (see NOTES at the file foot). Sound + showWhenMissing are P4.5. The factory
+-- is the only AD render path now — the legacy read-path engine was removed.
 --
 -- COMBAT / SECRET obligations (delegated to the DF.AuraContainer handle, the #205-proven
 -- path): containers are created/enabled OUT of combat and deferred to PLAYER_REGEN_ENABLED
@@ -44,8 +44,8 @@ local DBG = "AD"
 -- ============================================================
 
 -- Render gate: is the native AD path active for this frame right now? Hard-gated to
--- 12.1 (IsSupported) and OFF in test mode (the legacy preview painter owns test mode
--- until native test mode ships in P5). Default ON: only an explicit false disables it.
+-- 12.1 (IsSupported) and OFF in test mode — the test drives call the factory
+-- themselves (DF:UpdateAllTestAuraDesigner), so the live path must not double-drive.
 function DF:UseFactoryForAD(frame, db)
     return DF.AuraContainer and DF.AuraContainer.IsSupported()
         and not (DF.testMode or DF.raidTestMode)

Core.lua

@@ -4106,6 +4106,21 @@ DF._MainEventDispatcher = function(self, event, arg1)
                 end
             end
         end
+        -- The *UseFactory dev toggles lived at the profile ROOT (DF.db.adUseFactory,
+        -- not per-mode), so strip them there too. Harmless orphans otherwise.
+        local ROOT_LEGACY_KEYS = { "buffUseFactory", "debuffUseFactory",
+            "defensiveUseFactory", "missingBuffUseFactory", "dispelOverlayUseFactory",
+            "adUseFactory" }
+        local function StripRootLegacyKeys(root)
+            if not root then return end
+            for _, key in ipairs(ROOT_LEGACY_KEYS) do root[key] = nil end
+        end
+        StripRootLegacyKeys(DF.db)
+        if DandersFramesDB_v2 and DandersFramesDB_v2.profiles then
+            for _, profile in pairs(DandersFramesDB_v2.profiles) do
+                StripRootLegacyKeys(profile)
+            end
+        end
 
         -- v5.0 (12.1): the dispel overlay's Custom Colors mode was removed during
         -- the alpha (never in any distributed build — belt-and-braces for alpha

DandersFrames.toc

@@ -121,10 +121,6 @@ Features\Dispel.lua
 
 # Aura Designer
 AuraDesigner\Config.lua
-#   secret in some cases, which floods the error log via the UNIT_AURA guard.
-#   Only consumer is Symbiotic Relationship target inference for Resto Druid;
-#   minor functionality loss. Re-enable once Blizzard provides a non-secret
-#   path or after the guard is rewritten to use string comparison.
 AuraDesigner\AuraAdapter.lua
 AuraDesigner\Engine.lua
 AuraDesigner\Factory.lua

Locales/enUS.lua

@@ -1813,14 +1813,14 @@ L["Animation Particles"] = true
 L["Animation Scale"] = true
 L["Animation Thickness"] = true
 L["Border Animation"] = true
+L["Blink"] = true
 L["Chase"] = true
+L["Comet"] = true
 L["Corner Length"] = true
 L["Corners Only"] = true
 L["Flash"] = true
 L["Ripple"] = true
 L["Segment Reveal"] = true
-L["Comet"] = true
-L["Blink"] = true
 L["Sides Axis"] = true
 L["Sides Only"] = true
 L["Wipe"] = true

TestMode/TestMode.lua

@@ -1171,15 +1171,16 @@ function DF:UpdateTestFrame(frame, index, applyLayout)
         end
     end
 
-    -- Update Aura Designer test indicators
-    if db.testShowAuraDesigner and DF:IsAuraDesignerEnabled(frame) then
-        local ADEngine = DF.AuraDesigner and DF.AuraDesigner.Engine
-        if ADEngine and ADEngine.UpdateTestFrame then
-            ADEngine:UpdateTestFrame(frame)
+    -- Update Aura Designer test indicators through the factory containers — the
+    -- SAME path as the bulk DF:UpdateAllTestAuraDesigner, so the per-frame and
+    -- bulk previews can't drift (the legacy Engine:UpdateTestFrame is gone).
+    local ADFactory = DF.AuraDesigner and DF.AuraDesigner.Factory
+    if ADFactory then
+        if db.testShowAuraDesigner and DF:IsAuraDesignerEnabled(frame) then
+            ADFactory:SyncFrame(frame)
+        else
+            ADFactory:ClearFrame(frame)
         end
-    else
-        local ADEngine = DF.AuraDesigner and DF.AuraDesigner.Engine
-        if ADEngine then ADEngine:ClearFrame(frame) end
     end
 
     -- Update selection and aggro highlights for test mode