Skip to content

Commit e237486

Browse files
committed
Merge PR #130: Missing Buff - don't flag uncastable cross-faction targets (by Krathe)
# Conflicts: # CHANGELOG.md
2 parents 69bd4c5 + a5d4791 commit e237486

2 files changed

Lines changed: 14 additions & 1 deletion

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
### Bug Fixes
3535

3636
* (Range) The frame border (and other element borders) now reliably **fade out of range**, preserved across border re-renders. (by Krathe)
37+
* (Missing Buff) The missing-buff icon no longer flags a **cross-faction group member in the open world** as needing a buff you can't actually cast on them — it only appears where the buff is castable (e.g. inside instances). (by Krathe)
3738
* (Defensive Icon) The defensive cooldown icon and its border now render **above auras** and stay co-planar with the icon. (by Krathe)
3839
* (Role Icons) **Show Tank / Healer / DPS** toggles now apply live without a `/reload`, and are properly decoupled from the Hide-in-Combat gate. (by Krathe)
3940
* (Aura Designer) Indicators are torn down when the Aura Designer is disabled, and re-applied on **profile swap**. (by Krathe)

Frames/Icons.lua

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -809,7 +809,19 @@ function DF:UpdateMissingBuffIcon(frame, forceUpdate)
809809
missingBuffCache[frame] = nil
810810
return
811811
end
812-
812+
813+
-- Hide when we can't actually cast a beneficial spell on them — e.g. a
814+
-- cross-faction group member in the open world, where a "buff missing"
815+
-- icon is just noise because the buff is uncastable. UnitCanAssist flips
816+
-- to true inside instances where buffing them IS possible, so the icon
817+
-- only shows when it's actionable (mirrors Range.lua's cross-faction
818+
-- handling; the reaction funcs return clean, non-secret booleans).
819+
if not UnitCanAssist("player", unit) then
820+
frame.missingBuffFrame:Hide()
821+
missingBuffCache[frame] = nil
822+
return
823+
end
824+
813825
-- Check for missing buffs
814826
local missingSpellID = nil
815827
local missingIcon = nil

0 commit comments

Comments
 (0)