Add support for AWS S3 filestorage via custom adapter#12
Open
timstallmann wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A client I'm working with wanted to migrate to S3, but I really did not want to lose Archive Repertory support, and we're still on Omeka Classic.
The built-in Zend S3 filesystem adapter, unfortunately, is stuck on v2 of Amazon's AWS request signing protocol, which means that the file move operation breaks. Since that's a key part of Archive Repertory functionality, enabling S3 here requires using the EHRI custom S3 filesystem adapter, which supports v4 request signing.
But then, that custom adapter doesn't have a built-in method to check for file existence, so I added one in a PR, which hopefully will be merged at some point. But for now, you'll need to use my fork of the plugin.
So far this approach seems to work well; I'll likely continue to update over the next few days as we keep testing it out in production.