Add linux wheels build step

Author: DanielBok

.github/workflows/build.yml

@@ -53,7 +53,8 @@ jobs:
     strategy:
       fail-fast: False
       matrix:
-        os: [ ubuntu-latest, macos-latest ]
+        os: [ ubuntu-latest ]
+    #        os: [ ubuntu-latest, macos-latest ]
     steps:
       - name: Checkout repository
         uses: actions/checkout@v2
@@ -65,26 +66,42 @@ jobs:
         with:
           python-version: 3.8
 
-  #      - name: Build wheels
-  #        env:
-  #          # only build CPython-3.6 and later and skip 32-bit builds
-  #          CIBW_BUILD: cp36-* cp37-* cp38-*
-  #          CIBW_BEFORE_ALL_LINUX: yum update -y && yum install pcre-devel -y
-  #          CIBW_BEFORE_ALL_MACOS: brew install swig
-  #          CIBW_BEFORE_BUILD: python -m pip install -u pip numpy cibuildwheel==1.5.1
-  #          CIBW_BEFORE_BUILD_LINUX: |
-  #            scripts/install_swig.sh
-  #            python -m pip install cmake
-  #          CIBW_TEST_COMMAND: python {project}/extern/nlopt/test/t_python.py
-  #        run: python -m cibuildwheel --output-dir dist
+      - name: Build wheels
+        env:
+          # only build CPython-3.6 and later and skip 32-bit builds and skip windows
+          CIBW_BUILD: cp36-* cp37-* cp38-*
+          CIBW_SKIP: "*-win* *-manylinux_i686"
+          CIBW_BEFORE_ALL_LINUX: |
+            yum update -y && yum install pcre-devel cmake3 -y
+            yum remove cmake -y
+            ln -s /usr/bin/cmake3 /usr/bin/cmake
+
+            if [[ ! -e $(command -v swig) ]]; then
+              curl -L https://sourceforge.net/projects/swig/files/swig/swig-4.0.2/swig-4.0.2.tar.gz/download --output /tmp/swig.tar.gz
+              mkdir /tmp/swig
+              tar -xvzf /tmp/swig.tar.gz -C /tmp/swig --strip-components 1 &> /dev/null
+              pushd /tmp/swig
+              ./configure --without-alllang --with-python3 && make -j2 && make install > /dev/null
+              popd
+            fi
+          CIBW_BEFORE_ALL_MACOS: brew install swig
+          CIBW_BEFORE_BUILD: pip install numpy
+        run: |
+          pip install -U pip cibuildwheel==1.5.1
+          python -m cibuildwheel --output-dir dist
+
+      - name: Place wheels in artifacts folder
+        uses: actions/upload-artifact@v2
+        with:
+          path: ./dist/*.whl
 
   test-wheels:
     name: Test package installation
-    needs: [ build_wheels_windows ]
+    needs: [ build_wheels_windows, build_wheels_unix ]
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        os: [ windows-latest ]
+        os: [ windows-latest, ubuntu-latest ]
         python-version: [ 3.6, 3.7, 3.8 ]
 
     steps:
@@ -104,6 +121,7 @@ jobs:
 
       - name: Test Package Installation
         run: |
+          ls -alR dist
           python -m pip install --upgrade pip
 
           # finds path to the right wheel or source file to install later

extensions.py

@@ -25,88 +25,20 @@ def run(self):
         except OSError:
             raise RuntimeError("CMake must be installed")
 
+        if platform.system() not in ("Windows", "Linux", "Darwin"):
+            raise RuntimeError(f"Unsupported os: {platform.system()}")
+
         for ext in self.extensions:
             if isinstance(ext, NLOptBuildExtension):
                 self.build_extension(ext)
 
-    @property
-    def nlopt_dir(self):
-        return Path(__file__).parent / "tern" / "nlopt"
-
     @property
     def config(self):
         return "Debug" if self.debug else "Release"
 
-    def cmake_args(self, ext_dir: str):
-        prefix = "NLOPT_BUILD"
-
-        args = [
-            f"-DCMAKE_LIBRARY_OUTPUT_DIRECTORY={ext_dir}",
-            f"-DPYTHON_EXECUTABLE={sys.executable}",
-            # don't build for matlab and others
-            "-DNLOPT_GUILE=OFF",
-            "-DNLOPT_MATLAB=OFF",
-            "-DNLOPT_OCTAVE=OFF"]
-
-        if platform.system() == "Windows":
-            args += [
-                "-LAH",
-                f'-DCMAKE_PREFIX_PATH="{prefix}"',
-                f'-DCMAKE_INSTALL_PREFIX="{prefix}"'
-            ]
-        elif platform.system() in ("Linux", "Darwin"):
-            args += [
-                f"-DCMAKE_PREFIX_PATH={prefix}",
-                f"-DCMAKE_INSTALL_PREFIX={prefix}",
-                "-DCMAKE_INSTALL_LIBDIR=lib",
-            ]
-        else:
-            raise RuntimeError(f"Unsupported os: {platform.system()}")
-
-        return args
-
     def build_extension(self, ext: Extension):
         # - make sure path ends with delimiter
         # - required for auto-detection of auxiliary "native" libs
-        ext_dir = Path(self.get_ext_fullpath(ext.name)).parent.absolute().as_posix()
-        if not ext_dir.endswith(os.path.sep):
-            ext_dir += os.path.sep
-
-        if platform.system() == "Windows":
-            self._build_windows(ext)
-            return
-
-        exit(1)
-
-        cmake_args = [
-            "-DCMAKE_LIBRARY_OUTPUT_DIRECTORY=" + ext_dir,
-            "-DPYTHON_EXECUTABLE=" + sys.executable,
-        ]
-
-        cfg = "Debug" if self.debug else "Release"
-        build_args = ["--config", cfg]
-
-        if platform.system() == "Windows":
-            cmake_args += [f"-DCMAKE_LIBRARY_OUTPUT_DIRECTORY_{cfg.upper()}={ext_dir}"]
-            if sys.maxsize > 2 ** 32:
-                cmake_args += ["-A", "x64"]
-            build_args += (["--", "/m"])
-        else:
-            build_args += ["--", "-j2"]
-
-        env = os.environ.copy()
-        env["CXXFLAGS"] = f'{env.get("CXXFLAGS", "")} -DVERSION_INFO="{self.distribution.get_version()}"'
-
-        build_temp = Path(self.build_temp)
-        build_temp.mkdir(parents=True, exist_ok=True)
-
-        check_call(["cmake", ext.sourcedir, *cmake_args], cwd=self.build_temp, env=env)
-        check_call(["cmake", "--build", ".", *build_args], cwd=self.build_temp)
-
-        nlopt_py = next(Path(self.build_temp).rglob("nlopt.py"))
-        nlopt_py.rename(Path(ext_dir) / "__init__.py")
-
-    def _build_windows(self, ext: NLOptBuildExtension):
         ext_dir = Path(self.get_ext_fullpath(ext.name)).parent.absolute()
         _ed = ext_dir.as_posix()
         if not _ed.endswith(os.path.sep):
@@ -115,18 +47,22 @@ def _build_windows(self, ext: NLOptBuildExtension):
         build_dir = create_directory(Path(self.build_temp))
 
         # package builds in 2 steps, first to compile the nlopt package and second to build the DLL
+        cmd = [
+            "cmake",
+            "-LAH",
+            f"-DCMAKE_LIBRARY_OUTPUT_DIRECTORY={_ed}",
+            f"-DPYTHON_EXECUTABLE={sys.executable}",
+            "-DNLOPT_GUILE=OFF",
+            "-DNLOPT_MATLAB=OFF",
+            "-DNLOPT_OCTAVE=OFF",
+            ext.source_dir.as_posix()
+        ]
+
+        if platform.system() == "Windows":
+            cmd.insert(2, f"-DCMAKE_LIBRARY_OUTPUT_DIRECTORY_{self.config.upper()}={_ed}")
+
         execute_command(
-            cmd=[
-                "cmake",
-                "-LAH",
-                f"-DCMAKE_LIBRARY_OUTPUT_DIRECTORY={_ed}",
-                f"-DPYTHON_EXECUTABLE={sys.executable}",
-                f"-DCMAKE_LIBRARY_OUTPUT_DIRECTORY_{self.config.upper()}={_ed}",
-                "-DNLOPT_GUILE=OFF",
-                "-DNLOPT_MATLAB=OFF",
-                "-DNLOPT_OCTAVE=OFF",
-                ext.source_dir.as_posix()
-            ],
+            cmd=cmd,
             cwd=build_dir,
             env={
                 **os.environ.copy(),
@@ -141,7 +77,7 @@ def _build_windows(self, ext: NLOptBuildExtension):
             '--config',
             self.config,
             "--",
-            "-m"
+            "-m" if platform.system() == "Windows" else "-j2"
         ], cwd=build_dir)
 
         # Copy over the important bits