Skip to content

Commit 64826e4

Browse files
kprudenDanielMSchmidt
authored andcommitted
Use standard carrier format names (#72)
Fixes #71
1 parent ee5f180 commit 64826e4

1 file changed

Lines changed: 9 additions & 3 deletions

File tree

src/index.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,11 @@ const {
1212
} = require("zipkin");
1313
const { HttpLogger } = require("zipkin-transport-http");
1414
const availableTags = require("opentracing").Tags;
15+
const {
16+
FORMAT_BINARY,
17+
FORMAT_TEXT_MAP,
18+
FORMAT_HTTP_HEADERS
19+
} = require("opentracing");
1520
const { JSON_V2 } = jsonEncoder;
1621

1722
const HttpHeaders = {
@@ -289,9 +294,10 @@ class Tracing {
289294
}
290295
}
291296

292-
Tracing.FORMAT_TEXT_MAP = "FORMAT_TEXT_MAP";
293-
Tracing.FORMAT_HTTP_HEADERS = "FORMAT_HTTP_HEADERS";
294-
Tracing.FORMAT_BINARY = "FORMAT_BINARY";
297+
// These values should match https://github.com/opentracing/opentracing-javascript/blob/master/src/constants.ts
298+
Tracing.FORMAT_TEXT_MAP = FORMAT_TEXT_MAP;
299+
Tracing.FORMAT_HTTP_HEADERS = FORMAT_HTTP_HEADERS;
300+
Tracing.FORMAT_BINARY = FORMAT_BINARY;
295301

296302
// For testing purposes
297303
Tracing.makeOptional = makeOptional;

0 commit comments

Comments
 (0)