Revert "Added full KDE Plasma support, including listeners"#44
Open
shinnkka wants to merge 1 commit intoDansoftowner:masterfrom
Open
Revert "Added full KDE Plasma support, including listeners"#44shinnkka wants to merge 1 commit intoDansoftowner:masterfrom
shinnkka wants to merge 1 commit intoDansoftowner:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #41
Using the original GNOME support works across all Linux desktop environments .You only need to install
gsettings-desktop-schemas.If PR #41 is used, it will introduce the following issues:
Desktop environments other than GNOME and KDE Plasma 5, which originally worked, will no longer be supported.
Any version of Plasma other than KDE Plasma 5 (nowadays mostly Plasma 6) will enter an infinite error loop, because the environment detection treats all Plasma versions as Plasma 5 without checking the actual version. This leads to missing command errors.
The command
kreadconfig5 --file kdeglobals --group General --key ColorScheme(orkreadconfig6) can only retrieve the name of the current color scheme, but it cannot determine whether the scheme is light or dark. The dark theme I’m currently using, Apus, does not contain the word "dark" in its name, and is therefore mistakenly identified as a light theme, which is absurd.