fix: convert [Param] to [Arguments] when required

Author: SockworkOrange

benchmark/BenchmarkRunner/Benchmarks/BaseWriteBenchmark.cs

@@ -5,8 +5,6 @@ public abstract class BaseWriteBenchmark
     [Params(2000000)]
     public int TotalRecords { get; set; }
 
-    [Params(500)]
-    public int EFCoreBatchSize { get; set; }
-    public abstract Task Sqlc_AddOrderItems();
-    public abstract Task EFCore_AddOrderItems();
+    public abstract Task Sqlc_AddOrderItems(int batchSize);
+    public abstract Task EFCore_AddOrderItems(int batchSize);
 }

benchmark/BenchmarkRunner/Benchmarks/MysqlWriteBenchmark.cs

@@ -20,28 +20,25 @@ public class MysqlWriteBenchmark : BaseWriteBenchmark
     private readonly Queries _efCoreImpl = new(new SalesDbContext(_connectionString), useTracking: false);
     private List<QuerySql.AddOrderItemsArgs> _testOrderItems = null!;
 
-    /// <summary>
-    /// MySQL batch size can be very large yet very performant in SQLC implementation due to 
-    /// CSV load usage, so we wish to examine exceptionally large batches.
-    /// </summary>
-    [Params(1000, 5000, 20000)]
-    public int SqlcBatchSize { get; set; }
-
     [BenchmarkCategory("Write")]
     [Benchmark(Baseline = true, Description = "SQLC - AddOrderItems")]
-    public override async Task Sqlc_AddOrderItems()
+    [Arguments(1000)]
+    [Arguments(5000)]
+    [Arguments(20000)]
+    public override async Task Sqlc_AddOrderItems(int batchSize)
     {
-        await Helpers.InsertInBatchesAsync(_testOrderItems, SqlcBatchSize, _sqlcImpl.AddOrderItemsAsync);
+        await Helpers.InsertInBatchesAsync(_testOrderItems, batchSize, _sqlcImpl.AddOrderItemsAsync);
     }
 
     [BenchmarkCategory("Write")]
     [Benchmark(Description = "EFCore - AddOrderItems")]
-    public override async Task EFCore_AddOrderItems()
+    [Arguments(500)]
+    public override async Task EFCore_AddOrderItems(int batchSize)
     {
         var args = _testOrderItems.Select(i => new Queries.AddOrderItemsArgs(
             i.OrderId, i.ProductId, i.Quantity, i.UnitPrice
         )).ToList();
-        await Helpers.InsertInBatchesAsync(args, EFCoreBatchSize, _efCoreImpl.AddOrderItems);
+        await Helpers.InsertInBatchesAsync(args, batchSize, _efCoreImpl.AddOrderItems);
     }
 
     public static Func<Task> GetSeedMethod()

benchmark/BenchmarkRunner/Benchmarks/PostgresqlWriteBenchmark.cs

@@ -19,27 +19,24 @@ public class PostgresqlWriteBenchmark : BaseWriteBenchmark
     private readonly Queries _efCoreImpl = new(new SalesDbContext(_connectionString), useTracking: false);
     private List<QuerySql.AddOrderItemsArgs> _testOrderItems = null!;
 
-    /// <summary>
-    /// PostgreSQL batch size can be larger in SQLC implementation due to using COPY FROM syntax.
-    /// </summary>
-    [Params(500, 1000)]
-    public int SqlcBatchSize { get; set; }
-
     [BenchmarkCategory("Write")]
     [Benchmark(Baseline = true, Description = "SQLC - AddOrderItems")]
-    public override async Task Sqlc_AddOrderItems()
+    [Arguments(500)]
+    [Arguments(1000)]
+    public override async Task Sqlc_AddOrderItems(int batchSize)
     {
-        await Helpers.InsertInBatchesAsync(_testOrderItems, SqlcBatchSize, _sqlcImpl.AddOrderItemsAsync);
+        await Helpers.InsertInBatchesAsync(_testOrderItems, batchSize, _sqlcImpl.AddOrderItemsAsync);
     }
 
     [BenchmarkCategory("Write")]
     [Benchmark(Description = "EFCore - AddOrderItems")]
-    public override async Task EFCore_AddOrderItems()
+    [Arguments(500)]
+    public override async Task EFCore_AddOrderItems(int batchSize)
     {
         var args = _testOrderItems.Select(i => new Queries.AddOrderItemsArgs(
             i.OrderId, i.ProductId, i.Quantity, i.UnitPrice
         )).ToList();
-        await Helpers.InsertInBatchesAsync(args, EFCoreBatchSize, _efCoreImpl.AddOrderItems);
+        await Helpers.InsertInBatchesAsync(args, batchSize, _efCoreImpl.AddOrderItems);
     }
 
     public static Func<Task> GetSeedMethod()

benchmark/BenchmarkRunner/Benchmarks/SqliteWriteBenchmark.cs

@@ -20,28 +20,24 @@ public class SqliteWriteBenchmark : BaseWriteBenchmark
     private readonly Queries _efCoreImpl = new(new SalesDbContext(_connectionString), useTracking: false);
     private List<QuerySql.AddOrderItemsArgs> _testOrderItems = null!;
 
-    /// <summary>
-    /// SQLite batch size for SQLC there is a limitation of 1000 bind variables in the resulting SQL.
-    /// e.g. If we insert to a table with 10 columns, the maximum batch size is 1000 / 10 = 100.
-    /// </summary>
-    [Params(50, 100)]
-    public int SqlcBatchSize { get; set; }
-
     [BenchmarkCategory("Write")]
     [Benchmark(Baseline = true, Description = "SQLC - AddOrderItems")]
-    public override async Task Sqlc_AddOrderItems()
+    [Arguments(50)]
+    [Arguments(100)]
+    public override async Task Sqlc_AddOrderItems(int batchSize)
     {
-        await Helpers.InsertInBatchesAsync(_testOrderItems, SqlcBatchSize, _sqlcImpl.AddOrderItemsAsync);
+        await Helpers.InsertInBatchesAsync(_testOrderItems, batchSize, _sqlcImpl.AddOrderItemsAsync);
     }
 
     [BenchmarkCategory("Write")]
     [Benchmark(Description = "EFCore - AddOrderItems")]
-    public override async Task EFCore_AddOrderItems()
+    [Arguments(500)]
+    public override async Task EFCore_AddOrderItems(int batchSize)
     {
         var args = _testOrderItems.Select(i => new Queries.AddOrderItemsArgs(
             i.OrderId, i.ProductId, i.Quantity, i.UnitPrice
         )).ToList();
-        await Helpers.InsertInBatchesAsync(args, EFCoreBatchSize, _efCoreImpl.AddOrderItems);
+        await Helpers.InsertInBatchesAsync(args, batchSize, _efCoreImpl.AddOrderItems);
     }
 
     public static Func<Task> GetSeedMethod()