Skip to content

Commit 3f60414

Browse files
SockworkOrangeSockworkOrange
committed
fix: attempt fix visualization of params in readme files
1 parent 85a61ab commit 3f60414

7 files changed

Lines changed: 35 additions & 37 deletions

File tree

‎benchmark/BenchmarkRunner/Benchmarks/BaseWriteBenchmark.cs‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
public readonly record struct WriteBenchmarkArgs(
2-
int TotalRecords,
2+
int TotalRecordsToLoad,
33
int BatchSize
44
);
55

66
public abstract class BaseWriteBenchmark
77
{
8+
public const int TotalRecordsForSetup = 300000; // 3 million records
89
public const int OrderIdsCountForSetup = 1000;
910
public const int ProductIdsCountForSetup = 1000;
1011

‎benchmark/BenchmarkRunner/Benchmarks/MysqlReadBenchmark.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ public class MysqlReadBenchmark : BaseReadBenchmark
2020

2121
public static IEnumerable<ReadBenchmarkParams> GetParams()
2222
{
23-
yield return new ReadBenchmarkParams(Limit: 50, Concurrency: 200, QueriesToSubmit: 4_000);
24-
yield return new ReadBenchmarkParams(Limit: 1000, Concurrency: 100, QueriesToSubmit: 2_000);
23+
yield return new ReadBenchmarkParams(Limit: 50, Concurrency: 200, QueriesToSubmit: 4000);
24+
yield return new ReadBenchmarkParams(Limit: 1000, Concurrency: 100, QueriesToSubmit: 2000);
2525
}
2626

2727
[ParamsSource(nameof(GetParams))]

‎benchmark/BenchmarkRunner/Benchmarks/MysqlWriteBenchmark.cs‎

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ namespace BenchmarkRunner.Benchmarks;
1717
[CategoriesColumn]
1818
public class MysqlWriteBenchmark : BaseWriteBenchmark
1919
{
20-
private const int _totalRecordsForSetup = 300_000;
2120
private static readonly string _connectionString = Config.GetMysqlConnectionString();
2221
private readonly QuerySql _sqlcImpl = new(_connectionString);
2322
private readonly Queries _efCoreImpl = new(new SalesDbContext(_connectionString), useTracking: false);
@@ -27,33 +26,33 @@ public class MysqlWriteBenchmark : BaseWriteBenchmark
2726

2827
public static IEnumerable<WriteBenchmarkArgs> GetSqlcArguments()
2928
{
30-
yield return new WriteBenchmarkArgs(TotalRecords: _totalRecordsForSetup, BatchSize: 1_000);
31-
yield return new WriteBenchmarkArgs(TotalRecords: _totalRecordsForSetup, BatchSize: 5_000);
29+
yield return new WriteBenchmarkArgs(TotalRecordsToLoad: TotalRecordsForSetup, BatchSize: 1000);
30+
yield return new WriteBenchmarkArgs(TotalRecordsToLoad: TotalRecordsForSetup, BatchSize: 5000);
3231
}
3332

3433
[BenchmarkCategory("Write")]
3534
[Benchmark(Baseline = true, Description = "SQLC - AddOrderItems")]
3635
[ArgumentsSource(nameof(GetSqlcArguments))]
3736
public override async Task Sqlc_AddOrderItems(WriteBenchmarkArgs args)
3837
{
39-
await Helpers.InsertInBatchesAsync(_sqlcTestOrderItems[..args.TotalRecords], args.BatchSize, _sqlcImpl.AddOrderItemsAsync);
38+
await Helpers.InsertInBatchesAsync(_sqlcTestOrderItems[..args.TotalRecordsToLoad], args.BatchSize, _sqlcImpl.AddOrderItemsAsync);
4039
var result = await _sqlcImpl.GetOrderItemsCountAsync();
41-
Assert.That(result?.Cnt, Is.EqualTo(args.TotalRecords));
40+
Assert.That(result?.Cnt, Is.EqualTo(args.TotalRecordsToLoad));
4241
}
4342

4443
public static IEnumerable<WriteBenchmarkArgs> GetEFCoreArguments()
4544
{
46-
yield return new WriteBenchmarkArgs(TotalRecords: _totalRecordsForSetup, BatchSize: 500);
45+
yield return new WriteBenchmarkArgs(TotalRecordsToLoad: TotalRecordsForSetup, BatchSize: 500);
4746
}
4847

4948
[BenchmarkCategory("Write")]
5049
[Benchmark(Description = "EFCore - AddOrderItems")]
5150
[ArgumentsSource(nameof(GetEFCoreArguments))]
5251
public override async Task EFCore_AddOrderItems(WriteBenchmarkArgs args)
5352
{
54-
await Helpers.InsertInBatchesAsync(_efCoreTestOrderItems[..args.TotalRecords], args.BatchSize, _efCoreImpl.AddOrderItems);
53+
await Helpers.InsertInBatchesAsync(_efCoreTestOrderItems[..args.TotalRecordsToLoad], args.BatchSize, _efCoreImpl.AddOrderItems);
5554
var result = await _sqlcImpl.GetOrderItemsCountAsync();
56-
Assert.That(result?.Cnt, Is.EqualTo(args.TotalRecords));
55+
Assert.That(result?.Cnt, Is.EqualTo(args.TotalRecordsToLoad));
5756
}
5857

5958
public static Func<Task> GetSeedMethod()
@@ -85,7 +84,7 @@ public static void IterationSetup()
8584
List<QuerySql.GetOrderIdsRow> orderIds,
8685
List<QuerySql.GetProductIdsRow> productIds)
8786
{
88-
return [.. Enumerable.Range(0, _totalRecordsForSetup).Select(i => new QuerySql.AddOrderItemsArgs(
87+
return [.. Enumerable.Range(0, TotalRecordsForSetup).Select(i => new QuerySql.AddOrderItemsArgs(
8988
OrderId: orderIds[i % OrderIdsCountForSetup].OrderId,
9089
ProductId: productIds[i % ProductIdsCountForSetup].ProductId,
9190
Quantity: Random.Shared.Next(1, 10),
@@ -97,7 +96,7 @@ public static void IterationSetup()
9796
List<QuerySql.GetOrderIdsRow> orderIds,
9897
List<QuerySql.GetProductIdsRow> productIds)
9998
{
100-
return [.. Enumerable.Range(0, _totalRecordsForSetup).Select(i => new Queries.AddOrderItemsArgs(
99+
return [.. Enumerable.Range(0, TotalRecordsForSetup).Select(i => new Queries.AddOrderItemsArgs(
101100
OrderId: orderIds[i % OrderIdsCountForSetup].OrderId,
102101
ProductId: productIds[i % ProductIdsCountForSetup].ProductId,
103102
Quantity: Random.Shared.Next(1, 10),

‎benchmark/BenchmarkRunner/Benchmarks/PostgresqlReadBenchmark.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ public class PostgresqlReadBenchmark : BaseReadBenchmark
2020

2121
public static IEnumerable<ReadBenchmarkParams> GetParams()
2222
{
23-
yield return new ReadBenchmarkParams(Limit: 50, Concurrency: 150, QueriesToSubmit: 4_000);
24-
yield return new ReadBenchmarkParams(Limit: 1000, Concurrency: 75, QueriesToSubmit: 2_000);
23+
yield return new ReadBenchmarkParams(Limit: 50, Concurrency: 150, QueriesToSubmit: 4000);
24+
yield return new ReadBenchmarkParams(Limit: 1000, Concurrency: 75, QueriesToSubmit: 2000);
2525
}
2626

2727
[ParamsSource(nameof(GetParams))]

‎benchmark/BenchmarkRunner/Benchmarks/PostgresqlWriteBenchmark.cs‎

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ namespace BenchmarkRunner.Benchmarks;
1616
[CategoriesColumn]
1717
public class PostgresqlWriteBenchmark : BaseWriteBenchmark
1818
{
19-
private const int _totalRecordsForSetup = 300_000;
2019
private static readonly string _connectionString = Config.GetPostgresConnectionString();
2120
private readonly QuerySql _sqlcImpl = new(_connectionString);
2221
private readonly Queries _efCoreImpl = new(new SalesDbContext(_connectionString), useTracking: false);
@@ -25,33 +24,33 @@ public class PostgresqlWriteBenchmark : BaseWriteBenchmark
2524

2625
public static IEnumerable<WriteBenchmarkArgs> GetSqlcArguments()
2726
{
28-
yield return new WriteBenchmarkArgs(TotalRecords: _totalRecordsForSetup, BatchSize: 1_000);
29-
yield return new WriteBenchmarkArgs(TotalRecords: _totalRecordsForSetup, BatchSize: 2_000);
27+
yield return new WriteBenchmarkArgs(TotalRecordsToLoad: TotalRecordsForSetup, BatchSize: 1000);
28+
yield return new WriteBenchmarkArgs(TotalRecordsToLoad: TotalRecordsForSetup, BatchSize: 2000);
3029
}
3130

3231
[BenchmarkCategory("Write")]
3332
[Benchmark(Baseline = true, Description = "SQLC - AddOrderItems")]
3433
[ArgumentsSource(nameof(GetSqlcArguments))]
3534
public override async Task Sqlc_AddOrderItems(WriteBenchmarkArgs args)
3635
{
37-
await Helpers.InsertInBatchesAsync(_sqlcTestOrderItems[..args.TotalRecords], args.BatchSize, _sqlcImpl.AddOrderItemsAsync);
36+
await Helpers.InsertInBatchesAsync(_sqlcTestOrderItems[..args.TotalRecordsToLoad], args.BatchSize, _sqlcImpl.AddOrderItemsAsync);
3837
var result = await _sqlcImpl.GetOrderItemsCountAsync();
39-
Assert.That(result?.Cnt, Is.EqualTo(args.TotalRecords));
38+
Assert.That(result?.Cnt, Is.EqualTo(args.TotalRecordsToLoad));
4039
}
4140

4241
public static IEnumerable<WriteBenchmarkArgs> GetEFCoreArguments()
4342
{
44-
yield return new WriteBenchmarkArgs(TotalRecords: _totalRecordsForSetup, BatchSize: 500);
43+
yield return new WriteBenchmarkArgs(TotalRecordsToLoad: TotalRecordsForSetup, BatchSize: 500);
4544
}
4645

4746
[BenchmarkCategory("Write")]
4847
[Benchmark(Description = "EFCore - AddOrderItems")]
4948
[ArgumentsSource(nameof(GetEFCoreArguments))]
5049
public override async Task EFCore_AddOrderItems(WriteBenchmarkArgs args)
5150
{
52-
await Helpers.InsertInBatchesAsync(_efCoreTestOrderItems[..args.TotalRecords], args.BatchSize, _efCoreImpl.AddOrderItems);
51+
await Helpers.InsertInBatchesAsync(_efCoreTestOrderItems[..args.TotalRecordsToLoad], args.BatchSize, _efCoreImpl.AddOrderItems);
5352
var result = await _sqlcImpl.GetOrderItemsCountAsync();
54-
Assert.That(result?.Cnt, Is.EqualTo(args.TotalRecords));
53+
Assert.That(result?.Cnt, Is.EqualTo(args.TotalRecordsToLoad));
5554
}
5655

5756
public static Func<Task> GetSeedMethod()
@@ -83,7 +82,7 @@ public static void IterationSetup()
8382
List<QuerySql.GetOrderIdsRow> orderIds,
8483
List<QuerySql.GetProductIdsRow> productIds)
8584
{
86-
return [.. Enumerable.Range(0, _totalRecordsForSetup).Select(i => new QuerySql.AddOrderItemsArgs(
85+
return [.. Enumerable.Range(0, TotalRecordsForSetup).Select(i => new QuerySql.AddOrderItemsArgs(
8786
OrderId: orderIds[i % OrderIdsCountForSetup].OrderId,
8887
ProductId: productIds[i % ProductIdsCountForSetup].ProductId,
8988
Quantity: Random.Shared.Next(1, 10),
@@ -95,7 +94,7 @@ public static void IterationSetup()
9594
List<QuerySql.GetOrderIdsRow> orderIds,
9695
List<QuerySql.GetProductIdsRow> productIds)
9796
{
98-
return [.. Enumerable.Range(0, _totalRecordsForSetup).Select(i => new Queries.AddOrderItemsArgs(
97+
return [.. Enumerable.Range(0, TotalRecordsForSetup).Select(i => new Queries.AddOrderItemsArgs(
9998
OrderId: orderIds[i % OrderIdsCountForSetup].OrderId,
10099
ProductId: productIds[i % ProductIdsCountForSetup].ProductId,
101100
Quantity: Random.Shared.Next(1, 10),

‎benchmark/BenchmarkRunner/Benchmarks/SqliteReadBenchmark.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ public class SqliteReadBenchmark : BaseReadBenchmark
2121

2222
public static IEnumerable<ReadBenchmarkParams> GetParams()
2323
{
24-
yield return new ReadBenchmarkParams(Limit: 50, Concurrency: 100, QueriesToSubmit: 3_000);
25-
yield return new ReadBenchmarkParams(Limit: 1000, Concurrency: 50, QueriesToSubmit: 1_500);
24+
yield return new ReadBenchmarkParams(Limit: 50, Concurrency: 100, QueriesToSubmit: 3000);
25+
yield return new ReadBenchmarkParams(Limit: 1000, Concurrency: 50, QueriesToSubmit: 1500);
2626
}
2727

2828
[ParamsSource(nameof(GetParams))]

‎benchmark/BenchmarkRunner/Benchmarks/SqliteWriteBenchmark.cs‎

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ namespace BenchmarkRunner.Benchmarks;
1717
[CategoriesColumn]
1818
public class SqliteWriteBenchmark : BaseWriteBenchmark
1919
{
20-
private const int _totalRecordsForSetup = 300_000;
2120
private static readonly string _connectionString = Config.GetSqliteConnectionString();
2221
private readonly QuerySql _sqlcImpl = new(_connectionString);
2322
private readonly Queries _efCoreImpl = new(new SalesDbContext(_connectionString), useTracking: false);
@@ -26,33 +25,33 @@ public class SqliteWriteBenchmark : BaseWriteBenchmark
2625

2726
public static IEnumerable<WriteBenchmarkArgs> GetSqlcArguments()
2827
{
29-
yield return new WriteBenchmarkArgs(TotalRecords: _totalRecordsForSetup, BatchSize: 50);
30-
yield return new WriteBenchmarkArgs(TotalRecords: _totalRecordsForSetup, BatchSize: 100);
28+
yield return new WriteBenchmarkArgs(TotalRecordsToLoad: TotalRecordsForSetup, BatchSize: 50);
29+
yield return new WriteBenchmarkArgs(TotalRecordsToLoad: TotalRecordsForSetup, BatchSize: 100);
3130
}
3231

3332
[BenchmarkCategory("Write")]
3433
[Benchmark(Baseline = true, Description = "SQLC - AddOrderItems")]
3534
[ArgumentsSource(nameof(GetSqlcArguments))]
3635
public override async Task Sqlc_AddOrderItems(WriteBenchmarkArgs args)
3736
{
38-
await Helpers.InsertInBatchesAsync(_sqlcTestOrderItems[..args.TotalRecords], args.BatchSize, _sqlcImpl.AddOrderItemsAsync);
37+
await Helpers.InsertInBatchesAsync(_sqlcTestOrderItems[..args.TotalRecordsToLoad], args.BatchSize, _sqlcImpl.AddOrderItemsAsync);
3938
var result = await _sqlcImpl.GetOrderItemsCountAsync();
40-
Assert.That(result?.Cnt, Is.EqualTo(args.TotalRecords));
39+
Assert.That(result?.Cnt, Is.EqualTo(args.TotalRecordsToLoad));
4140
}
4241

4342
public static IEnumerable<WriteBenchmarkArgs> GetEFCoreArguments()
4443
{
45-
yield return new WriteBenchmarkArgs(TotalRecords: _totalRecordsForSetup, BatchSize: 500);
44+
yield return new WriteBenchmarkArgs(TotalRecordsToLoad: TotalRecordsForSetup, BatchSize: 500);
4645
}
4746

4847
[BenchmarkCategory("Write")]
4948
[Benchmark(Description = "EFCore - AddOrderItems")]
5049
[ArgumentsSource(nameof(GetEFCoreArguments))]
5150
public override async Task EFCore_AddOrderItems(WriteBenchmarkArgs args)
5251
{
53-
await Helpers.InsertInBatchesAsync(_efCoreTestOrderItems[..args.TotalRecords], args.BatchSize, _efCoreImpl.AddOrderItems);
52+
await Helpers.InsertInBatchesAsync(_efCoreTestOrderItems[..args.TotalRecordsToLoad], args.BatchSize, _efCoreImpl.AddOrderItems);
5453
var result = await _sqlcImpl.GetOrderItemsCountAsync();
55-
Assert.That(result?.Cnt, Is.EqualTo(args.TotalRecords));
54+
Assert.That(result?.Cnt, Is.EqualTo(args.TotalRecordsToLoad));
5655
}
5756

5857
public static Func<Task> GetSeedMethod()
@@ -85,7 +84,7 @@ public static void IterationSetup()
8584
List<QuerySql.GetOrderIdsRow> orderIds,
8685
List<QuerySql.GetProductIdsRow> productIds)
8786
{
88-
return [.. Enumerable.Range(0, _totalRecordsForSetup).Select(i => new QuerySql.AddOrderItemsArgs(
87+
return [.. Enumerable.Range(0, TotalRecordsForSetup).Select(i => new QuerySql.AddOrderItemsArgs(
8988
OrderId: orderIds[i % OrderIdsCountForSetup].OrderId,
9089
ProductId: productIds[i % ProductIdsCountForSetup].ProductId,
9190
Quantity: Random.Shared.Next(1, 10),
@@ -97,7 +96,7 @@ public static void IterationSetup()
9796
List<QuerySql.GetOrderIdsRow> orderIds,
9897
List<QuerySql.GetProductIdsRow> productIds)
9998
{
100-
return [.. Enumerable.Range(0, _totalRecordsForSetup).Select(i => new Queries.AddOrderItemsArgs(
99+
return [.. Enumerable.Range(0, TotalRecordsForSetup).Select(i => new Queries.AddOrderItemsArgs(
101100
OrderId: orderIds[i % OrderIdsCountForSetup].OrderId,
102101
ProductId: productIds[i % ProductIdsCountForSetup].ProductId,
103102
Quantity: Random.Shared.Next(1, 10),

0 commit comments

Comments
 (0)