Skip to content

Commit ea573a8

Browse files
fix: adjust benchmark settings
1 parent 8f3442f commit ea573a8

8 files changed

Lines changed: 12 additions & 9 deletions

File tree

benchmark/BenchmarkRunner/Benchmarks/MysqlReadBenchmark.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ public class MysqlReadBenchmark
1919
private const int CustomerCount = 500;
2020
private const int QueriesToRun = 1000;
2121

22-
[Params(50, 500, 1000)]
22+
[Params(100, 1000)]
2323
public int Limit { get; set; }
2424

2525
[Params(10, 50)]

benchmark/BenchmarkRunner/Benchmarks/MysqlWriteBenchmark.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
12
using BenchmarkDotNet.Attributes;
23
using BenchmarkDotNet.Configs;
34
using BenchmarkDotNet.Jobs;
@@ -20,14 +21,14 @@ public class MysqlWriteBenchmark
2021
private Queries _efCoreImpl = null!;
2122
private List<QuerySql.AddOrderItemsArgs> _testOrderItems = null!;
2223

23-
[Params(1000, 10000, 50000)]
24+
[Params(500, 1000, 2000)]
2425
public int BatchSize { get; set; }
2526

2627
[GlobalSetup]
2728
public void GlobalSetup()
2829
{
2930
_sqlcImpl = new QuerySql(_connectionString);
30-
_efCoreImpl = new Queries(new SalesDbContext(_connectionString));
31+
_efCoreImpl = new Queries(new SalesDbContext(_connectionString), useTracking: false);
3132
PrepareTestDataAsync().GetAwaiter().GetResult();
3233
}
3334

benchmark/BenchmarkRunner/Benchmarks/PostgresqlReadBenchmark.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ public class PostgresqlReadBenchmark
1919
private const int CustomerCount = 500;
2020
private const int QueriesToRun = 1000;
2121

22-
[Params(50, 500, 1000)]
22+
[Params(100, 1000)]
2323
public int Limit { get; set; }
2424

2525
[Params(10, 50)]

benchmark/BenchmarkRunner/Benchmarks/PostgresqlWriteBenchmark.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,14 @@ public class PostgresqlWriteBenchmark
2020
private Queries _efCoreImpl = null!;
2121
private List<QuerySql.AddOrderItemsArgs> _testOrderItems = null!;
2222

23-
[Params(500, 1000, 3000)]
23+
[Params(500, 1000, 2000)]
2424
public int BatchSize { get; set; }
2525

2626
[GlobalSetup]
2727
public void GlobalSetup()
2828
{
2929
_sqlcImpl = new QuerySql(_connectionString);
30-
_efCoreImpl = new Queries(new SalesDbContext(_connectionString));
30+
_efCoreImpl = new Queries(new SalesDbContext(_connectionString), useTracking: false);
3131
PrepareTestDataAsync().GetAwaiter().GetResult();
3232
}
3333

benchmark/BenchmarkRunner/Benchmarks/SqliteReadBenchmark.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public class SqliteReadBenchmark
1717
private readonly string _connectionString = Config.GetSqliteConnectionString();
1818
private QuerySql _sqlcImpl = null!;
1919
private const int CustomerCount = 250;
20-
private const int QueriesToRun = 500;
20+
private const int QueriesToRun = 250;
2121

2222
[Params(50, 500)]
2323
public int Limit { get; set; }

benchmark/BenchmarkRunner/Benchmarks/SqliteWriteBenchmark.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ namespace BenchmarkRunner.Benchmarks;
1414
[CategoriesColumn]
1515
public class SqliteWriteBenchmark
1616
{
17-
private const int TotalRecords = 500000; // 500K records
17+
private const int TotalRecords = 1000000; // 1 million records
1818
private readonly string _connectionString = Config.GetSqliteConnectionString();
1919
private QuerySql _sqlcImpl = null!;
2020
private Queries _efCoreImpl = null!;
@@ -27,7 +27,7 @@ public class SqliteWriteBenchmark
2727
public void GlobalSetup()
2828
{
2929
_sqlcImpl = new QuerySql(_connectionString);
30-
_efCoreImpl = new Queries(new SalesDbContext(_connectionString));
30+
_efCoreImpl = new Queries(new SalesDbContext(_connectionString), useTracking: false);
3131
PrepareTestDataAsync().GetAwaiter().GetResult();
3232
}
3333

benchmark/MysqlEFCoreImpl/Queries.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,5 +133,6 @@ public async Task AddOrderItems(List<AddOrderItemsArgs> args)
133133

134134
await _dbContext.OrderItems.AddRangeAsync(orderItems);
135135
await _dbContext.SaveChangesAsync();
136+
_dbContext.ChangeTracker.Clear(); // Clear tracking to prevent conflicts in batch operations
136137
}
137138
}

benchmark/PostgresqlEFCoreImpl/Queries.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,5 +118,6 @@ public async Task AddOrderItems(List<AddOrderItemsArgs> args)
118118

119119
await _dbContext.OrderItems.AddRangeAsync(orderItems);
120120
await _dbContext.SaveChangesAsync();
121+
_dbContext.ChangeTracker.Clear(); // Clear tracking to prevent conflicts in batch operations
121122
}
122123
}

0 commit comments

Comments
 (0)