feat: add option to override string to DateTime for Sqlite - #317
Merged
SockworkOrange merged 7 commits intoSep 27, 2025
Conversation
SockworkOrange
changed the title
SockworkOrange
force-pushed
the
316-question-about-type-overrides-in-sqlite
branch
from
September 24, 2025 19:52
f754a81 to
7712c7f
Compare
SockworkOrange
force-pushed
the
316-question-about-type-overrides-in-sqlite
branch
from
September 24, 2025 20:21
3f4d78c to
e618035
Compare
doron050
reviewed
Sep 26, 2025
Comment on lines
+66
to
+67
| return $"{el} != null ? (int?) new DateTimeOffset({elWithOptionalNull}.ToUniversalTime()).ToUnixTimeSeconds() : {nullValue}"; | ||
| return $"{el} != null ? {elWithOptionalNull}.ToString(\"yyyy-MM-dd HH:mm:ss\") : {nullValue}"; |
Collaborator
There was a problem hiding this comment.
Great work! only two questions
\"yyyy-MM-dd HH:mm:ss\"shouldn't this come from the override config (we can have a coded default)- Shouldn't this be documented in our README override options?
Collaborator
Author
There was a problem hiding this comment.
- Maybe a constant, don't think as an option - that is the default datetime format in SQLite. While it doesn't have datetime data type support, it does have a datetime function that returns at this format. relying on the default makes sense here, no?
- Yeah definitely, will add that
github-actions
Bot
deleted the
316-question-about-type-overrides-in-sqlite
branch
December 1, 2025 02:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.