prevent-file-completion-in-attr-matches

Author: Darshan808

IPython/core/completer.py

@@ -2209,15 +2209,6 @@ def file_matcher(self, context: CompletionContext) -> SimpleMatcherResult:
         """
         # TODO: add a heuristic for suppressing (e.g. if it has OS-specific delimiter,
         #  starts with `/home/`, `C:\`, etc)
-        last_line = context.full_text.split("\n")[-1]
-        text_before_token = last_line[: last_line.rfind(context.token)]
-
-        # Suppress path completion when completing methods/attributes
-        if text_before_token.endswith((")", "]")):
-            return {
-                "completions": [],
-                "suppress": True,
-            }
 
         text = context.token
 
@@ -2490,7 +2481,7 @@ def _jedi_matcher(self, context: CompletionContext) -> _JediMatcherResult:
         return {
             "completions": matches,
             # static analysis should not suppress other matchers
-            "suppress": False,
+            "suppress": {_get_matcher_id(self.file_matcher)},
         }
 
     def _jedi_matches(
@@ -2750,12 +2741,16 @@ def python_matcher(self, context: CompletionContext) -> SimpleMatcherResult:
                             is None
                         )
                     matches = filter(no__name, matches)
-                return _convert_matcher_v1_result_to_v2(
+                matches = _convert_matcher_v1_result_to_v2(
                     matches, type="attribute", fragment=fragment
                 )
+                matches["suppress"] = {_get_matcher_id(self.file_matcher)}
+                return matches
             except NameError:
                 # catches <undefined attributes>.<tab>
-                return SimpleMatcherResult(completions=[], suppress=False)
+                return SimpleMatcherResult(
+                    completions=[], suppress={_get_matcher_id(self.file_matcher)}
+                )
         else:
             try:
                 matches = self.global_matches(context.token, context=context)
@@ -2766,7 +2761,7 @@ def python_matcher(self, context: CompletionContext) -> SimpleMatcherResult:
                 completions=[
                     SimpleCompletion(text=match, type="variable") for match in matches
                 ],
-                suppress=False,
+                suppress={_get_matcher_id(self.file_matcher)},
             )
 
     @completion_matcher(api_version=1)

tests/test_completer.py

@@ -2121,20 +2121,17 @@ def test_undefined_variables(use_jedi, evaluation, code, insert_text):
                 "    return 1.1",
                 "my_test().",
             ]
-        ),
-        'print("foo").',
+        )
     ],
 )
 def test_no_file_completions_in_attr_access(code):
     """Test that files are not suggested during attribute/method completion."""
     with TemporaryWorkingDirectory():
-        # Create a hidden file
         open(".hidden", "w", encoding="utf-8").close()
         offset = len(code)
         with provisionalcompleter():
             completions = list(ip.Completer.completions(text=code, offset=offset))
             matches = [c for c in completions if c.text.lstrip(".") == "hidden"]
-            # No file completions should appear
             assert (
                 len(matches) == 0
             ), f"File '.hidden' should not appear in attribute completion"