Commit b16661a
authored
Remove pytest-asyncio pin (ipython#14939)
The downstream `ipykernel` tests using the recent changes on the `main`
branch there are failing here with
```bash
ERROR tests/inprocess/test_kernel.py::test_do_execute - DeprecationWarning: pytest-asyncio detected an unclosed event loop when tearing down the event_loop
fixture: <_UnixSelectorEventLoop running=False closed=False debug=False>
pytest-asyncio will close the event loop for you, but future versions of the
library will no longer do so. In order to ensure compatibility with future
versions, please make sure that:
1. Any custom "event_loop" fixture properly closes the loop after yielding it
2. The scopes of your custom "event_loop" fixtures do not overlap
3. Your code does not modify the event loop in async fixtures or tests
=========================== 184 passed, 19 skipped, 1 warning, 1 error in 102.33s (0:01:42) ============================
```
Currently we pin `pytest-asyncio<0.22` here whereas in `ipykernel` we
use `pytest-asyncio>=0.23.5` so the two pins are not compatible. Both
projects do not pin `pytest` so use `8.4.1`.
According to the `pytest-asyncio`
[changelog](https://pytest-asyncio.readthedocs.io/en/stable/reference/changelog.html#id40)
for compatibility with `pytest>=8` we need at least
`pytest-asyncio>=0.23.5`.
If I remove the `pytest-asyncio` pin locally then all tests pass on both
Ubuntu and macOS, so this PR is seeing what happens without the pin on
the full CI matrix.2 files changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | | - | |
| 72 | + | |
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | | - | |
| 73 | + | |
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
| |||
0 commit comments