Skip to content

Commit 02468bb

Browse files
miczyg1philipanda
miczyg1
authored and
philipanda
committed
superio/ite/common: Add common driver for GPIO and LED configuration
Add a generic driver to configure GPIOs and LEDs on common ITE SuperIOs. The driver supports most ITE SuperIOs, except Embedded Controllers. The driver allows configuring every GPIO property with pin granularity. Verified against datasheets of all ITE SIOs currently supported by coreboot, except IT8721F (assumed to be the same as IT8720F), IT8623E and IT8629E. Change-Id: If610d2809b56c63444c3406c26fad412c94136a5 Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/83355 Reviewed-by: Nicholas Sudsgaard <devel+coreboot@nsudsgaard.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nico Huber <nico.h@gmx.de>
1 parent 98d34f5 commit 02468bb

4 files changed

Lines changed: 300 additions & 0 deletions

File tree

‎src/superio/ite/Makefile.mk‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,16 @@
44
bootblock-$(CONFIG_SUPERIO_ITE_COMMON_PRE_RAM) += common/early_serial.c
55
romstage-$(CONFIG_SUPERIO_ITE_COMMON_PRE_RAM) += common/early_serial.c
66

7+
bootblock-$(CONFIG_SUPERIO_ITE_COMMON_GPIO_PRE_RAM) += common/gpio.c
8+
romstage-$(CONFIG_SUPERIO_ITE_COMMON_GPIO_PRE_RAM) += common/gpio.c
9+
710
## include generic ite environment controller driver
811
ramstage-$(CONFIG_SUPERIO_ITE_ENV_CTRL) += common/env_ctrl.c
912

13+
## include generic ite driver to smm to control S3-relevant functions
14+
smm-$(CONFIG_SUPERIO_ITE_COMMON_PRE_RAM) += common/early_serial.c
15+
smm-$(CONFIG_SUPERIO_ITE_COMMON_GPIO_PRE_RAM) += common/gpio.c
16+
1017
subdirs-y += it8528e
1118
subdirs-y += it8613e
1219
subdirs-y += it8623e

‎src/superio/ite/common/Kconfig‎

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,33 @@
55
config SUPERIO_ITE_COMMON_PRE_RAM
66
bool
77

8+
config SUPERIO_ITE_COMMON_GPIO_PRE_RAM
9+
bool
10+
help
11+
Enable generic pre-ram driver for configuring ITE SIO GPIOs.
12+
It applies only to ITE SIOs not ITE ECs using LDN 7 (typically)
13+
to configure GPIO Simple I/O mode.
14+
15+
if SUPERIO_ITE_COMMON_GPIO_PRE_RAM
16+
17+
config SUPERIO_ITE_COMMON_NUM_GPIO_SETS
18+
int
19+
help
20+
The maximum number of GPIO sets supported by ITE SIO chip.
21+
Each SIO chip must set this config option to a proper values
22+
if it intends to enable SUPERIO_ITE_COMMON_GPIO_PRE_RAM.
23+
24+
config SUPERIO_ITE_COMMON_GPIO_LED_FREQ_5BIT
25+
bool
26+
default n
27+
help
28+
Selected ITE SIOs control the GPIO LED frequency using 5 bits
29+
instead of two. The LED register layout is also different for
30+
these chips. Select this if the SIO GP LED Frequency control
31+
field has 5 bits and support duty cycle as well.
32+
33+
endif
34+
835
# Generic ITE environment controller driver
936
config SUPERIO_ITE_ENV_CTRL
1037
bool

‎src/superio/ite/common/gpio.c‎

Lines changed: 191 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,191 @@
1+
/* SPDX-License-Identifier: GPL-2.0-or-later */
2+
3+
#include <device/pnp_ops.h>
4+
#include <device/pnp.h>
5+
#include <stdint.h>
6+
7+
#include "ite.h"
8+
#include "ite_gpio.h"
9+
10+
/* Catch ITE SIOs that enable the driver but do not configure the number of sets */
11+
#if CONFIG_SUPERIO_ITE_COMMON_NUM_GPIO_SETS == 0
12+
#error "Maximum number of ITE SIO GPIO sets not provided"
13+
#endif
14+
15+
#if CONFIG_SUPERIO_ITE_COMMON_NUM_GPIO_SETS > 10
16+
#error "ITE SIO GPIO drivers only support up to 10 GPIO sets"
17+
#endif
18+
19+
/* GPIO Polarity Select: 1: Inverting, 0: Non-inverting */
20+
#define ITE_GPIO_REG_POLARITY(x) \
21+
(((x) > 8) ? (0xd1 + ((x) - 9) * 5) \
22+
: (0xb0 + ((x) - 1)) \
23+
)
24+
25+
/* GPIO Internal Pull-up: 1: Enable, 0: Disable */
26+
#define ITE_GPIO_REG_PULLUP(x) \
27+
(((x) > 8) ? (0xd4 + ((x) - 9) * 5) \
28+
: (0xb8 + ((x) - 1)) \
29+
)
30+
31+
/* GPIO Function Select: 1: Simple I/O, 0: Alternate function */
32+
#define ITE_GPIO_REG_FN_SELECT(x) \
33+
(((x) > 8) ? (0xd3 + ((x) - 9) * 5) \
34+
: (0xc0 + ((x) - 1)) \
35+
)
36+
37+
/* GPIO Mode: 0: input mode, 1: output mode */
38+
#define ITE_GPIO_REG_OUTPUT(x) \
39+
(((x) > 8) ? (0xd2 + ((x) - 9) * 5) \
40+
: (0xc8 + ((x) - 1)) \
41+
)
42+
43+
/* GPIO LED pin mapping register */
44+
#define ITE_GPIO_REG_LED_PINMAP(x) (0xf8 + ((x) & 1) * 2)
45+
#define ITE_GPIO_LED_PIN_LOC(set, pin) ((((set) & 7) << 3) | ((pin) & 7))
46+
#define ITE_GPIO_LED_PIN_LOC_MASK 0x3f
47+
/* GPIO LED control register */
48+
#define ITE_GPIO_REG_LED_CONTROL(x) (0xf9 + ((x) & 1) * 2)
49+
#define ITE_GPIO_LED_OUTPUT_LOW (1 << 0)
50+
#define ITE_GPIO_LED_PINMAP_CLEAR (1 << 4)
51+
#define ITE_GPIO_LED_SHORT_LOW_PULSE \
52+
(CONFIG(SUPERIO_ITE_COMMON_GPIO_LED_FREQ_5BIT) ? (1 << 5) \
53+
: (1 << 3) \
54+
)
55+
#define ITE_GPIO_LED_FREQ_SEL(x) \
56+
(CONFIG(SUPERIO_ITE_COMMON_GPIO_LED_FREQ_5BIT) \
57+
? ((((x) & 0x18) << 3) | (((x) & 0x7) << 1)) \
58+
: (((x) & 0x3) << 1) \
59+
)
60+
#define ITE_GPIO_LED_FREQ_SEL_MASK \
61+
(CONFIG(SUPERIO_ITE_COMMON_GPIO_LED_FREQ_5BIT) ? 0xce : 0x06)
62+
63+
static bool ite_has_gpio_fn_select_reg(u8 set)
64+
{
65+
/* IT8718F has all registers for all sets. */
66+
if (CONFIG(SUPERIO_ITE_IT8718F))
67+
return true;
68+
69+
/* Typically ITE GPIO sets 6 to 8 don't have enable and polarity registers. */
70+
if (set < 6 || set > 8)
71+
return true;
72+
73+
return false;
74+
}
75+
76+
static bool ite_has_gpio_polarity_reg(u8 set)
77+
{
78+
/* IT8718F has all registers for all sets. */
79+
if (CONFIG(SUPERIO_ITE_IT8718F))
80+
return true;
81+
82+
/* IT8720F/IT8721F has polarity register for all GPIO sets */
83+
if (CONFIG(SUPERIO_ITE_IT8720F) || CONFIG(SUPERIO_ITE_IT8721F))
84+
return true;
85+
86+
/* Typically ITE GPIO sets 6 to 8 don't have enable and polarity registers. */
87+
if (set < 6 || set > 8)
88+
return true;
89+
90+
return false;
91+
}
92+
93+
static bool ite_has_gpio_pullup_reg(u8 set)
94+
{
95+
/* IT8718F/IT8720F does not have pull-up register for set 2 */
96+
if ((CONFIG(SUPERIO_ITE_IT8718F) || CONFIG(SUPERIO_ITE_IT8720F)) && (set == 2))
97+
return false;
98+
99+
/* IT8783E/F does not have pull-up register for set 6 */
100+
if (CONFIG(SUPERIO_ITE_IT8783EF) && (set == 6))
101+
return false;
102+
103+
/*
104+
* ITE GPIO Sets 7 and 8 don't have a pullup register.
105+
* See IT8786/IT8625 datasheet section 8.10.10.
106+
* Also applies to IT8728F.
107+
*/
108+
if (set != 7 && set != 8)
109+
return true;
110+
111+
return false;
112+
}
113+
114+
/*
115+
* Configures a single GPIO given its number as gpio_num, direction ("in_out"
116+
* parameter) and properties, such as polarity and pull ("gpio_ctrl"
117+
* parameter). The "enable" parameter can configure the GPIO in Simple I/O
118+
* mode when set or Alternate function mode when clear. Some chips may also
119+
* not support configuring all properties for a particular GPIO. It is left to
120+
* the implementer to check if GPIO settings are valid for given gpio_num.
121+
*/
122+
void ite_gpio_setup(pnp_devfn_t gpiodev, u8 gpio_num, enum ite_gpio_direction in_out,
123+
enum ite_gpio_mode enable, u8 gpio_ctrl)
124+
{
125+
u8 set = (gpio_num / 10);
126+
u8 pin = (gpio_num % 10);
127+
128+
/* Number of configurable sets is chip dependent, 8 pins each */
129+
if (gpio_num < 10 || set > CONFIG_SUPERIO_ITE_COMMON_NUM_GPIO_SETS || pin > 7)
130+
return;
131+
132+
pnp_enter_conf_state(gpiodev);
133+
pnp_set_logical_device(gpiodev);
134+
135+
if (ite_has_gpio_fn_select_reg(set))
136+
pnp_unset_and_set_config(gpiodev, ITE_GPIO_REG_FN_SELECT(set),
137+
1 << pin, (enable & 1) << pin);
138+
139+
if (ite_has_gpio_polarity_reg(set))
140+
pnp_unset_and_set_config(gpiodev, ITE_GPIO_REG_POLARITY(set),
141+
1 << pin,
142+
(gpio_ctrl & ITE_GPIO_POL_INVERT) ? 1 << pin : 0);
143+
144+
145+
pnp_unset_and_set_config(gpiodev, ITE_GPIO_REG_OUTPUT(set), 1 << pin, (in_out & 1) << pin);
146+
147+
if (ite_has_gpio_pullup_reg(set))
148+
pnp_unset_and_set_config(gpiodev, ITE_GPIO_REG_PULLUP(set), 1 << pin,
149+
(gpio_ctrl & ITE_GPIO_PULLUP_ENABLE) ? 1 << pin : 0);
150+
151+
pnp_exit_conf_state(gpiodev);
152+
}
153+
154+
void ite_gpio_setup_led(pnp_devfn_t gpiodev, u8 gpio_num,
155+
enum ite_gpio_led led_no,
156+
enum ite_led_frequency freq,
157+
u8 led_ctrl)
158+
{
159+
u8 set = (gpio_num / 10);
160+
u8 pin = (gpio_num % 10);
161+
u8 reg = 0;
162+
163+
/* Number of configurable sets is chip dependent, 8 pins each */
164+
if (gpio_num < 10 || set > CONFIG_SUPERIO_ITE_COMMON_NUM_GPIO_SETS || pin > 7)
165+
return;
166+
167+
/* LED is available only for GPIO sets 1-5 */
168+
if (set > 5)
169+
return;
170+
171+
pnp_enter_conf_state(gpiodev);
172+
pnp_set_logical_device(gpiodev);
173+
174+
/* Pinmap clear bit is only available when frequency is controlled with 5 bits */
175+
if (CONFIG(SUPERIO_ITE_COMMON_GPIO_LED_FREQ_5BIT) && (led_ctrl & ITE_LED_PINMAP_CLEAR))
176+
reg |= ITE_GPIO_LED_PINMAP_CLEAR;
177+
178+
if (led_ctrl & ITE_LED_OUTPUT_LOW)
179+
reg |= ITE_GPIO_LED_OUTPUT_LOW;
180+
181+
if (led_ctrl & ITE_LED_SHORT_LOW_PULSE)
182+
reg |= ITE_GPIO_LED_SHORT_LOW_PULSE;
183+
184+
reg |= ITE_GPIO_LED_FREQ_SEL(freq);
185+
pnp_write_config(gpiodev, ITE_GPIO_REG_LED_CONTROL(led_no), reg);
186+
187+
reg = ITE_GPIO_LED_PIN_LOC(set, pin);
188+
pnp_write_config(gpiodev, ITE_GPIO_REG_LED_PINMAP(led_no), reg);
189+
190+
pnp_exit_conf_state(gpiodev);
191+
}

‎src/superio/ite/common/ite_gpio.h‎

Lines changed: 75 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,75 @@
1+
/* SPDX-License-Identifier: GPL-2.0-or-later */
2+
3+
#ifndef SUPERIO_ITE_COMMON_GPIO_PRE_RAM_H
4+
#define SUPERIO_ITE_COMMON_GPIO_PRE_RAM_H
5+
6+
#include <device/pnp_type.h>
7+
#include <stdint.h>
8+
9+
#define ITE_GPIO_REG_SELECT(x) (0x25 + (x))
10+
11+
enum ite_gpio_control {
12+
ITE_GPIO_CONTROL_DEFAULT = 0,
13+
ITE_GPIO_POL_INVERT = (1 << 0),
14+
ITE_GPIO_PULLUP_ENABLE = (1 << 1),
15+
};
16+
17+
enum ite_gpio_direction {
18+
ITE_GPIO_INPUT,
19+
ITE_GPIO_OUTPUT
20+
};
21+
22+
enum ite_gpio_mode {
23+
ITE_GPIO_ALT_FN_MODE,
24+
ITE_GPIO_SIMPLE_IO_MODE
25+
};
26+
27+
/* There are two GP LED blink register sets */
28+
enum ite_gpio_led {
29+
ITE_GPIO_LED_1,
30+
ITE_GPIO_LED_2
31+
};
32+
33+
enum ite_led_control {
34+
ITE_LED_CONTROL_DEFAULT = 0,
35+
ITE_LED_SHORT_LOW_PULSE = (1 << 0),
36+
ITE_LED_OUTPUT_LOW = (1 << 1),
37+
/*
38+
* Only for ITE SIOs with 5-bit frequency selection.
39+
* When enabled, the LED pin mapping register is cleared when PANSWH# is low for over 4s.
40+
*/
41+
ITE_LED_PINMAP_CLEAR = (1 << 2),
42+
};
43+
44+
enum ite_led_frequency {
45+
/* Most ITE SIOs have 2-bit frequency selection */
46+
ITE_LED_FREQ_4HZ = 0,
47+
ITE_LED_FREQ_1HZ = 1,
48+
ITE_LED_FREQ_0P25HZ = 2,
49+
ITE_LED_FREQ_0P125HZ = 3,
50+
/* ITE SIOs with 5-bit frequency selection: IT8625, IT8613 */
51+
ITE_LED_FREQ_4HZ_DUTY_50 = 0,
52+
ITE_LED_FREQ_1HZ_DUTY_50 = 1,
53+
ITE_LED_FREQ_0P25HZ_DUTY_50 = 2,
54+
ITE_LED_FREQ_2HZ_DUTY_50 = 3,
55+
ITE_LED_FREQ_0P25HZ_DUTY_25 = 4,
56+
ITE_LED_FREQ_0P25HZ_DUTY_75 = 5,
57+
ITE_LED_FREQ_0P125HZ_DUTY_25 = 6,
58+
ITE_LED_FREQ_0P125HZ_DUTY_75 = 7,
59+
ITE_LED_FREQ_0P4HZ_DUTY_20 = 8,
60+
ITE_LED_FREQ_0P5HZ_DUTY_50 = 16,
61+
ITE_LED_FREQ_0P125HZ_DUTY_50 = 24,
62+
};
63+
64+
void ite_gpio_setup(pnp_devfn_t gpiodev, u8 gpio_num,
65+
enum ite_gpio_direction output,
66+
enum ite_gpio_mode enable,
67+
u8 gpio_ctrl);
68+
69+
void ite_gpio_setup_led(pnp_devfn_t gpiodev, u8 gpio_num,
70+
enum ite_gpio_led led_no,
71+
enum ite_led_frequency freq,
72+
u8 led_ctrl);
73+
74+
75+
#endif /* SUPERIO_ITE_COMMON_PRE_RAM_H */

0 commit comments

Comments
 (0)