mb/novacustom/nuc_box: use if (CONFIG()) for SMBIOS guard

filipleple · filipleple · commit 93deeea1061e · 2026-05-18T11:27:51.000+02:00
get_smbios_data is unconditionally present in struct device_operations,
so a preprocessor guard is not needed. Replace #if CONFIG() / #endif
with if (CONFIG()) so the compiler checks both branches.

Upstream-Status: Pending
Signed-off-by: Filip Lewiński &lt;filip.lewinski@3mdeb.com&gt;
diff --git a/src/mainboard/novacustom/nuc_box/ramstage.c b/src/mainboard/novacustom/nuc_box/ramstage.c
@@ -34,9 +34,8 @@ void mainboard_update_soc_chip_config(struct soc_intel_meteorlake_config *config
 
 static void mainboard_enable(struct device *dev)
 {
-#if CONFIG(GENERATE_SMBIOS_TABLES)
-	dev->ops->get_smbios_data = mainboard_smbios_data;
-#endif
+	if (CONFIG(GENERATE_SMBIOS_TABLES))
+		dev->ops->get_smbios_data = mainboard_smbios_data;
 }
 
 struct chip_operations mainboard_ops = {

Original file line number	Diff line number	Diff line change
`@@ -34,9 +34,8 @@ void mainboard_update_soc_chip_config(struct soc_intel_meteorlake_config *config`
`34`	`34`
`35`	`35`	`static void mainboard_enable(struct device *dev)`
`36`	`36`	`{`
`37`		`-#if CONFIG(GENERATE_SMBIOS_TABLES)`
`38`		`- dev->ops->get_smbios_data = mainboard_smbios_data;`
`39`		`-#endif`
	`37`	`+ if (CONFIG(GENERATE_SMBIOS_TABLES))`
	`38`	`+ dev->ops->get_smbios_data = mainboard_smbios_data;`
`40`	`39`	`}`
`41`	`40`
`42`	`41`	`struct chip_operations mainboard_ops = {`