Add FtdiUsbSerialDxe support#615
Closed
filipleple wants to merge 4 commits into
Closed
Conversation
filipleple
force-pushed
the
serial-usb-dxe
branch
from
10ca8f9 to
3d0af18
Compare
filipleple
force-pushed
the
serial-usb-dxe
branch
3 times, most recently
from
7ba5c53 to
7f4c33b
Compare
filipleple
changed the title
filipleple
requested review from
miczyg1 and
mkopec
and removed request for
mkopec
miczyg1
requested changes
Feb 24, 2025
| $(EDK2_PLATFORMS_PATH)/Features/Intel/SystemInformation:\ | ||
| $(EDK2_PLATFORMS_PATH)/Features/Intel/UserInterface | ||
| $(EDK2_PLATFORMS_PATH)/Features/Intel/UserInterface: \ | ||
| $(EDK2_PLATFORMS_PATH)/Drivers/OptionRomPkg/Bus/Usb |
Contributor
There was a problem hiding this comment.
If the path to the moduel has a Pkg in the name, then we should use $(EDK2_PLATFORMS_PATH)/Drivers here
and then in edk2 we would have OptionRomPkg/Bus/Usb/FtdiUsbSerialDxe/FtdiUsbSerialDxe.inf. At least that is the convention used through all tianocore sources.
| CONFIG_PAYLOAD_EDK2=y | ||
| CONFIG_EDK2_REPOSITORY="https://github.com/Dasharo/edk2" | ||
| CONFIG_EDK2_TAG_OR_REV="b7e299856027725ceb5b8da7b52f8a395b665f49" | ||
| CONFIG_EDK2_TAG_OR_REV="4b2b5b6772f53af42c4334bc7adb8814a20b4acf" |
Contributor
There was a problem hiding this comment.
We should bump the revisions for all laptops then.
filipleple
force-pushed
the
serial-usb-dxe
branch
2 times, most recently
from
7e71346 to
5a682c5
Compare
Contributor
|
We also need a Kconfig option to conditionally include the FDTI USB driver. We don't want all platform to include it in the image and increase the binary size unnecessarily. |
filipleple
force-pushed
the
serial-usb-dxe
branch
3 times, most recently
from
dcdd891 to
f1e6667
Compare
Member
Author
|
Added Kconfig option |
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
…port Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
filipleple
force-pushed
the
serial-usb-dxe
branch
from
f1e6667 to
60648eb
Compare
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
filipleple
force-pushed
the
serial-usb-dxe
branch
from
60648eb to
faa9ef4
Compare
Member
Author
|
superseded and merged in a different PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.