NUC BOX v0.9.2 by filipleple · Pull Request #879 · Dasharo/coreboot

filipleple · 2026-04-23T11:33:56Z

filipleple · 2026-04-23T13:09:28Z

The fixes have been backported to the v0.9.0 release tag on nucbox_v0.9.1_oldbase

9a2d8cbd9618b63cf230c25e0ea91317e5e1ff47 (HEAD -> nucbox_v0.9.1_oldbase, origin/nucbox_v0.9.1_oldbase) configs/config.novacustom_nuc_box: bump to v0.9.1-rc1
40da6dee621a9a7093cf2a889ba91997e933cfb0 mb/novacustom/nuc_box/acpi/sleep.asl: fix USB S3 wake
e139baf7ce360defbf5b504a60983acfcbd4be85 mb/novacustom/nuc_box/dsdt.asl: fixes for ghost PS/2 and USB wake
54cc62946343131770f9f25d6b7421a77788d7b3 mb/novacustom/nuc_box/devicetree.cb: move TPM inside domain 0
fdea68ac32a4568922123e4ce68d7f21a8c75b51 (tag: novacustom_nuc_box_v0.9.0) configs/config.novacustom_nuc_box: bump up to v0.9.0

SergiiDmytruk · 2026-04-26T16:58:53Z

Enabling SBOM fails CI due to missing go (log line). Looks like need to use v1.9.0 version of dasharo-sdk.

SergiiDmytruk · 2026-05-14T15:42:16Z

@filipleple, #889 is successfully addressing CI issues.

filipleple · 2026-05-18T08:52:27Z

@filipleple, #889 is successfully addressing CI issues.

@SergiiDmytruk right, thank you, saved me quite a bit of trouble 😅

filipleple · 2026-05-18T09:09:41Z

Looks like the only thing missing is an update of ME.bin in dasharo-blobs.

philipanda · 2026-05-20T05:05:26Z

@filipleple was v0.9.1 never merged to the dasharo branch? I'm a bit confused why there are 17 commits to be merged, not just 4 like #879 (comment) would suggest. Aren't these some rebase errors?

filipleple · 2026-05-20T08:35:56Z

@filipleple was v0.9.1 never merged to the dasharo branch? I'm a bit confused why there are 17 commits to be merged, not just 4 like #879 (comment) would suggest. Aren't these some rebase errors?

@philipanda yes, it was never merged into dasharo, nor targeting it. It was an "assured release" with only the handful of commits atop the v0.9.0 tag prioritizing a fast TPM fix with minimum changes, as you can see with:

λ git log novacustom_nuc_box_v0.9.0..novacustom_nuc_box_v0.9.1 --pretty=oneline
2dda3abf7fe0c78e32c2e6387604124bd6e5b199 (tag: novacustom_nuc_box_v0.9.1, origin/nucbox_v0.9.1_oldbase, nucbox_v0.9.1_oldbase) configs/config.novacustom_nuc_box: bump to v0.9.1 release
9a2d8cbd9618b63cf230c25e0ea91317e5e1ff47 (tag: novacustom_nuc_box_v0.9.1-rc1) configs/config.novacustom_nuc_box: bump to v0.9.1-rc1
40da6dee621a9a7093cf2a889ba91997e933cfb0 mb/novacustom/nuc_box/acpi/sleep.asl: fix USB S3 wake
e139baf7ce360defbf5b504a60983acfcbd4be85 mb/novacustom/nuc_box/dsdt.asl: fixes for ghost PS/2 and USB wake
54cc62946343131770f9f25d6b7421a77788d7b3 mb/novacustom/nuc_box/devicetree.cb: move TPM inside domain 0

That's done, now we're doing v0.9.2, basing on latest dasharo, with a broader scope of fixes and additions, intending to also include the pci2usb controller and a ME update in separate PR's.

I've removed the v0.9.1-related comment from the PR desc.

philipanda · 2026-05-20T08:43:26Z

It was an "assured release"

Ah, right, makes sense 👍

Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>

Fixes the build-time dependencies to elliminate race conditions preparing SBOM in a parallel build. SBOM is generated only when all components are in place, and doesn't trigger any cloning/rebuilds. Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>

Fixes the TPM2 recognition in Windows by ensuring consistent ACPI device path reconstruction Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>

Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>

Fixes ACPI code for proper S3 handling and USB wake enablement Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>

Because UEFI DBX keeps growing in size, and we have a lot of UEFI variables, we've run into an issue where there's not enough free space to update the DBX. Increase the SMMSTORE region to 512K to mitigate this issue. Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>

Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>

Enable debug SMI, which works around issue Dasharo/dasharo-issues#1664. This is a workaround and should be removed once a proper solution to the issue is found. Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>

Improve performance by lowering the EPP value from the power-on default of 0xb3 (70%) to 0x73 (45%). Lower value = higher performance. Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>

Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>

Move mainboard_configure_gpios() from bootblock_mainboard_early_init() to mainboard_init() in ramstage. GPIO configuration does not need to run before DRAM is available and the full device tree context is present. Disable USE_LEGACY_8254_TIMER (required for s0ix/modern standby compatibility) and normalize SIO printk messages to a consistent "SIO: <action> (LDNx)" format. Inline the half_populated constant in the memcfg_init() call. Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>

Required to build with SBOM support, otherwise go is missing Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>

The GH runners have UID 1001, while user coreboot in SDK has id 1000. This creates a mismatch of IDs and causes permission problems when mounting coreboot git repository under /home/coreboot/coreboot in the container, because the /home/coreboot is a HOME directory of different user. To fix the problem, move the mountpoint to a "neutral" place, where permissions should not be a an issue. The /build directory is chosen so that it does not collide with any HOME directory or system directory. Upstream-Status: Inappropriate [Dasharo CI] Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>

Move the mountpoint to /tmp, where permissions should not be a an issue. Upstream-Status: Inappropriate [Dasharo CI] Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>

GCC 13 promotes -Wflex-array-member-not-at-end to an error. The bpm_ibbs and bpm_ibbs_bottom structs contain hash_struct members with flexible arrays that are not at the end of their containing struct. Their layout is fixed by the CBnT hardware specification and cannot be reordered. Suppress the diagnostic with a pragma guard around the affected struct definitions. These hash_struct fields are deprecated since CBnT BWG v1.2.0 and are always written with size=0 (no payload bytes). Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>

$(wildcard ...) already returns an empty string when the path does not exist, so the $(if $(wildcard ...),x,) wrapper is redundant. Replace both payload-swid-ready-dep and ipxe-swid-ready-dep assignments with a plain $(wildcard ...) call. Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>

get_smbios_data is unconditionally present in struct device_operations, so a preprocessor guard is not needed. Replace #if CONFIG() / #endif with if (CONFIG()) so the compiler checks both branches. Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>

filipleple · 2026-05-21T11:21:16Z

Added ME update. Needs Dasharo/dasharo-blobs#58.

SergiiDmytruk · 2026-05-21T16:04:33Z

+		SI_GBE 8K
 #endif
-		SI_ME 0x009ec000   # 10,137,600 bytes = matches IFD exactly
+		SI_ME


I see MTL laptops doing the same, but making size of SI_ME dynamic in the presence of #if CONFIG_MAINBOARD_USES_IFD_GBE_REGION means that one of two configurations won't match IFD. And ifdtool expects an exact match in

coreboot/util/ifdtool/ifdtool.c

Line 1430 in 5e4b1fc

if ((uint)region.base != area->offset || (uint)region.size != area->size) {

The smaller size (10MiB - 16 KiB - 8 KiB) is 0x9FA000 and you want to either specify it and grow IFD region or use the smaller region size from IFD (0x0080f000) but keep the size of SI_ALL as is in both cases.

Hmm, think there's a chance it has to do with users reporting Descriptor: Invalid in HSI after fusing?

Fixing it for the NUC now either way

Since there's no risk of NUC BOX suddenly shipping with the GBE region populated, I've put only one statically defined option: https://github.com/Dasharo/coreboot/compare/1e32ee848f9afe4e491be763dfdd147b942ccbeb..293011cf7141dcff958409824f45d1f952975f40

Hmm, think there's a chance it has to do with users reporting Descriptor: Invalid in HSI after fusing?

Probably not. One (the only?) IFD check resulting in FWUPD_SECURITY_ATTR_RESULT_NOT_VALID that I found is here, which seems to be about region being writable by anything other than it.

Update to latest CSME 18.1.18.2724_v5 for Meteor Lake H/U Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>

After switching from Corporate to Consumer CSME, the ME binary shrunk. This allows to reclaim some free space in the FMAP by shrinking the region. Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>

filipleple self-assigned this Apr 23, 2026

filipleple force-pushed the nuc091 branch from 7c480a4 to 689a323 Compare April 23, 2026 11:51

filipleple changed the title ~~NUC BOX v0.9.1-rc1~~ NUC BOX v0.9.1-rc1 fixes for dasharo branch Apr 23, 2026

filipleple mentioned this pull request Apr 23, 2026

NUC Box: Windows Device Manager shows errors even after updates Dasharo/dasharo-issues#1570

Closed

filipleple requested review from SergiiDmytruk and mkopec April 23, 2026 13:34

filipleple marked this pull request as ready for review April 23, 2026 13:34

SergiiDmytruk reviewed Apr 26, 2026

View reviewed changes

Comment thread src/sbom/Makefile.mk Outdated

SergiiDmytruk reviewed May 5, 2026

View reviewed changes

Comment thread src/mainboard/novacustom/nuc_box/ramstage.c Outdated

filipleple mentioned this pull request May 6, 2026

V54: BIOS settings are randomly reset Dasharo/dasharo-issues#1293

Open

filipleple changed the title ~~NUC BOX v0.9.1-rc1 fixes for dasharo branch~~ NUC BOX v0.9.2 May 7, 2026

filipleple force-pushed the nuc091 branch 3 times, most recently from 4807a60 to 9bc6189 Compare May 14, 2026 14:01

filipleple force-pushed the nuc091 branch from 9bc6189 to 3eb0a18 Compare May 15, 2026 09:35

filipleple marked this pull request as draft May 15, 2026 09:39

filipleple force-pushed the nuc091 branch from 3eb0a18 to d9778a3 Compare May 15, 2026 09:41

filipleple force-pushed the nuc091 branch from 1753fdb to 68fe887 Compare May 18, 2026 09:08

filipleple marked this pull request as ready for review May 18, 2026 09:52

filipleple requested a review from philipanda May 19, 2026 09:01

philipanda reviewed May 20, 2026

View reviewed changes

Comment thread src/mainboard/novacustom/nuc_box/variants/nuc_box/overridetree.cb

philipanda reviewed May 20, 2026

View reviewed changes

Comment thread src/mainboard/novacustom/nuc_box/variants/nuc_box/board.fmd

philipanda reviewed May 20, 2026

View reviewed changes

Comment thread src/mainboard/novacustom/nuc_box/variants/nuc_box/overridetree.cb

filipleple and others added 17 commits May 21, 2026 13:01

configs/config.novacustom_nuc_box: enable SBOM, v0.9.1-rc1

df5c1d4

Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>

mb/novacustom/nuc_box/devicetree.cb: move TPM inside domain 0

4976b49

Fixes the TPM2 recognition in Windows by ensuring consistent ACPI device path reconstruction Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>

mb/novacustom/nuc_box/dsdt.asl: fixes for ghost PS/2 and USB wake

761014e

Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>

mb/novacustom/nuc_box/acpi/sleep.asl: fix USB S3 wake

2b1c46a

Fixes ACPI code for proper S3 handling and USB wake enablement Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>

mb/novacustom/nuc_box/ramstage.c: Generate SMBIOS table with ME FWSTS

3013a97

Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>

mb/novacustom/nuc_box: Bump Energy Performance Preference to 45%

38a411a

Improve performance by lowering the EPP value from the power-on default of 0xb3 (70%) to 0x73 (45%). Lower value = higher performance. Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>

configs/config.novacustom_nuc_box: bump to v0.9.2-rc1

6d55de3

Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>

build.sh: bump DASHARO_SDK up to v1.9.0

63ade56

Required to build with SBOM support, otherwise go is missing Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>

build.sh: fix GOCACHE permissions when building with GH actions

bf1e9bb

Move the mountpoint to /tmp, where permissions should not be a an issue. Upstream-Status: Inappropriate [Dasharo CI] Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>

filipleple force-pushed the nuc091 branch from 93deeea to 9a34317 Compare May 21, 2026 11:19

filipleple force-pushed the nuc091 branch from 9a34317 to 1e32ee8 Compare May 21, 2026 13:19

SergiiDmytruk reviewed May 21, 2026

View reviewed changes

filipleple added 2 commits May 22, 2026 10:35

3rdparty/dasharo-blobs: update NUC BOX ME

d57ba2e

Update to latest CSME 18.1.18.2724_v5 for Meteor Lake H/U Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>

mb/nuc_box/: shrink ME region for consumer bin. in FMAP

293011c

After switching from Corporate to Consumer CSME, the ME binary shrunk. This allows to reclaim some free space in the FMAP by shrinking the region. Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>

filipleple force-pushed the nuc091 branch from 1e32ee8 to 293011c Compare May 22, 2026 08:36

Uh oh!

Conversation

filipleple commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

filipleple commented Apr 23, 2026

Uh oh!

Uh oh!

SergiiDmytruk commented Apr 26, 2026

Uh oh!

Uh oh!

SergiiDmytruk commented May 14, 2026

Uh oh!

filipleple commented May 18, 2026

Uh oh!

filipleple commented May 18, 2026

Uh oh!

philipanda commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

filipleple commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

philipanda commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

filipleple commented May 21, 2026

Uh oh!

SergiiDmytruk May 21, 2026

Choose a reason for hiding this comment

Uh oh!

filipleple May 22, 2026

Choose a reason for hiding this comment

Uh oh!

filipleple May 22, 2026

Choose a reason for hiding this comment

Uh oh!

SergiiDmytruk May 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

filipleple commented Apr 23, 2026 •

edited

Loading

philipanda commented May 20, 2026 •

edited

Loading

filipleple commented May 20, 2026 •

edited

Loading

philipanda commented May 20, 2026 •

edited

Loading

SergiiDmytruk May 23, 2026 •

edited

Loading