fix: Add handling for spark DecimalType#1797
Closed
MCBoarder289 wants to merge 1 commit intoData-Centric-AI-Community:developfrom
Closed
fix: Add handling for spark DecimalType#1797MCBoarder289 wants to merge 1 commit intoData-Centric-AI-Community:developfrom
MCBoarder289 wants to merge 1 commit intoData-Centric-AI-Community:developfrom
Conversation
MCBoarder289
changed the title
This change addresses issue Data-Centric-AI-Community#1602 (Data-Centric-AI-Community#1602). Computations in the summarize process result in some floats when computing against decimal columns. To solution this, we simply convert those types to a DoubleType when performing those numeric operations.
MCBoarder289
force-pushed
the
fix/1602-handle-spark-decimals
branch
from
e473788 to
1ae429e
Compare
Contributor
Author
|
Closing in favor of #1800 which fixes multiple issues at once |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change addresses issue #1602 (#1602).
Computations in the summarize process result in some floats when computing against decimal columns. To solution this, we simply convert those types to a DoubleType when performing those numeric operations.
Open to other suggestions or feedback on this solution!