Skip to content

Commit 1ed65c3

Browse files
committed
Keep version in ddtags and drop snapshot build identity
Preserve the build-version defaulting flow while removing the applicationId-based snapshot build payload and docs/tests that described that unshipped resolution path. This keeps browser snapshots keyed by service plus version without introducing a separate structured build identity. Made-with: Cursor
1 parent 93ca4e3 commit 1ed65c3

4 files changed

Lines changed: 0 additions & 38 deletions

File tree

packages/debugger/README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ When you also use the Datadog Live Debugger build plugin, `init().version` defau
2424

2525
If provided, `version` should be set to the immutable deployed browser build identifier used for source map upload and browser build resolution. If omitted, debugger delivery and snapshots still work, but browser build lookup and source-aware resolution may be unavailable.
2626

27-
> **Prerequisites for source-code resolution.** The `applicationId` passed to `init()` must correspond to a [RUM application](https://docs.datadoghq.com/real_user_monitoring/browser) with a `service` tag configured. The backend uses this to map `applicationId + version` to the repository URL and commit SHA uploaded with your sourcemaps. If the RUM application is missing or has no `service` tag, source-code resolution will gracefully degrade.
28-
2927
If [Datadog RUM][3] is also initialized on the page, debugger snapshots automatically include RUM context (session, view, user action) without any additional configuration.
3028

3129
## Troubleshooting

packages/debugger/src/domain/api.spec.ts

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -321,36 +321,6 @@ describe('api', () => {
321321
expect(snapshot.duration).toBeGreaterThanOrEqual(10000000) // Should be in nanoseconds (>= 10ms)
322322
})
323323

324-
it('should include build identity inside the snapshot payload', () => {
325-
initDebuggerTransport(
326-
{ service: 'test-service', env: 'test-env', applicationId: 'app-123', version: '1.2.3' } as any,
327-
{ add: mockBatchAdd } as any
328-
)
329-
330-
const probe: Probe = {
331-
id: 'test-probe',
332-
version: 0,
333-
type: 'LOG_PROBE',
334-
where: { typeName: 'TestClass', methodName: 'appIdTest' },
335-
template: 'Test',
336-
captureSnapshot: false,
337-
capture: {},
338-
sampling: { snapshotsPerSecond: 5000 },
339-
evaluateAt: 'ENTRY',
340-
}
341-
addProbe(probe)
342-
343-
const probes = getProbes('TestClass;appIdTest')!
344-
onEntry(probes, {}, {})
345-
onReturn(probes, null, {}, {}, {})
346-
347-
const payload = mockBatchAdd.calls.mostRecent().args[0]
348-
expect(payload.debugger.snapshot.build).toEqual({
349-
applicationId: 'app-123',
350-
version: '1.2.3',
351-
})
352-
})
353-
354324
it('should omit trace correlation when no active span context is available', () => {
355325
const probe: Probe = {
356326
id: 'test-probe',

packages/debugger/src/domain/api.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -276,10 +276,6 @@ function sendDebuggerSnapshot(probe: InitializedProbe, result: ActiveEntry): voi
276276
return: result.return,
277277
}
278278
: undefined,
279-
build: {
280-
applicationId: debuggerConfig.applicationId,
281-
version: debuggerConfig.version,
282-
},
283279
}
284280

285281
const debuggerApi = globalObj.DD_DEBUGGER!

packages/debugger/src/entries/main.spec.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ describe('datadogDebugger', () => {
4646
const startDeliveryApiPollingSpy = replaceMockableWithSpy(startDeliveryApiPolling)
4747

4848
datadogDebugger.init({
49-
applicationId: 'app-id',
5049
clientToken: 'client-token',
5150
service: 'service-name',
5251
env: 'staging',
@@ -79,7 +78,6 @@ describe('datadogDebugger', () => {
7978
const warnSpy = spyOn(display, 'warn')
8079

8180
datadogDebugger.init({
82-
applicationId: 'app-id',
8381
clientToken: 'client-token',
8482
service: 'service-name',
8583
env: 'staging',

0 commit comments

Comments
 (0)