Skip to content

Commit b297a1b

Browse files
committed
Skip parser-only expression checks on Firefox
Firefox 67 on BrowserStack disconnects while running the full unit suite after this PR adds the generated-code compatibility checks. The runtime expression tests still pass in Firefox; the problematic block is the Acorn parser loop that validates generated JavaScript syntax against the oldest supported ECMAScript target. Keep that compatibility coverage for the other BrowserStack browsers, but mark it pending on Firefox so Firefox still exercises the debugger runtime behavior without spending time on parser-only coverage.
1 parent 0ee8b66 commit b297a1b

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

packages/debugger/src/domain/expression.spec.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import * as acorn from 'acorn'
2+
import { isFirefox } from '@datadog/browser-core/test'
23
import {
34
literals,
45
references,
@@ -158,6 +159,12 @@ describe('Expression language', () => {
158159
// bypassing TypeScript compilation and webpack transpilation. This test catches usage of syntax
159160
// not supported by older browsers (e.g., optional chaining ?., optional catch binding, nullish coalescing ??).
160161
describe('browser compatibility of generated code', () => {
162+
beforeEach(() => {
163+
if (isFirefox()) {
164+
pending('Browser compatibility is parser-only coverage and is too expensive for Firefox on BrowserStack')
165+
}
166+
})
167+
161168
function assertECMAVersionCompatible(code: string, params: string[] = []) {
162169
const functionCode = `function f(${params.join(', ')}) { ${code} }`
163170
try {

0 commit comments

Comments
 (0)